From: Marek Vasut <marek.vasut@gmail.com>
To: Richard Weinberger <richard@nod.at>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org, dinguyen@kernel.org,
robh+dt@kernel.org, mark.rutland@arm.com,
computersforpeace@gmail.com, dwmw2@infradead.org,
miquel.raynal@bootlin.com, boris.brezillon@bootlin.com,
yamada.masahiro@socionext.com, "See,
Chin Liang" <chin.liang.see@intel.com>
Subject: Re: [PATCH] arm: dts: socfpga: denali needs nand_x_clk too
Date: Thu, 21 Jun 2018 06:41:30 +0200 [thread overview]
Message-ID: <cc717803-97c7-6afd-8cf1-2b4a95fa94e6@gmail.com> (raw)
In-Reply-To: <1846662.BtIxBD6EoV@blindfold>
On 06/20/2018 07:27 AM, Richard Weinberger wrote:
> Marek,
>
> Am Mittwoch, 20. Juni 2018, 06:52:09 CEST schrieb Marek Vasut:
>> On 06/19/2018 02:07 PM, Richard Weinberger wrote:
>>> The denali NAND flash controller needs at least two clocks to operate,
>>> nand_clk and nand_x_clk.
>>> Since 1bb88666775e ("mtd: nand: denali: handle timing parameters by
>>> setup_data_interface()") nand_x_clk is used to derive timing settings.
>>>
>>> Signed-off-by: Richard Weinberger <richard@nod.at>
>>> ---
>>> Strictly speaking denali needs a ecc_clk too, but AFAIK such a clock
>>> is not present on this SoC.
>>> But my SoCFPGA knowledge is very limited.
>>>
>>> Thanks,
>>> //richard
>>
>> It looks sane, but I cannot test it right now, since I'm on vacation.
>> I hope Dinh/Chin can jump in.
>
> The patch was tested by me. So, at least it is not completely untested.
> BTW: I forgot to mention that it depends on Masahiro's Denali fixes.
Then that's perfect.
Reviewed-by: Marek Vasut <marek.vasut@gmail.com>
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2018-06-21 4:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 12:07 [PATCH] arm: dts: socfpga: denali needs nand_x_clk too Richard Weinberger
2018-06-20 4:52 ` Marek Vasut
2018-06-20 5:27 ` Richard Weinberger
2018-06-21 4:41 ` Marek Vasut [this message]
2018-06-22 14:37 ` Masahiro Yamada
2018-06-22 15:58 ` Richard Weinberger
2018-06-25 14:50 ` Dinh Nguyen
2018-06-25 14:55 ` Boris Brezillon
2018-06-26 2:38 ` Masahiro Yamada
2018-06-26 18:09 ` Miquel Raynal
2018-06-27 2:52 ` Masahiro Yamada
2018-06-27 14:55 ` Dinh Nguyen
2018-06-27 21:34 ` Boris Brezillon
2018-07-02 1:35 ` Masahiro Yamada
2018-07-02 13:19 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc717803-97c7-6afd-8cf1-2b4a95fa94e6@gmail.com \
--to=marek.vasut@gmail.com \
--cc=boris.brezillon@bootlin.com \
--cc=chin.liang.see@intel.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).