From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jan Kiszka <jan.kiszka@siemens.com>, Nishanth Menon <nm@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Bao Cheng Su <baocheng.su@siemens.com>,
Chao Zeng <chao.zeng@siemens.com>
Subject: Re: [PATCH 3/3] arm64: dts: ti: iot2050: Add support for M.2 variant
Date: Wed, 18 Jan 2023 18:07:47 +0100 [thread overview]
Message-ID: <cc820b4b-d3b7-9972-a07f-0c9f94f8d175@linaro.org> (raw)
In-Reply-To: <fe57b923d3f290dceea4f54724459015a7bad899.1674059300.git.jan.kiszka@siemens.com>
On 18/01/2023 17:28, Jan Kiszka wrote:
> From: chao zeng <chao.zeng@siemens.com>
>
> The M.2 variant comes with 2 slots, one B-keyed and another one E-keyed.
> They are configured by the firmware during startup. Also the device tree
> will be adjusted according to the detect or manually configured
> interface mode by the firmware. The kernel only carries a single
> configuration as base device tree. It has to be built with a symbols
> node so that the firmware can apply overlays for the connector modes.
>
> Signed-off-by: chao zeng <chao.zeng@siemens.com>
> [Jan: refactored to a single DT]
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> arch/arm64/boot/dts/ti/Makefile | 3 +
> .../dts/ti/k3-am6548-iot2050-advanced-m2.dts | 122 ++++++++++++++++++
> 2 files changed, 125 insertions(+)
> create mode 100644 arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-m2.dts
>
> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
> index cf7c509538a4..13e79bf7e804 100644
> --- a/arch/arm64/boot/dts/ti/Makefile
> +++ b/arch/arm64/boot/dts/ti/Makefile
> @@ -11,6 +11,9 @@ dtb-$(CONFIG_ARCH_K3) += k3-am6528-iot2050-basic.dtb
> dtb-$(CONFIG_ARCH_K3) += k3-am6528-iot2050-basic-pg2.dtb
> dtb-$(CONFIG_ARCH_K3) += k3-am6548-iot2050-advanced.dtb
> dtb-$(CONFIG_ARCH_K3) += k3-am6548-iot2050-advanced-pg2.dtb
> +dtb-$(CONFIG_ARCH_K3) += k3-am6548-iot2050-advanced-m2.dtb
This does not look like proper order.
> +
> +DTC_FLAGS_k3-am6548-iot2050-advanced-m2 += -@
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-18 17:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 16:28 [PATCH 0/3] arm64: dts: Add IOT2050 M.2 board, describe QSPI layout Jan Kiszka
2023-01-18 16:28 ` [PATCH 1/3] arm64: dts: ti: iot2050: Add layout of OSPI flash Jan Kiszka
2023-01-18 16:28 ` [PATCH 2/3] dt-bindings: arm: ti: Add binding for Siemens IOT2050 M.2 variant Jan Kiszka
2023-01-18 17:07 ` Krzysztof Kozlowski
2023-01-18 17:43 ` Raghavendra, Vignesh
2023-01-19 6:34 ` Jan Kiszka
2023-01-19 7:43 ` Krzysztof Kozlowski
2023-01-18 16:28 ` [PATCH 3/3] arm64: dts: ti: iot2050: Add support for " Jan Kiszka
2023-01-18 17:07 ` Krzysztof Kozlowski [this message]
2023-01-19 6:34 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc820b4b-d3b7-9972-a07f-0c9f94f8d175@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=baocheng.su@siemens.com \
--cc=chao.zeng@siemens.com \
--cc=devicetree@vger.kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).