From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m15593.qiye.163.com (mail-m15593.qiye.163.com [101.71.155.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DE2F306D26; Wed, 29 Oct 2025 10:21:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=101.71.155.93 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761733285; cv=none; b=gacOKQOZrScHUeAoXWKHcwK/yTQ9BmvBoaC7rHVPjyuPPZfoGoIAw3lhSN7KeFYRM8So+yqxRtv3N/xad3imWnoMlLLJyaUMK5pfJMU4Q8c6+gUxw5jCL7mpLwTKIK3eye1dOXT5YwuGaxBMqAY5BMq7TsD9hfH2gdoNJZ/UcMo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761733285; c=relaxed/simple; bh=xan45q1JM6Gb5j/2aza7gSh19s2fc7Pzx2s1vX4Banc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CFiriYcsDMO1sW8ctnjA/l3OctwYJ7JICHhDp/rWoUpOMNI77DLjobRtfOpp9Iy3deLNSZ5V2vHf4oyYi00j/inOKde0gLvPJAFxXauWv4kVGkfOIIMgrUMKrmW1YbW7w0ASwB8Z9ww9sM0yjJFbvmEvMmrtU1vsGGGKcCKh3UE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=LdvT8yD5; arc=none smtp.client-ip=101.71.155.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="LdvT8yD5" Received: from [172.16.12.149] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 27a20e337; Wed, 29 Oct 2025 18:21:09 +0800 (GMT+08:00) Message-ID: Date: Wed, 29 Oct 2025 18:21:08 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 10/10] arm64: dts: rockchip: rk3399-evb-ind: Add support for DisplayPort To: Peter Chen , Chaoyi Chen Cc: Heikki Krogerus , Greg Kroah-Hartman , Dmitry Baryshkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Sandy Huang , Andy Yan , Yubing Zhang , Frank Wang , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Amit Sunil Dhamne , Dragan Simic , Johan Jonker , Diederik de Haas , Peter Robinson , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org References: <20251029071435.88-1-kernel@airkyi.com> <20251029071435.88-11-kernel@airkyi.com> Content-Language: en-US From: Chaoyi Chen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Tid: 0a9a2f7c571703abkunmeb663c22345d26 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGhkeGlYYQh9NGEtMSx4dQhlWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSEpPSE xVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=LdvT8yD55DgQk4sSKILpIpTMXTznVSncF63l6VkUkbyLicwzodkCBt91xnRXJAz6qAqJzyDEiy1ZOtqF1gWvG+5YfYbEXIgUeJHQ1NXAoz4QIXjvKBF5G6COWnbG0/O9NjxQJZ7SzaH6qSjtRb0zw7ZkPku5KSQcFgmMTSj/5MY=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=2y//5yz0cKqyDq/eGQvh7lZNErNDwqj5oCuOmDJhx+0=; h=date:mime-version:subject:message-id:from; Hi Peter, On 10/29/2025 5:45 PM, Peter Chen wrote: >> +&i2c4 { >> + i2c-scl-rising-time-ns = <475>; >> + i2c-scl-falling-time-ns = <26>; >> + status = "okay"; >> + >> + usbc0: typec-portc@22 { >> + compatible = "fcs,fusb302"; >> + reg = <0x22>; >> + interrupt-parent = <&gpio1>; >> + interrupts = ; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&usbc0_int>; >> + vbus-supply = <&vbus_typec>; >> + >> + usb_con: connector { >> + compatible = "usb-c-connector"; >> + label = "USB-C"; >> + data-role = "dual"; >> + power-role = "dual"; >> + try-power-role = "sink"; >> + op-sink-microwatt = <1000000>; >> + sink-pdos = >> + ; >> + source-pdos = >> + ; >> + >> + altmodes { >> + displayport { >> + svid = /bits/ 16 <0xff01>; >> + vdo = <0x00001c46>; >> + }; >> + }; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + >> + usbc_hs: endpoint { >> + remote-endpoint = <&u2phy0_typec_hs>; >> + }; >> + }; >> + > Why USB2 PHY needs to be notified for Type-C connection? I think the USB-connector binding require a port@0 for High Speed.  So I filled in USB2 PHY here. And I have looked up boards with the same usage, and some of the results are as follows: - rk3399-firefly.dts - rk3399-pinebook-pro.dts - rk3399-eaidk-610.dts > >> + port@1 { >> + reg = <1>; >> + >> + usbc_ss: endpoint { >> + remote-endpoint = <&tcphy0_typec_ss>; >> + }; >> + }; >> + >> + port@2 { >> + reg = <2>; >> + >> + usbc_dp: endpoint { >> + remote-endpoint = <&tcphy0_typec_dp>; >> + }; >> + }; >> + }; >> + }; >> + }; >> +}; >> + > ..... >> &u2phy0 { >> status = "okay"; >> + >> + port { >> + u2phy0_typec_hs: endpoint { >> + remote-endpoint = <&usbc_hs>; >> + }; >> + }; >> }; >> > There is no switch and mux, how to co-work with Type-C? I checked the phy-rockchip-inno-usb2.c but did not find any switch or mux. Does this mean that we need to implement them? Thank you. > > Best regards, > Peter > > -- Best, Chaoyi