From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B56A0CCA479 for ; Mon, 18 Jul 2022 14:32:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233431AbiGROcx (ORCPT ); Mon, 18 Jul 2022 10:32:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234422AbiGROcu (ORCPT ); Mon, 18 Jul 2022 10:32:50 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3584237EC for ; Mon, 18 Jul 2022 07:32:46 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id x10so13362167ljj.11 for ; Mon, 18 Jul 2022 07:32:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=gEdQYmEqnlsP0uD7xKRiFLeBFu1VzPoHV+TkuJ6H2ao=; b=SWoaDom9JBWHsN8wgxDlRqIoDnx/Cb4AlkgNgGU447NI7K2FD/z6tz6CWff3nC8TvY f62Ge0qiYdQYJsSr1u+EWUWviRqwk/+scqzDvMwUW4NREU6zEh4AXFfFtHlKdQo7pB8u 4EeR10DLWiqRYtoNAL670UFOlHoOPmtUQBmQKXKv46isBbvpB44XuDA0H1yfq1gbb7Wu PVn1Jk/ygTOps6JdSCfvxH4MlxPWl8YMpqtDvuiHjPcgyApriYxxTc5yHz55+GLNGxrF FXmaWfgKlxdKj7dGVetrmpVfSBuQII/47/sQmRanGnQ0OzV4ePXD1z5gA2IcEv/CUgJI y7Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=gEdQYmEqnlsP0uD7xKRiFLeBFu1VzPoHV+TkuJ6H2ao=; b=R672Vy/FE+kLJ05BB9GWseGqB091hC/yyiankXLwQ5U7qvB7s5+oQA78+FLE+66TF3 yuO1ZSzHOruqKPesY3fa9jpQ7i5OElXrNkXngmZPEzUQGjGkoW+5AeZ5NneclzEduZWL CNLKErRJ/1XxuO9qyXU8acoKmFDUHky/ViSskjBvA/88fzuRYqfNmBDqvmJzLjQAsFYE uIiicU20jLGfsgL/5KxI/a26Pf1H6Uar2iSbftVfNKZdZcy9dT3sldJzTO9Uxnzii5Bj HQruAbliuM8sb6xMmB3ZKqdKDaZ3XGVk3EQos5csGjPyfE8W9XgQD542L7OdptUAYjT1 lEZQ== X-Gm-Message-State: AJIora+4WDNbEwF5yrhcyHuddnQBzbeJSNWaGMAc5h9Cxmu2+4GFxmH4 BVaxgHW1sOfWwjBfKaFk2Qclcw== X-Google-Smtp-Source: AGRyM1su6+TSqh/bFxly6R5TLik4Rd3lY7VPFNnUzLeF/JOUYG68BNcM2RiaMpvC62B/3SJteUU9zg== X-Received: by 2002:a2e:b70b:0:b0:25d:52f3:3043 with SMTP id j11-20020a2eb70b000000b0025d52f33043mr12502767ljo.380.1658154764935; Mon, 18 Jul 2022 07:32:44 -0700 (PDT) Received: from [192.168.115.193] (89-162-31-138.fiber.signal.no. [89.162.31.138]) by smtp.gmail.com with ESMTPSA id x26-20020a19e01a000000b0047f8fd27402sm2634589lfg.146.2022.07.18.07.32.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jul 2022 07:32:44 -0700 (PDT) Message-ID: Date: Mon, 18 Jul 2022 16:32:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 2/2] dt-bindings: fpga: add binding doc for ecp5-spi fpga mgr Content-Language: en-US To: Ivan Bornyakov Cc: mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, trix@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-fpga@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, system@metrotek.ru References: <20220718114928.22092-1-i.bornyakov@metrotek.ru> <20220718114928.22092-3-i.bornyakov@metrotek.ru> <20220718142427.vhwswafw7sa5ec6v@h-e2.ddg> From: Krzysztof Kozlowski In-Reply-To: <20220718142427.vhwswafw7sa5ec6v@h-e2.ddg> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/07/2022 16:24, Ivan Bornyakov wrote: > On Mon, Jul 18, 2022 at 03:58:22PM +0200, Krzysztof Kozlowski wrote: >> On 18/07/2022 13:49, Ivan Bornyakov wrote: >>> Add Device Tree Binding doc for Lattice ECP5 FPGA manager using slave >>> SPI to load .bit formatted uncompressed bitstream image. >>> >>> Signed-off-by: Ivan Bornyakov >>> --- >>> .../bindings/fpga/lattice,ecp5-fpga-mgr.yaml | 73 +++++++++++++++++++ >>> 1 file changed, 73 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/fpga/lattice,ecp5-fpga-mgr.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/fpga/lattice,ecp5-fpga-mgr.yaml b/Documentation/devicetree/bindings/fpga/lattice,ecp5-fpga-mgr.yaml >>> new file mode 100644 >>> index 000000000000..bb10fd316f94 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/fpga/lattice,ecp5-fpga-mgr.yaml >>> @@ -0,0 +1,73 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/fpga/lattice,ecp5-fpga-mgr.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Lattice ECP5 Slave SPI FPGA manager. >>> + >>> +maintainers: >>> + - Ivan Bornyakov >>> + >>> +description: >>> + FPGA Manager capable to program Lattice ECP5 with uncompressed bitstream >>> + image in .bit format over SPI. >> >> The same question as before - you need to explain what is the hardware >> (not Linux API or Linux subsystem). >> > > I really don't know what to say aside from "thing that capable to > program FPGA". Is there a good exmple of proper wording in > Documentation/devicetree/bindings/fpga/? > Otherwise I would ask FPGA Manager framework maintainers assistance on > how to describe a FPGA Manager driver. I think my first reply had some leads to possible description. Is it a piece of FPGA? Is it a programmable block of FPGA? Is it dedicated chip on SPI line? The only problem I see with description is that word "manager" is too generic and people can call everything manager... Best regards, Krzysztof