From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Herve Codina <herve.codina@bootlin.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Magnus Damm <magnus.damm@gmail.com>,
Gareth Williams <gareth.williams.jx@renesas.com>,
linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH v2 6/7] ARM: dts: r9a06g032: Add the USBF controller node
Date: Tue, 15 Nov 2022 15:58:59 +0100 [thread overview]
Message-ID: <cca63c93-afd7-12ba-b73f-f7d28870074d@linaro.org> (raw)
In-Reply-To: <CAMuHMdUHEc6XYcdrcZ=H_wjBy4vFBTRjUDE2rRmGd+Jyg7BzDQ@mail.gmail.com>
On 15/11/2022 15:11, Geert Uytterhoeven wrote:
>>> + udc: usb@4001e000 {
>>> + compatible = "renesas,r9a06g032-usbf", "renesas,rzn1-usbf";
>>> + reg = <0x4001e000 0x2000>;
>>> + interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>;
>>> + clocks = <&sysctrl R9A06G032_HCLK_USBF>,
>>> + <&sysctrl R9A06G032_HCLK_USBPM>;
>>> + clock-names = "hclkf", "hclkpm";
>>> + power-domains = <&sysctrl>;
>>> + status = "disabled";
>>
>> If you provided all resources (clocks, power domains etc), why disabling it?
>
> Doesn't this depend on wiring on the board, and providing pin control
> in the board DTS?
>
Yes, that could be the reason, so if this was the intention, it's fine.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-15 14:59 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 11:15 [PATCH v2 0/7] Add the Renesas USBF controller support Herve Codina
2022-11-14 11:15 ` [PATCH v2 1/7] soc: renesas: r9a06g032-sysctrl: Export function to get the usb role Herve Codina
2022-11-14 13:33 ` Geert Uytterhoeven
2022-11-14 11:15 ` [PATCH v2 2/7] dt-bindings: clock: renesas,r9a06g032-sysctrl: Add h2mode property Herve Codina
2022-11-14 13:33 ` Geert Uytterhoeven
2022-11-15 13:05 ` Krzysztof Kozlowski
2022-11-15 13:07 ` Krzysztof Kozlowski
2022-11-15 14:04 ` Herve Codina
2022-11-18 10:23 ` Herve Codina
2022-11-21 11:43 ` Krzysztof Kozlowski
2022-11-21 15:59 ` Herve Codina
2022-11-21 16:33 ` Krzysztof Kozlowski
2022-11-21 16:36 ` Geert Uytterhoeven
2022-11-21 17:11 ` Krzysztof Kozlowski
2022-11-21 20:46 ` Geert Uytterhoeven
2022-11-22 7:45 ` Krzysztof Kozlowski
2022-11-22 8:25 ` Geert Uytterhoeven
2022-11-22 8:42 ` Krzysztof Kozlowski
2022-11-22 9:01 ` Geert Uytterhoeven
2022-11-22 10:23 ` Krzysztof Kozlowski
2022-11-22 10:26 ` Geert Uytterhoeven
2022-11-22 10:34 ` Krzysztof Kozlowski
2022-11-22 9:07 ` Herve Codina
2022-11-22 10:30 ` Krzysztof Kozlowski
2022-11-22 10:47 ` Geert Uytterhoeven
2022-11-23 9:39 ` Krzysztof Kozlowski
2022-11-24 9:36 ` Miquel Raynal
2022-11-24 9:46 ` Krzysztof Kozlowski
2022-11-24 10:27 ` Miquel Raynal
2022-11-24 10:44 ` Miquel Raynal
2022-11-14 11:15 ` [PATCH v2 3/7] soc: renesas: r9a06g032-sysctrl: Handle h2mode device-tree property Herve Codina
2022-11-14 13:32 ` Geert Uytterhoeven
2022-11-14 11:15 ` [PATCH v2 4/7] dt-bindings: usb: add the Renesas RZ/N1 USBF controller binding Herve Codina
2022-11-15 13:13 ` Krzysztof Kozlowski
2022-11-15 13:29 ` Herve Codina
2022-11-14 11:15 ` [PATCH v2 5/7] usb: gadget: udc: add Renesas RZ/N1 USBF controller support Herve Codina
2022-11-14 11:15 ` [PATCH v2 6/7] ARM: dts: r9a06g032: Add the USBF controller node Herve Codina
2022-11-15 13:16 ` Krzysztof Kozlowski
2022-11-15 13:27 ` Herve Codina
2022-11-15 15:09 ` Herve Codina
2022-11-15 16:30 ` Krzysztof Kozlowski
2022-11-15 14:11 ` Geert Uytterhoeven
2022-11-15 14:58 ` Krzysztof Kozlowski [this message]
2022-11-16 8:51 ` Geert Uytterhoeven
2022-11-14 11:15 ` [PATCH v2 7/7] MAINTAINERS: add the Renesas RZ/N1 USBF controller entry Herve Codina
2022-11-15 12:20 ` kernel test robot
2022-11-15 13:24 ` Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cca63c93-afd7-12ba-b73f-f7d28870074d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gareth.williams.jx@renesas.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=herve.codina@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).