From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E3E9C433FE for ; Tue, 15 Nov 2022 14:59:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230318AbiKOO7F (ORCPT ); Tue, 15 Nov 2022 09:59:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230009AbiKOO7E (ORCPT ); Tue, 15 Nov 2022 09:59:04 -0500 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0537523175 for ; Tue, 15 Nov 2022 06:59:03 -0800 (PST) Received: by mail-lj1-x235.google.com with SMTP id t10so17884615ljj.0 for ; Tue, 15 Nov 2022 06:59:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HYHQt7itCTdM7tQOSkDoNSdG5hIzfOsUcZ1K9F1d7kA=; b=LtsVRkRE1USanAXoAUY0HXOCia6YZE6iTd+CQirhwunvmvRlEW6plP+M+7xV7+c1NU H9x+dfDPNkZ44zLwCsh5R8rIKIW/4RoJeWuCf/fCqC+aHiFdjCm6xpmR28RhEMzpHaG0 TIt7GgjxJmTWRDnfC8I3iu7pVawIUuP8NNrxDHUEDdlz1xZXkvxS+0eIPhsHLRkBWUxG VTljnD+7H6uK/1t05D2GvVLdOY02hL0SUhnsw33VigEey0T3Bgl1EMEXqN5RuuNfmk1X Do8cu4B7K+L7x0tPxXpmgWskVpfgTtZ/Rk1MAUaUrP7qXiN9dTGjHqUHQWkHfQ0bKz9g znsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HYHQt7itCTdM7tQOSkDoNSdG5hIzfOsUcZ1K9F1d7kA=; b=zRnRcuI2+57G28TZiUUdl1wlplVG8XtAlW+Z70N2O/qCSN4YwErdzccmkqN4fcFf3W fEkKml2ZGs8m+4jO8m61w0aqsr9B4HbSP/OfnX9Fa750SWljelH0YJZ8vfRNbhaDoK2q +IqYBVsdHakDaL0+08Z+4CFP6j/eqSekOm/ODwddtSXprJSOknoREhEU7M06x2cHd8Xm s2I8/NwwATxnlbx/2h3sMf66r/WCFZPEZ+O/xp5Y0sfSxu/T9eU1H7eyto97fL2YURT6 8epBIYD4hQLznEI6fTLAklxSWujrCfpymco7GS36bvT3fTQXSXER1FD7BttI/acetjtK zBuA== X-Gm-Message-State: ANoB5pl2drdU9jjspvDV6IYrgaA4tbLD4cEyVJZdAYxJZnsOwMV5xpvB d91QAvpNXB40G0TYCkUDk91WtQ== X-Google-Smtp-Source: AA0mqf6I+kq7LIwQ7yhfRgW226duI2RLRbLmoUqTaDpTnaJXSf412EiQOBpBpv+DuPqS3XN22Nlikg== X-Received: by 2002:a2e:7217:0:b0:277:2f73:9f7a with SMTP id n23-20020a2e7217000000b002772f739f7amr5682701ljc.448.1668524341362; Tue, 15 Nov 2022 06:59:01 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id y20-20020ac24214000000b004b384ae61absm2235672lfh.198.2022.11.15.06.58.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Nov 2022 06:59:00 -0800 (PST) Message-ID: Date: Tue, 15 Nov 2022 15:58:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 6/7] ARM: dts: r9a06g032: Add the USBF controller node Content-Language: en-US To: Geert Uytterhoeven Cc: Herve Codina , Geert Uytterhoeven , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Greg Kroah-Hartman , Magnus Damm , Gareth Williams , linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Thomas Petazzoni , Miquel Raynal References: <20221114111513.1436165-1-herve.codina@bootlin.com> <20221114111513.1436165-7-herve.codina@bootlin.com> <51d42fc2-0492-9077-302d-5c3be4b45cd1@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 15/11/2022 15:11, Geert Uytterhoeven wrote: >>> + udc: usb@4001e000 { >>> + compatible = "renesas,r9a06g032-usbf", "renesas,rzn1-usbf"; >>> + reg = <0x4001e000 0x2000>; >>> + interrupts = , >>> + ; >>> + clocks = <&sysctrl R9A06G032_HCLK_USBF>, >>> + <&sysctrl R9A06G032_HCLK_USBPM>; >>> + clock-names = "hclkf", "hclkpm"; >>> + power-domains = <&sysctrl>; >>> + status = "disabled"; >> >> If you provided all resources (clocks, power domains etc), why disabling it? > > Doesn't this depend on wiring on the board, and providing pin control > in the board DTS? > Yes, that could be the reason, so if this was the intention, it's fine. Best regards, Krzysztof