From: Florian Fainelli <f.fainelli@gmail.com>
To: Rob Herring <robh@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: net: dsa: brcm,sf2: Drop unneeded "#address-cells/#size-cells"
Date: Wed, 5 Apr 2023 05:24:08 -0700 [thread overview]
Message-ID: <cca77857-4a1a-6b56-5dfa-0eda752d371f@gmail.com> (raw)
In-Reply-To: <20230404204152.635400-1-robh@kernel.org>
On 4/4/2023 1:41 PM, Rob Herring wrote:
> There's no need for "#address-cells/#size-cells" in the brcm,sf2 node as
> no immediate child nodes have an address. What was probably intended was
> to put them in the 'ports' node, but that's not necessary as that is
> covered by ethernet-switch.yaml via dsa.yaml.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2023-04-05 12:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 20:41 [PATCH] dt-bindings: net: dsa: brcm,sf2: Drop unneeded "#address-cells/#size-cells" Rob Herring
2023-04-05 11:30 ` Vladimir Oltean
2023-04-05 12:24 ` Florian Fainelli [this message]
2023-04-06 0:54 ` Jakub Kicinski
2023-04-06 1:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cca77857-4a1a-6b56-5dfa-0eda752d371f@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).