From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bhupesh Sharma <bhupesh.sharma@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org
Cc: agross@kernel.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, thara.gopinath@gmail.com,
devicetree@vger.kernel.org, robh@kernel.org,
andersson@kernel.org, bhupesh.linux@gmail.com,
catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de,
Jordan Crouse <jorcrous@amazon.com>
Subject: Re: [PATCH v6 1/4 RESEND] ARM: dts: qcom: Use new compatibles for crypto nodes
Date: Tue, 20 Sep 2022 11:39:29 +0200 [thread overview]
Message-ID: <ccc318c0-ee1b-d538-6d2b-bf85a3c9c6fd@linaro.org> (raw)
In-Reply-To: <00dd028f-d636-0cda-40ce-01d5addcbec9@linaro.org>
On 20/09/2022 10:57, Bhupesh Sharma wrote:
>>> crypto: crypto@8e3a000 {
>>> - compatible = "qcom,crypto-v5.1";
>>> + compatible = "qcom,ipq4019-qce";
>>
>> There are few issues here:
>> 1. Compatible is not documented.
>
> Its documented here:
> https://lore.kernel.org/linux-arm-msm/30756e6f-952f-ccf2-b493-e515ba4f0a64@linaro.org/
>
> [as mentioned in the dependency section in the cover letter :)]
>
>> 2. Compatible is not supported by old kernel - ABI break.
You cannot fix this with dependencies/ordering.
>> 3. Everything won't be bisectable...
>
> I think its a question of dependencies b/w the patchsets intended for
> separate areas. Let me think more on how, I can resolve it in newer
> versions.
DTS always goes separately so this also cannot be fixed with ordering or
dependencies. However if Bjorn is fine with it, it's good.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-20 9:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 22:15 [PATCH v6 0/4 RESEND] ARM: dts + defconfig: Add support for Qualcomm QCE block on new SoCs and in defconfig Bhupesh Sharma
2022-09-19 22:15 ` [PATCH v6 1/4 RESEND] ARM: dts: qcom: Use new compatibles for crypto nodes Bhupesh Sharma
2022-09-20 7:25 ` Krzysztof Kozlowski
2022-09-20 8:57 ` Bhupesh Sharma
2022-09-20 9:39 ` Krzysztof Kozlowski [this message]
2022-09-20 10:48 ` Bhupesh Sharma
2022-09-20 11:16 ` Krzysztof Kozlowski
2022-09-20 11:43 ` Bhupesh Sharma
2022-09-19 22:15 ` [PATCH v6 2/4 RESEND] arm64: dts: qcom: sm8250: Add dt entries to support crypto engine Bhupesh Sharma
2022-09-19 22:15 ` [PATCH v6 3/4 RESEND] arm64: dts: qcom: sm8150: " Bhupesh Sharma
2022-09-19 22:15 ` [PATCH v6 4/4 RESEND] arm64: defconfig: Enable Qualcomm QCE crypto Bhupesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccc318c0-ee1b-d538-6d2b-bf85a3c9c6fd@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=bhupesh.linux@gmail.com \
--cc=bhupesh.sharma@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=jorcrous@amazon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=thara.gopinath@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).