From: Krzysztof Kozlowski <krzk@kernel.org>
To: Peter Chen <peter.chen@cixtech.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
gregkh@linuxfoundation.org, pawell@cadence.com,
rogerq@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
cix-kernel-upstream@cixtech.com,
linux-arm-kernel@lists.infradead.org, arnd@arndb.de
Subject: Re: [PATCH 3/4] dt-bindings: usb: add CIX Sky1 Cadence USB3 controller
Date: Fri, 15 May 2026 13:18:53 +0200 [thread overview]
Message-ID: <ccc8ab6c-d301-4585-8be3-1977485c5e87@kernel.org> (raw)
In-Reply-To: <agb0he7vvbqSIym5@nchen-desktop>
On 15/05/2026 12:25, Peter Chen wrote:
> On 26-05-15 09:54:10, Krzysztof Kozlowski wrote:
>> EXTERNAL EMAIL
>>
>> On Mon, May 11, 2026 at 10:42:43AM +0800, Peter Chen wrote:
>>> Add a binding for the CIX Sky1 integration of the Cadence USBSSP DRD
>>> controller. The schema documents the glue register window, clocks,
>>> resets, interrupts and S5 system controller phandle.
>>>
>>> Signed-off-by: Peter Chen <peter.chen@cixtech.com>
>>> ---
>>> .../bindings/usb/cix,sky1-cdns3.yaml | 151 ++++++++++++++++++
>>
>> Why are you mixing USB patches with DTS in one patchset? Don't.
>
> In this series, the 1st patch is the IP core driver changes (export APIs for glue layer
> use), and the second glue layer patch is the user for new adding APIs.
Not really answer to my question. Why is DTS here? It has nothing to do
with 1st patch, second patch or this one.
> Normally, we combine dt-binding, driver (glue layer) and DTS changes at one patch series.
>
> It is much like below submission:
>
> https://lore.kernel.org/all/20250318-dwc3-refactor-v5-0-90ea6e5b3ba4@oss.qualcomm.com/
Which is also wrong. Why do people pick bad examples as arguments
instead of finding one of my many emails telling why is that incorrect?
Or maybe all the folks who dig through the archives and found my emails
did not continued discussion...
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-05-15 11:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 2:42 [PATCH 0/4] Add CIX Sky1 Cadence USB3 support Peter Chen
2026-05-11 2:42 ` [PATCH 1/4] usb: cdns3: plat: Expose platform core driver as library Peter Chen
2026-05-11 23:02 ` sashiko-bot
2026-05-12 7:03 ` Peter Chen
2026-05-11 2:42 ` [PATCH 2/4] usb: cdns3: sky1: Add cdnsp-sky1 glue driver Peter Chen
2026-05-11 23:17 ` sashiko-bot
2026-05-12 7:43 ` Peter Chen
2026-05-11 2:42 ` [PATCH 3/4] dt-bindings: usb: add CIX Sky1 Cadence USB3 controller Peter Chen
2026-05-15 7:54 ` Krzysztof Kozlowski
2026-05-15 10:25 ` Peter Chen
2026-05-15 11:18 ` Krzysztof Kozlowski [this message]
2026-05-11 2:42 ` [PATCH 4/4] arm64: dts: cix: add Sky1 USB4 and USB5 controllers Peter Chen
2026-05-11 23:59 ` sashiko-bot
2026-05-12 3:10 ` Peter Chen
2026-05-15 7:54 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccc8ab6c-d301-4585-8be3-1977485c5e87@kernel.org \
--to=krzk@kernel.org \
--cc=arnd@arndb.de \
--cc=cix-kernel-upstream@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pawell@cadence.com \
--cc=peter.chen@cixtech.com \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox