Re: [PATCH v3] watchdog: Add driver for Gunyah Watchdog

[Krzysztof Kozlowski <krzk@kernel.org>]

On 28/10/2025 17:06, Guenter Roeck wrote:
> On 10/28/25 02:35, Hrishabh Rajput via B4 Relay wrote:
>> +
>> +	ret = gunyah_wdt_call(GUNYAH_WDT_STATUS, 0, 0, &res);
>> +	if (ret)
>> +		return -ENODEV;
>> +
>> +	ret = platform_driver_register(&gunyah_wdt_driver);
>> +	if (ret)
>> +		return ret;
>> +
>> +	gunyah_wdt_dev = platform_device_register_simple(GUNYAH_WDT_DRV_NAME,
>> +							 -1, NULL, 0);
> 
> I did not follow the discussion around this, so I may be missing something.
> If so, apologies.
> 
> This is a highly unusual approach. What is the point of not instantiating
> the watchdog device through devicetree and doing it in the init function
> instead ? There should be a devicetree node which instantiates the device;
> it should never be instantiated from the init function unless there _is_
> no devicetree, which is obviously not the case here.


We told that to them already... Every iteration of gunyah feels like
pushing their approach without regard to community feedback.


Best regards,
Krzysztof