From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93EC7492E4A for ; Fri, 11 Sep 2026 17:44:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789148652; cv=none; b=Dmhy03iJTyM9Y+5tvdQn4f9Iu6lkQoVbZJS1ZvHLzRbSUkZp/TVvmu9qp3WArrFokZ+dB2IpAju+glgkWIfPwbBY8vgJhr4jQaEa2MVPbVRyvKRGEyQg6cd1iqYExPD4Oz37D5HdavcK/pbL/Bzo4bwxHq8Wn3fAaQ28jlQX2Gk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789148652; c=relaxed/simple; bh=iSPOqrPEqNzouRgsfdtXLZvJztzijYXXcFDpMwJ0MLA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Qjdjr83iw0iXEMCDRBs186UItwREFVQ9znq4PXhHO83OzEPF+tyb0Ptdf/JLgAUH/Nlgx5+BjQbxjBwNIpKP6ZMZHCliy+fZid336Faut8ekLgSD3inFoaN8gdUFTrHoLmW4mG+e8O+fDmCJYqqkA4Xs81m/Fu2khxJoCWc6PNs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=n4IDtP6q; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=M2UM6Q2R; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="n4IDtP6q"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="M2UM6Q2R" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68BHWQ4p4119156 for ; Fri, 11 Sep 2026 17:44:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= DgHv3EdPhIoOXyHYgFVg1PHeH4W7/S2tlAAVOYQ4qy8=; b=n4IDtP6qSCRsrs5Q Ci4u+5w6+EkIJ71oFw1Y1zQstpX89A/BA76Y5fXofq8whvtRYA60+EDh++ODP6je 093MTlj0PZIJ9QWlFP+CTD4uZZMyeiGMunBt7EcTEScrl+C01OLfh7GHre4s12y1 p1emmt65w4qtjfhKGdQ0ybxnk3ASvHxEWv4UMubu4tDmyIPnDgj9gYU53c/dwkf2 FvTwmMILkTRQLxInIObPo6sbKMLwJc3pzEHDkZlbI1ur/FbH7M7BQO++fEB6M6AC 1K4lQ4UInF8h8uKQJHH7mm5sHbSuXVZkUgL19Gd7LkJbRFxbUT0AZfrhu4yu0VMT UWsiCQ== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gmnkmr62f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 11 Sep 2026 17:44:04 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cc1a439db36so1100258a12.2 for ; Fri, 11 Sep 2026 10:44:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789148644; x=1789753444; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=DgHv3EdPhIoOXyHYgFVg1PHeH4W7/S2tlAAVOYQ4qy8=; b=M2UM6Q2RpbLz9XEG32Hh7mBTLecw0PAyI7RHivV9LWBslUSTZK6lEyfA2AE+s4EdqX 47WEI8GgtTDy7s2Sryt3hkQhoVz6TGmWm7taa7QmlGKNaynwhHY+RkicKxq0PhJd+lk0 2qakA0Gpj6eJhDx8m4H53Y6TN7+va78k/1WOPtIsWeVoOc6ZSv3KMNpxR8GBUD7imCS/ Ierw0Pv+jRo58RfCVxCsdZNRn7LNdM+kjbjzqAMu+W97fYwQtxM8fBPjwtgpeG5eGjIK 5soquehSo7gDSIaHk2oyc9O4TvDo4HoiwCqISbXArfmISiovupHJsFg3APO9qiLHwUgA +6gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789148644; x=1789753444; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=DgHv3EdPhIoOXyHYgFVg1PHeH4W7/S2tlAAVOYQ4qy8=; b=lqFjI6hFU+495GhajcNUJ/9Z0L1ot5TiK8/hkpZ34rPsSm8NfMmZ69LCzJO0B1lYpt pwcOtlU6tlTSVp2ca7RkVcLm6dT78KQBXrUtbgpBdtgvFElbc08qt7NpD9c0sCyzRn+x QHlqIpVdLXK4DoUEuhc1EZJSFI30APGaveKYTY7JJUmxdSSdwwKPdGH6SpR1gPemP6Br L3e/fM0FrkliuKf/r8najLt3VHKCqAVRwoYQmlQl0hZgLlv3is/gHRPzLAs+iD4Gma3w EHaBmY0IbNY0/XnycgtaYgELm/CIXeeQwImtqAOwBL/lYhf6Ydck8TkQIT+xd6sadleb Bfmg== X-Forwarded-Encrypted: i=1; AKwUvBwRm60VlFqozAg8NUe0Y8IsZoOga5B9+l0NOsAhEi4uOZ6Lribl327PrByO0Y/HyLvV5aAHADJZXnZW@vger.kernel.org X-Gm-Message-State: AFuF++n38nX/asAl2+F+jydIOO/QUVcPJjGtNVTA/2O0zQIhSI/bYVaL IhwN+vhI2OgTok4Ack583LYSgTK15oJoLyXHgVbmCF06elYMjDlcKhFKsFKVd799j3xIM08elsT E4rQJ9sbnZ0qXPESiR84TJZFHbHD+mNwNmOC7kAloK57iZ44E4X/W5Yv13wJGFcen X-Gm-Gg: AYBFou0n9jLQK80P22peVVe0rlBTUX7/S6hRNA7HPHFYTwCPkkvYzCMR0cO3Riqy10r 2MvAySzNHOBGUn99PXPPYZQDpeo0ngZ7REBITqwe1EEpQVjp95WHyBeXWVfrlcM3+svLJWJRK/V X49Fld786/wgkLrt1r/VX1L+YqHKNZtgUoTMpzt97NFEXtgfcViPALVeAsgAfHP/s0UsiGedZVT OzBB2dQbLrRJ8YSX/MHEKsh+Q7XsstkdGybK+DazR0GvwsyU31oS2EXX3x1PjhwtsZrh6co9Jnk nbkq8BMpb4j21FE5+ZZOVwlAREcJqerz/ZnlHFyNg3Y9pkP1Oa6psaVnI5LTjZ7e4abt9l+X1TX B6PgTkCCMTnCZ57OMi0oLcIoKqAwkTn5Vusk= X-Received: by 2002:a17:90b:2689:b0:38d:ddc2:7ccb with SMTP id 98e67ed59e1d1-39d9bbc81damr9099616a91.1.1789148643596; Fri, 11 Sep 2026 10:44:03 -0700 (PDT) X-Received: by 2002:a17:90b:2689:b0:38d:ddc2:7ccb with SMTP id 98e67ed59e1d1-39d9bbc81damr9099566a91.1.1789148643138; Fri, 11 Sep 2026 10:44:03 -0700 (PDT) Received: from [192.168.0.172] ([183.83.137.104]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-14365b78d59sm7652016c88.8.2026.09.11.10.43.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Sep 2026 10:44:02 -0700 (PDT) Message-ID: Date: Fri, 11 Sep 2026 23:13:53 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 01/13] dt-bindings: media: qcom,venus: Add context bank subnodes to common schema To: Krzysztof Kozlowski Cc: Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Stanimir Varbanov , Neil Armstrong , Dmitry Baryshkov , Bryan O'Donoghue , Stephan Gerhold , "Joerg Roedel (AMD)" , Will Deacon , Robin Murphy , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio , iommu@lists.linux.dev, Daniel J Blueman References: <20260909-vpu_iommu_iova_handling-v3-0-2fe43ae45495@oss.qualcomm.com> <20260909-vpu_iommu_iova_handling-v3-1-2fe43ae45495@oss.qualcomm.com> <20260910-careful-finch-of-fame-eeeac7@quoll> Content-Language: en-US From: Vikash Garodia In-Reply-To: <20260910-careful-finch-of-fame-eeeac7@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwOTExMDI0OCBTYWx0ZWRfX5WgPHHrL3/12 b9iZyG48YxZjhQYMJj38emA9Qw/RfYA2FjBBSq/BxhMOu3YP/7zr7frblva0QdGOThvoLMxDkc9 HdPO7MvLqwqzmB9fDlzaYMF0sjur/Is= X-Proofpoint-GUID: krS9DM0BaVDh7ESArlmoqgt0yZpERRmr X-Authority-Analysis: v=2.4 cv=N/C8hG9B c=1 sm=1 tr=0 ts=6aa43de4 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=TwCXObd+TJU0JWB7kQOUgw==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=e5mUnYsNAAAA:8 a=VwQbUJbxAAAA:8 a=NEAV23lmAAAA:8 a=t9ty7G3lAAAA:8 a=EUspDBNiAAAA:8 a=gweAf5VaqOsLJRT3hzwA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 a=Vxmtnl_E_bksehYqCbjh:22 a=CsAS6f0m0zARWR-uHzm3:22 X-Proofpoint-ORIG-GUID: krS9DM0BaVDh7ESArlmoqgt0yZpERRmr X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTExMDI0OCBTYWx0ZWRfX/qeA2P1aNM99 iSjTDnogBzg14azqoslHWa4ULBYFCj271ABwllhORiR8k3lS68X3hSNOxdeb3OS9Rt5QpaINrHj GMUlw2wNfPr++YZy2iZRK6KAlWTOuUV74tW0lTh0J1q0d3DD/GrQGJORhgJ7a781WlFo0hR9PV+ tp/6p5FVTewkop9+snnTyaPLvswXHj4y+slzfApOziSXOu6Sh2Lsi85Mv4SGpRs7sDRUcpsBT+0 QQhXKDoX3+ELbFGCAiI7wJEpG1DbNAUD35DP65uoHjsYHUfAoOsm6Ec3B2j+ukVIILdik824apG lu/x5Jfu7XQ9ICE5eUSW55tVCtpgAX/TmbJuX8RbXkiJqnkns0sSMTwtQOyYptbj4Q3PGvMnvn9 GhFGxSALNqJODTiljKDiTK2RvHig0HR658CzXWfWczGP5mqRZw/2cbFmJE5SLXtaI4l4plJHJMo bwHCYakr/Atlhopi+wA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-11_06,2026-09-11_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 clxscore=1015 bulkscore=0 adultscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609110248 On 9/10/2026 12:29 PM, Krzysztof Kozlowski wrote: > On Wed, Sep 09, 2026 at 08:27:08PM +0530, Vikash Garodia wrote: >> The VPU issues DMA through several SMMU streams, and the hardware does >> not give every stream the same addressable range. The non-pixel stream >> cannot address the low 600MB of IOVA space, while the pixel stream can >> address the full range: >> +-----------------------------------------------------------+ >> | non-pixel stream addressable range (600 MB - 3.5 GB) | >> | 0x25800000 - 0xe0000000 | >> +-----------------------------------------------------------+ >> | pixel stream addressable range (0 - 3.5 GB) | >> | 0x00000000 - 0xe0000000 | >> +-----------------------------------------------------------+ >> A single "iommus" property on the video-codec node puts every stream in >> one IOMMU domain sharing one IOVA allocator, so nothing restricts a >> non-pixel buffer to avoid 0 to 600MB. Once an allocation lands below >> that boundary the hardware faults, which shows up as unhandled SMMU page >> faults and spontaneous reboots: >> https://gitlab.freedesktop.org/drm/msm/-/work_items/100 >> >> Given that the address range restriction is for specific VPU stream, it >> should be ideally be moved to that stream. To achieve the same, a subset >> of streams is now represented as subnodes, so that each can be >> associated with its respective addressable range. The design was >> discussed and agreed by mainatiners here >> https://lore.kernel.org/all/c7b956a9-d3e8-4e18-b780-5d08f5cd2ca1@kernel.org >> >> In the past, this limitation was addressed with an iommu-map approach, >> with the iris driver dynamically creating the devices. That approach was >> later concluded to be a hack to avoid having subnodes, and was NAKed by >> the iommu maintainers. It was discussed in detail here: >> https://lore.kernel.org/all/c7b956a9-d3e8-4e18-b780-5d08f5cd2ca1@kernel.org/ >> >> "iommu-ranges" on the subnode describes the *allowed* IOVA range that >> stream is allowed to use, so the IOVA is allocated from the specified >> range only. Define all the possible subnodes so as to describe all the >> VPU hardware iommu interfaces, both secure as well as non secure. >> >> address-cells, size-cells and dma-ranges declares the 1:1 DMA >> translation into the parent. >> >> The parent "iommus" is kept as an alternative via "oneOf", so platforms >> that have not been converted to subnodes still validate. New platforms >> should use the subnode form. >> >> This patch depends-on: >> https://github.com/devicetree-org/dt-schema/pull/207 > > Please drop, not suitable for commit, keep it in the changelog > Sure, will add this to changelog. >> >> Tested-by: Daniel J Blueman > > Plese drop, not true here > ok, got picked in b4 trailers, will drop. > >> Signed-off-by: Vikash Garodia >> --- >> .../bindings/media/qcom,sc7180-venus.yaml | 15 ---- >> .../bindings/media/qcom,venus-common.yaml | 97 ++++++++++++++++++++++ >> 2 files changed, 97 insertions(+), 15 deletions(-) >> > > I see this causes DT checks failures but I don't see the report, so > probably it was because of schema dependency. > > Best regards, > Krzysztof