From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6304615AC2 for ; Thu, 11 Jan 2024 12:20:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iZwpg6ff" Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2cd8b661cb8so4233521fa.0 for ; Thu, 11 Jan 2024 04:20:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704975618; x=1705580418; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=F040GXsz7aRwgMvtBRucVujHPaJzjQl/6qLu2uyGLh8=; b=iZwpg6ffXiRObStYf9SKqBFE/RQd/cbaqWR97Ent+dmafKGZpbNfQU635M5VxXHpuT Eu0w7nM/Uh6IXBGr5bBrmb7V8Irc2iXnQjtKSIkw0+wf2heBzQanSeY1h3enPWxCTEO5 s/mxKYrcmINiMIwm5BkWBJ68VJOg8MK3vMb0UvZSvHQ/UCyqB6VEaJW02Q0ymHOnOwWl +UikUKDUzbiOyeiM4ZUl/qhmuhKpNIys2UjpVPuTxONUu1b6rgTYbUY05A4IKLCMaIdd ihNyGCS7MvrLf0+zKvufX6dlXV1DgfaGk47WhEtaPGO1PMCXqsR82ZHZUjLV4D7wKN4y iekA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704975618; x=1705580418; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=F040GXsz7aRwgMvtBRucVujHPaJzjQl/6qLu2uyGLh8=; b=OFlQAEGMTQ6sB7U1jj9n5ZycK3tTfeuTAi5qmsXPR0vlvxnXFE29UifevLfmnIdWkJ ShcyNvlFGvUxjWvveDiDdxzOudS961M8ZDXNkLp5+Oc+k87ac9H35yZbs8Gh8gSn64Wd SN3EvXeM4qLPDNp88sRfKpmCD3TlegKCnKbSBhO6bCRzpeergPtsF1GEm0Ubk7tDkY4y Wb49Tl7d8wgA6Fv370uMheIjsLKhfijaOxfMRtYk7O925LkrT2fVSlIdkNzpBSUeIpsJ CpnP2bLKJ7Rio5EiF4M5UaxeWoBsE+FsVYOWXx3x4IKPTz9NfzeNmm3Yvf/oXcmyjUww ZDZw== X-Gm-Message-State: AOJu0YyqjtCliQ8XwthxU792OPWefEfTokuWKzOqzE7k55JiDtkPlKmJ tB332kffCQeFxVssK/MgynDaAU9qmRKx/g== X-Google-Smtp-Source: AGHT+IHBrXffXq3Iy0z3sPhEatUN4tzY0PObMQGMO6VcrV3VZAerTte6eD3Ee5riS9A4t1J28qefIA== X-Received: by 2002:a2e:8896:0:b0:2cb:2c91:e174 with SMTP id k22-20020a2e8896000000b002cb2c91e174mr259502lji.27.1704975618626; Thu, 11 Jan 2024 04:20:18 -0800 (PST) Received: from [172.30.205.123] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id n25-20020a2e7219000000b002cc83210f65sm126181ljc.89.2024.01.11.04.20.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jan 2024 04:20:18 -0800 (PST) Message-ID: Date: Thu, 11 Jan 2024 13:20:17 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/4] arm64: dts: qcom: sc8280xp: camss: Add CCI definitions Content-Language: en-US To: Bryan O'Donoghue , Robert Foss , Todor Tomov , Bjorn Andersson , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240109-linux-next-24-01-02-sc8280xp-camss-core-dtsi-v3-0-b8e3a74a6e6a@linaro.org> <20240109-linux-next-24-01-02-sc8280xp-camss-core-dtsi-v3-3-b8e3a74a6e6a@linaro.org> <4f8aafa2-2145-4090-afba-8a26242d5ac3@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/11/24 12:46, Bryan O'Donoghue wrote: > On 10/01/2024 11:03, Konrad Dybcio wrote: >> >> >> On 1/9/24 17:06, Bryan O'Donoghue wrote: >>> sc8280xp has four Camera Control Interface (CCI) blocks which pinout to >>> two I2C master controllers for each CCI. >>> >>> The CCI I2C pins are not muxed so we define them in the dtsi. >>> >>> Signed-off-by: Bryan O'Donoghue >>> --- >>>   arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 307 +++++++++++++++++++++++++++++++++ >>>   1 file changed, 307 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi >>> index febf28356ff8..f48dfa5e5f36 100644 >>> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi >>> @@ -3451,6 +3451,169 @@ usb_1_role_switch: endpoint { >>>               }; >>>           }; >>> +        cci0: cci@ac4a000 { >>> +            compatible = "qcom,sc8280xp-cci", "qcom,msm8996-cci"; >>> +            reg = <0 0x0ac4a000 0 0x1000>; >>> + >>> +            interrupts = ; >>> + >>> +            clocks = <&camcc CAMCC_CAMNOC_AXI_CLK>, >>> +                 <&camcc CAMCC_SLOW_AHB_CLK_SRC>, >>> +                 <&camcc CAMCC_CPAS_AHB_CLK>, >>> +                 <&camcc CAMCC_CCI_0_CLK>; >>> +            clock-names = "camnoc_axi", >>> +                      "slow_ahb_src", >>> +                      "cpas_ahb", >>> +                      "cci"; >>> + >>> +            power-domains = <&camcc TITAN_TOP_GDSC>; >>> + >>> +            pinctrl-names = "default", "sleep"; >>> +            pinctrl-0 = <&cci0_default>; >>> +            pinctrl-1 = <&cci0_sleep>; >>> + >> property-names goes below property-n, just like with clocks 10 lines >> above :/ > > Didn't you ask for this to be re-ordered ? Sorry, I probably had the property ordering in mind.. that definitely came out as confusing. Konrad