From: Stephen Boyd <sboyd@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
patches@lists.linux.dev, kunit-dev@googlegroups.com,
linux-kselftest@vger.kernel.org, devicetree@vger.kernel.org,
Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <davidgow@google.com>, Rae Moar <rmoar@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rafael J . Wysocki <rafael@kernel.org>,
Saravana Kannan <saravanak@google.com>,
Daniel Latypov <dlatypov@google.com>,
Christian Marangi <ansuelsmth@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Maxime Ripard <maxime@cerno.tech>
Subject: Re: [PATCH v5 07/11] dt-bindings: test: Add single clk consumer
Date: Tue, 04 Jun 2024 11:28:16 -0700 [thread overview]
Message-ID: <cce5a85e48f35f5ad5464a2443ca972e.sboyd@kernel.org> (raw)
In-Reply-To: <20240604130526.GA12945-robh@kernel.org>
Quoting Rob Herring (2024-06-04 06:05:26)
> On Mon, Jun 03, 2024 at 03:38:04PM -0700, Stephen Boyd wrote:
> > Describe a binding for a device that consumes a single clk in DT. This
> > will initially be used by a KUnit test to clk_get() the clk registered
> > by of_fixed_clk_setup() and test that it is setup properly.
> >
> > Cc: Rob Herring <robh@kernel.org>
> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> > Cc: Conor Dooley <conor+dt@kernel.org>
> > Cc: Brendan Higgins <brendan.higgins@linux.dev>
> > Cc: David Gow <davidgow@google.com>
> > Cc: Rae Moar <rmoar@google.com>
> > Signed-off-by: Stephen Boyd <sboyd@kernel.org>
> > ---
> > .../test/test,single-clk-consumer.yaml | 34 +++++++++++++++++++
> > 1 file changed, 34 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/test/test,single-clk-consumer.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/test/test,single-clk-consumer.yaml b/Documentation/devicetree/bindings/test/test,single-clk-consumer.yaml
> > new file mode 100644
> > index 000000000000..8c384c48707d
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/test/test,single-clk-consumer.yaml
> > @@ -0,0 +1,34 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/test/test,single-clk-consumer.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Test consumer of a single clock
> > +
> > +maintainers:
> > + - Stephen Boyd <sboyd@kernel.org>
> > +
> > +description:
> > + A consumer of a single clock used in tests.
> > +
> > +properties:
> > + compatible:
> > + const: test,single-clk-consumer
>
> I don't know if there's much value in defining bindings for tests. We
> could alternatively make 'test,' opt out of everything. There's already
> some support in dtschema for this with 'foo,'.
>
> I need something for the DT unittest as well.
>
Ok. So I should drop this patch and the other one that adds a binding
for the fake clock provider? And replace it with something that makes
the test vendor prefix opt out of all checking? How is that done? Some
patch to dtschema directly?
next prev parent reply other threads:[~2024-06-04 18:28 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 22:37 [PATCH v5 00/11] clk: Add kunit tests for fixed rate and parent data Stephen Boyd
2024-06-03 22:37 ` [PATCH v5 01/11] of/platform: Allow overlays to create platform devices from the root node Stephen Boyd
2024-06-05 23:47 ` Rob Herring (Arm)
2024-06-03 22:37 ` [PATCH v5 02/11] of: Add test managed wrappers for of_overlay_apply()/of_node_put() Stephen Boyd
2024-06-13 7:48 ` David Gow
2024-07-02 22:39 ` Stephen Boyd
2024-06-03 22:38 ` [PATCH v5 03/11] dt-bindings: vendor-prefixes: Add "test" vendor for KUnit and friends Stephen Boyd
2024-06-03 22:38 ` [PATCH v5 04/11] dt-bindings: test: Add KUnit empty node binding Stephen Boyd
2024-06-03 22:38 ` [PATCH v5 05/11] of: Add a KUnit test for overlays and test managed APIs Stephen Boyd
2024-06-05 23:47 ` Rob Herring
2024-06-06 15:23 ` Stephen Boyd
2024-06-13 7:50 ` David Gow
2024-07-02 21:45 ` Stephen Boyd
2024-06-03 22:38 ` [PATCH v5 06/11] platform: Add test managed platform_device/driver APIs Stephen Boyd
2024-06-04 13:48 ` Greg Kroah-Hartman
2024-06-13 7:50 ` David Gow
2024-06-03 22:38 ` [PATCH v5 07/11] dt-bindings: test: Add single clk consumer Stephen Boyd
2024-06-04 12:50 ` Rob Herring (Arm)
2024-06-04 13:05 ` Rob Herring
2024-06-04 18:28 ` Stephen Boyd [this message]
2024-06-04 20:19 ` Rob Herring
2024-06-04 20:52 ` Stephen Boyd
2024-06-04 20:53 ` Stephen Boyd
2024-06-03 22:38 ` [PATCH v5 08/11] clk: Add test managed clk provider/consumer APIs Stephen Boyd
2024-06-03 22:38 ` [PATCH v5 09/11] clk: Add KUnit tests for clk fixed rate basic type Stephen Boyd
2024-06-03 22:38 ` [PATCH v5 10/11] dt-bindings: clk: Add clk_parent_data test Stephen Boyd
2024-06-03 22:38 ` [PATCH v5 11/11] clk: Add KUnit tests for clks registered with struct clk_parent_data Stephen Boyd
2024-06-13 7:56 ` David Gow
2024-07-02 22:25 ` Stephen Boyd
2024-07-02 22:34 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cce5a85e48f35f5ad5464a2443ca972e.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=brendan.higgins@linux.dev \
--cc=conor+dt@kernel.org \
--cc=davidgow@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dlatypov@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=mturquette@baylibre.com \
--cc=patches@lists.linux.dev \
--cc=rafael@kernel.org \
--cc=rmoar@google.com \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).