devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ezequiel Garcia <ezequiel@collabora.com>
To: Rob Herring <robh@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>,
	linux-rockchip@lists.infradead.org, kernel@collabora.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/2] arm64: dts: rockchip: add 96boards RK3399 Ficus board
Date: Fri, 06 Jul 2018 10:46:55 -0300	[thread overview]
Message-ID: <cceccdfefbcf9a5dcc5d683e7c7d4a2d16949344.camel@collabora.com> (raw)
In-Reply-To: <20180705234124.GA32051@rob-hp-laptop>

On Thu, 2018-07-05 at 17:41 -0600, Rob Herring wrote:
> On Thu, Jul 05, 2018 at 12:08:18PM -0300, Ezequiel Garcia wrote:
> > The RK3399 Ficus board is an Enterprise Edition board
> > manufactured by Vamrs Ltd., based on the Rockchip RK3399 SoC.
> > 
> > The board exposes a bunch of nice peripherals, including
> > SATA, HDMI, MIPI CSI, Ethernet, WiFi, and PCIe.
> > 
> > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> > 
[snip]
> > +
> > +&i2c0 {
> > +	clock-frequency = <400000>;
> > +	i2c-scl-rising-time-ns = <168>;
> > +	i2c-scl-falling-time-ns = <4>;
> > +	status = "okay";
> > +
> > +	vdd_cpu_b: syr827@40 {
> 
> regulator@40
> 

OK.

> > +		compatible = "silergy,syr827";
> > +		reg = <0x40>;
> > +		fcs,suspend-voltage-selector = <1>;
> 
> Strange to have a different vendor for this property...
> 

It's because this driver has also a Fairchild compatible
"fcs,fan53555".

> Otherwise,
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
> 

Thanks Rob!

  reply	other threads:[~2018-07-06 13:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-05 15:08 [PATCH v3 0/2] arm64: rockchip: support RK3399 Ficus board Ezequiel Garcia
2018-07-05 15:08 ` [PATCH v3 1/2] dt-bindings: Add vendor prefix for Vamrs Ltd Ezequiel Garcia
     [not found]   ` <20180705150818.29931-2-ezequiel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2018-07-05 23:38     ` Rob Herring
2018-07-05 15:08 ` [PATCH v3 2/2] arm64: dts: rockchip: add 96boards RK3399 Ficus board Ezequiel Garcia
     [not found]   ` <20180705150818.29931-3-ezequiel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2018-07-05 23:41     ` Rob Herring
2018-07-06 13:46       ` Ezequiel Garcia [this message]
     [not found]         ` <cceccdfefbcf9a5dcc5d683e7c7d4a2d16949344.camel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2018-07-06 13:49           ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cceccdfefbcf9a5dcc5d683e7c7d4a2d16949344.camel@collabora.com \
    --to=ezequiel@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=kernel@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).