From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m1973177.qiye.163.com (mail-m1973177.qiye.163.com [220.197.31.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 361493BED20; Tue, 31 Mar 2026 07:21:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.77 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774941717; cv=none; b=OcyKnuX3Mmro6bNrKc/OQsVjLagqM2J2emAdfa4mG8kA21bKTng6PfluS3OZe6Govmyzgs5/nr2s4DUuuR3oObQSwZ+sL74G9i6bb+RaJoFKXCX3dwibkDI2OXKXxEs3RhCBoI8YnYtj3ot0AS9QOC8+rO8BnAzIvml+hInQLS4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774941717; c=relaxed/simple; bh=Hw/xSGmvS/W12EYdELVtpL3OYl6cdTAtVH3nWGAaov0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TEr/M8B8hF8/0uNHE2w9YZNmufwWMOOPqEvOvjGFprSMHQmo3aLtfX8o8nMZi2XiThn4KLmgam3+F7XGlvgZnkx0JH/lxL/5eL7Q9EYcB/f72ECKozh0phOrOsQbzTqbNv4eowIb0+frDijkxFwXkEWVnJexpYvYTNQmEfEltdw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=Wq+zkPVq; arc=none smtp.client-ip=220.197.31.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="Wq+zkPVq" Received: from [172.16.12.43] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 38f44f87c; Tue, 31 Mar 2026 15:21:40 +0800 (GMT+08:00) Message-ID: Date: Tue, 31 Mar 2026 15:21:40 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 05/10] drm/bridge: dw-hdmi: document the output_port field To: Luca Ceresoli , Marek Vasut , Stefan Agner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Liu Ying , Rob Herring , Saravana Kannan Cc: "Kory Maincent (TI.com)" , =?UTF-8?Q?Herv=C3=A9_Codina?= , Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Adam Ford , Alexander Stein , Christopher Obbard , Daniel Scally , Emanuele Ghidoli , Fabio Estevam , Francesco Dolcini , Frieder Schrempf , Gilles Talis , =?UTF-8?B?R29yYW4gUmHEkWVub3ZpxIc=?= , Heiko Schocher , Josua Mayer , Kieran Bingham , Marco Felsch , Martyn Welch , Oleksij Rempel , Peng Fan , Richard Hu , Shengjiu Wang , Stefan Eichenberger , Vitor Soares References: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> <20260330-drm-lcdif-dbanc-v2-5-c7f2af536a24@bootlin.com> Content-Language: en-US From: Damon Ding In-Reply-To: <20260330-drm-lcdif-dbanc-v2-5-c7f2af536a24@bootlin.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Tid: 0a9d42c5018903a3kunmb80bde77a6a68b X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZQkIaTFZNSBoeHx0ZHk1CHRlWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSUJNS0 pVSktLVUtZBg++ DKIM-Signature: a=rsa-sha256; b=Wq+zkPVqz0CdKaCFf0pylSBIqhzr/OXJbXrZAlKgrb9mgepGLiCkxGWVe96a79ogsekMRYocXMZC5t7aV3+NWdqYlLNohinkrr7vg/PxINSu/mrTIAx7y+T1bc4q5/ZO7tbjwksOzwUrTWF9zCHcyxFrFcR8S5xLKPobhhszRcM=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=SwmQCXi9nqzIPuQ5P/EGbSWKKFcCaoib/M5YTzSviFY=; h=date:mime-version:subject:message-id:from; On 3/31/2026 3:25 AM, Luca Ceresoli wrote: > The meaning of this flag may not be obvious at first sight. > > Reviewed-by: Liu Ying > Tested-by: Martyn Welch > Tested-by: Alexander Stein # TQMa8MPxL/MBa8MPxL > Signed-off-by: Luca Ceresoli > > --- > > Changes in v2: > - improved comment as suggested by Liu > --- > include/drm/bridge/dw_hdmi.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/drm/bridge/dw_hdmi.h b/include/drm/bridge/dw_hdmi.h > index 336f062e1f9d..8500dd4f99d8 100644 > --- a/include/drm/bridge/dw_hdmi.h > +++ b/include/drm/bridge/dw_hdmi.h > @@ -126,6 +126,12 @@ struct dw_hdmi_phy_ops { > struct dw_hdmi_plat_data { > struct regmap *regm; > > + /* > + * The HDMI output port number must be 1 if the port is described > + * in the device tree. 0 if the device tree does not describe the > + * next component (legacy mode, i.e. without > + * DRM_BRIDGE_ATTACH_NO_CONNECTOR flag when attaching bridge). > + */ > unsigned int output_port; > > unsigned long input_bus_encoding; > Tested-by: Damon Ding (on rk3399) Best regards, Damon