From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E5FAC0015E for ; Thu, 13 Jul 2023 19:30:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229788AbjGMTaW (ORCPT ); Thu, 13 Jul 2023 15:30:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229953AbjGMTaW (ORCPT ); Thu, 13 Jul 2023 15:30:22 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FAAD1989; Thu, 13 Jul 2023 12:30:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=9OIrt/LgsHugPSDybSGY5Tydet8PUGjuftpAsOzUygI=; b=SF2KSfyiyKBIjg1pTzJBc8Wq8R P0fq1t2LK8VL3lH2LxoUt/4IIMfRRoEvMerYDo8Bc3m7Yk4nwboPghuHQYY0XZZi7E4qYVJwJIwkN to7BbbeeDX8S+G9GyRY0CZrCZFmwgeoWWkN11DI7OmFVC/sHsK39eOwIC2pDDC8uNoLc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qK20q-001Hfz-32; Thu, 13 Jul 2023 21:30:04 +0200 Date: Thu, 13 Jul 2023 21:30:04 +0200 From: Andrew Lunn To: Krzysztof Kozlowski Cc: Pranavi Somisetty , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, michal.simek@amd.com, harini.katakam@amd.com, git@amd.com, radhey.shyam.pandey@amd.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] dt-bindings: net: xilinx_gmii2rgmii: Convert to json schema Message-ID: References: <20230713103453.24018-1-pranavi.somisetty@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jul 13, 2023 at 08:53:34PM +0200, Krzysztof Kozlowski wrote: > On 13/07/2023 17:59, Andrew Lunn wrote: > >>> +examples: > >>> + - | > >>> + mdio { > >>> + #address-cells = <1>; > >>> + #size-cells = <0>; > >>> + phy: ethernet-phy@0 { > >>> + reg = <0>; > >>> + }; > >> > >> Drop this node, quite obvious. > > > > Dumb question. Isn't it needed since it is referenced by phy-handle = > > <&phy> below. Without it, the fragment is not valid DT and so the > > checking tools will fail? > > No, because the example is compiled with silencing missing phandles. Ah, thanks. This is a rather odd device, there is no other like it in mainline, so i think having that PHY is useful, even if you think it is obvious what is going on here. Andrew