From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77E20C433F5 for ; Tue, 3 May 2022 15:54:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236407AbiECP6M (ORCPT ); Tue, 3 May 2022 11:58:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233721AbiECP6L (ORCPT ); Tue, 3 May 2022 11:58:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 499C63BFA2; Tue, 3 May 2022 08:54:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D8BB1616A9; Tue, 3 May 2022 15:54:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 640C0C385A9; Tue, 3 May 2022 15:54:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651593278; bh=ttsYKdHya8NFXXbpmd6fMc2IdK8j16P+tIaA6ZRYEJU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=YKZhP6/cj6nXuDCQplf5MJzZX47V3EfzWI1JWpqVcz/TlzZRqtuSzHI3PZLDTRGkR bjYJNLzIDHlznEONfhTSsbs+toXqgkD0IbOB4HzqM4pd1bmbPYT8CG9bslmNC/Y0Gu v+HbfvzzZanrlzM/OXZcf8bNhySw6gmKvqDG4+VRcftXJLwufqtMPW0j6KQFdnL16/ grfIs+NTsBa5HQX/6eIyBd/Em4snBZq+KXnN0H8xobMuIl4+o6cAyePSyVkf1+nhGA 17xrEUG5Xx68FDlvB9K+x7F+SbSjUSc8SFcIO+yDpJPZrLdEtYhMEkzAGKUDX1Tr9r yTLbuHSTg0iWw== Message-ID: Date: Tue, 3 May 2022 17:54:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v3 1/2] dt-bindings: google,cros-ec-keyb: Introduce switches only compatible Content-Language: en-US To: Doug Anderson , Krzysztof Kozlowski Cc: Stephen Boyd , Dmitry Torokhov , LKML , patches@lists.linux.dev, chrome-platform@lists.linux.dev, Krzysztof Kozlowski , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Benson Leung , Guenter Roeck , Hsin-Yi Wang , "Joseph S. Barrera III" References: <20220503042242.3597561-1-swboyd@chromium.org> <20220503042242.3597561-2-swboyd@chromium.org> <2280875f-fbd8-0dfd-5a0a-1d7fceb856e4@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/05/2022 17:46, Doug Anderson wrote: > Hi, > > On Tue, May 3, 2022 at 8:42 AM Krzysztof Kozlowski > wrote: >> >> On 03/05/2022 06:22, Stephen Boyd wrote: >>> If the ChromeOS board is a detachable, this cros-ec-keyb device won't >>> have a matrix keyboard but it may have some button switches, e.g. volume >>> buttons and power buttons. The driver still registers a keyboard though >>> and that leads to userspace confusion around where the keyboard is. >> >> (...) >> >>> >>> +if: >>> + properties: >>> + compatible: >>> + contains: >>> + const: google,cros-ec-keyb >>> +then: >>> + allOf: >>> + - $ref: "/schemas/input/matrix-keymap.yaml#" >>> + required: >>> + - keypad,num-rows >>> + - keypad,num-columns >>> + - linux,keymap >> >> else: >> properties: >> function-row-phsymap: false >> google,needs-ghost-filter: false >> >> Because these are not valid for the non-matrix-keyboard case, right? > > Isn't that implicit because this file has `unevaluatedProperties: false` ? But they are evaluated here, aren't they? Best regards, Krzysztof