Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>,
	Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Cc: Srinivas Kandagatla <srini@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 6/9] ASoC: dt-bindings: qcom: Add Hawi LPASS macro codecs
Date: Fri, 16 Oct 2026 15:51:20 +0200	[thread overview]
Message-ID: <cd256380-fdfd-4359-8611-0901045f66df@kernel.org> (raw)
In-Reply-To: <9a12fc9c-e766-45d3-a6f8-eb6ff3332434@oss.qualcomm.com>

On 16/10/2026 10:14, Prasad Kumpatla wrote:
> 
> On 10/15/2026 3:08 PM, Krzysztof Kozlowski wrote:
>> Are you sure you are not using source clock names?
> 
> On Hawi this RX input is sourced from the LPR vote (LPASS_HW_LPR_VOTE)

That the source clock name. Look, where LPASS_HW_LPR_VOTE is used:

> instead of the MACRO vote used on sm8550:
> 
>      clocks = <&q6prmcc LPASS_CLK_ID_RX_CORE_TX_MCLK ...>,
>               <&q6prmcc*LPASS_HW_LPR_VOTE* ...>,

Here.  LPASS_HW_LPR_VOTE is the name in q6prmcc.

>               <&q6prmcc LPASS_HW_DCODEC_VOTE ...>,
>               <&lpass_vamacro>;
>      clock-names = "mclk",*"lpr"*, "dcodec", "fsgen";
> 
> "lpr" is the same style of name as the existing "macro"/"dcodec" entries,

That's the same vote as here, no? Vote for main block (macro)?

> not a parent/source name. An sm8550 fallback can't be used here because it
> pins input #2 to "macro", which no longer matches the LPR source on Hawi;
> the other three inputs are unchanged, so RX gets its own clock-names.
> 
> Thanks,
> Prasad
> 


Best regards,
Krzysztof

  reply	other threads:[~2026-10-16 13:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-14  9:12 [PATCH v5 0/9] ASoC: qcom: Add shikra and Hawi LPASS macro support Mohammad Rafi Shaik
2026-10-14  9:12 ` [PATCH v5 1/9] ASoC: dt-bindings: qcom: Add Shikra RX and VA macro codecs Mohammad Rafi Shaik
2026-10-14  9:12 ` [PATCH v5 2/9] ASoC: qcom: lpass-macro-common: Add missing v2.9 version string Mohammad Rafi Shaik
2026-10-14  9:12 ` [PATCH v5 3/9] ASoC: qcom: lpass-rx-macro: Add shikra compatible Mohammad Rafi Shaik
2026-10-14  9:28   ` sashiko-bot
2026-10-14  9:12 ` [PATCH v5 4/9] ASoC: qcom: lpass-va-macro: " Mohammad Rafi Shaik
2026-10-14  9:12 ` [PATCH v5 5/9] ASoC: qcom: lpass-va-macro: Add SoundWire microphone support Mohammad Rafi Shaik
2026-10-14  9:30   ` sashiko-bot
2026-10-14  9:12 ` [PATCH v5 6/9] ASoC: dt-bindings: qcom: Add Hawi LPASS macro codecs Mohammad Rafi Shaik
2026-10-14  9:35   ` sashiko-bot
2026-10-15  9:38   ` Krzysztof Kozlowski
2026-10-16  8:14     ` Prasad Kumpatla
2026-10-16 13:51       ` Krzysztof Kozlowski [this message]
2026-10-14  9:12 ` [PATCH v5 7/9] ASoC: dt-bindings: qcom: Add Maili " Mohammad Rafi Shaik
2026-10-14  9:12 ` [PATCH v5 8/9] ASoC: qcom: lpass-tx-macro: Add support for Bolero v4.0 Mohammad Rafi Shaik
2026-10-14  9:35   ` sashiko-bot
2026-10-14  9:12 ` [PATCH v5 9/9] ASoC: qcom: lpass: Add support for LPASS codec v4.0 Mohammad Rafi Shaik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cd256380-fdfd-4359-8611-0901045f66df@kernel.org \
    --to=krzk@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=mohammad.rafi.shaik@oss.qualcomm.com \
    --cc=perex@perex.cz \
    --cc=prasad.kumpatla@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=srini@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox