From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E7A0ECAAD5 for ; Mon, 12 Sep 2022 10:55:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229867AbiILKz0 (ORCPT ); Mon, 12 Sep 2022 06:55:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229511AbiILKzZ (ORCPT ); Mon, 12 Sep 2022 06:55:25 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 055F4167F0 for ; Mon, 12 Sep 2022 03:55:24 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id x10so10058778ljq.4 for ; Mon, 12 Sep 2022 03:55:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=uODYllNYs6vH+/kP4ToqCRWAa9suYiwygYLIovAsVnU=; b=g5fbjdZa+uRqiNsPW0QD54nGvN7X5aBbFAzzt0v+0YiKM55+91yR7pR/x/1kFFkQFa PDWGSbEg3Hot7+eat0TLFcdROvwOW+1/mXiy8dFW66v1Yfs/O2y2K2kwkSzPLZa+v+CL tbOCLnGjXC9j7Eiy+HSp7flLu5Efsj19mYkdWiGfFLW7npPqOtK3Hf00X84ZPZfXdQ40 HWI+QwpAqjra5/lqiZrtlwzDRvHrT1bbE5QnQsSnnuBYwEROC2mZXilwtTGqHLS3PBuL LuYNy2zrrUDmQNecRjfxlA1JgSEiNErKvDJs17T6D5Vqs562DgVOLs+kqp0BrUQh4iEU mt3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=uODYllNYs6vH+/kP4ToqCRWAa9suYiwygYLIovAsVnU=; b=yXElSF/noRdrqoqK/LXvxt23R2B2OMixkoc+sZoz1Uk6ngcgmUC9R5VvgNuNY4EUVN 6Po5PJfg3EGoDabijrPhAXUhTcXpvZkch8cE1dGv/NO+xOp7iNChqt0YrGXVx5oa0EN4 QbgsEshFKFlaB2r7hXaZMyaZIlNwdGaNHIVvF+VJQbxd40NKdTtr0ZeGDNUt7jJjwEqf 5q4jXveLHtHpMO7ytbIGdJeJGsFjkWuLqlEw7hAxlq5/TKbPlwtLA0ofz4GwW6QD4CW5 k0qaT42J9/6ZpRlWBp1V7qpeAMUhTPpvWWo6er7X2JK/WC3vMfdrvDx4Z4L18vnM2jfg XPJA== X-Gm-Message-State: ACgBeo2B2CCz3vdijQUDaQ28IZvYc7C7G4c1Op74ePsnMBsA09rJV5Qu 2E7YKi9YzYymcQpQgCGsXEX3xQ== X-Google-Smtp-Source: AA6agR7lep5ZcMDwaWlJ4ySJTisrqo0Rgf7jMEe3bPC10uTlj7rtt8SS/ZwEojVJGCAYkw9+IAP/Dg== X-Received: by 2002:a2e:9cda:0:b0:26b:e930:6f7d with SMTP id g26-20020a2e9cda000000b0026be9306f7dmr4201796ljj.436.1662980122396; Mon, 12 Sep 2022 03:55:22 -0700 (PDT) Received: from [10.129.96.84] ([109.232.243.34]) by smtp.gmail.com with ESMTPSA id f17-20020a056512229100b00498fc3d4d15sm996417lfu.190.2022.09.12.03.55.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Sep 2022 03:55:21 -0700 (PDT) Message-ID: Date: Mon, 12 Sep 2022 12:55:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v2 1/2] media: dt-bindings: media: i2c: document OV4689 DT bindings Content-Language: en-US To: Mikhail Rudenko , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Sakari Ailus , Hans Verkuil , Jacopo Mondi , Shawn Tu , Christian Hemp , Arec Kao , Arnd Bergmann , Laurent Pinchart , Daniel Scally , Jimmy Su Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220911200147.375198-1-mike.rudenko@gmail.com> <20220911200147.375198-2-mike.rudenko@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220911200147.375198-2-mike.rudenko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/09/2022 22:01, Mikhail Rudenko wrote: > Add device-tree binding documentation for OV4689 image sensor driver, > and the relevant MAINTAINERS entries. > > Signed-off-by: Mikhail Rudenko Too many "media" prefixes in the subject. Also you duplicated dt bindings as prefix and commit msg (skip the latter). > --- > .../bindings/media/i2c/ovti,ov4689.yaml | 141 ++++++++++++++++++ > MAINTAINERS | 7 + > 2 files changed, 148 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov4689.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov4689.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov4689.yaml > new file mode 100644 > index 000000000000..376330b5572a > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov4689.yaml > @@ -0,0 +1,141 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/ovti,ov4689.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Omnivision OV4689 CMOS > + > +maintainers: > + - Mikhail Rudenko > + > +description: | > + The Omnivision OV4689 is a high performance, 1/3-inch, 4 megapixel > + image sensor. Ihis chip supports high frame rate speeds up to 90 fps > + at 2688x1520 resolution. It is programmable through an I2C > + interface, and sensor output is sent via 1/2/4 lane MIPI CSI-2 > + connection. > + > +allOf: > + - $ref: /schemas/media/video-interface-devices.yaml# > + > +properties: > + compatible: > + const: ovti,ov4689 > + > + reg: > + maxItems: 1 > + > + clocks: > + description: > + External clock (XVCLK) for the sensor, 6-64 MHz > + maxItems: 1 > + > + clock-names: true This has to be strictly defined - which name you expect. > + > + dovdd-supply: > + description: > + Digital I/O voltage supply, 1.7-3.0 V > + > + avdd-supply: > + description: > + Analog voltage supply, 2.6-3.0 V > + > + dvdd-supply: > + description: > + Digital core voltage supply, 1.1-1.3 V > + > + powerdown-gpios: > + maxItems: 1 You can skip here maxItems - it is defined by gpio-consumer-common. > + description: > + GPIO connected to the powerdown pin (active low) > + > + reset-gpios: > + maxItems: 1 > + description: > + GPIO connected to the reset pin (active low) > + Best regards, Krzysztof