From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Conor Dooley <conor@kernel.org>, Jai Luthra <j-luthra@ti.com>,
Andrew Davis <afd@ti.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: clock: Add binding documentation for TI Audio REFCLK
Date: Thu, 18 May 2023 16:09:01 +0200 [thread overview]
Message-ID: <cd38d95f-95bd-056e-e3d0-d6c95e3fd80e@linaro.org> (raw)
In-Reply-To: <20230517-reprise-unroll-e2223cab3846@spud>
On 17/05/2023 19:15, Conor Dooley wrote:
> On Wed, May 17, 2023 at 01:04:05PM +0530, Jai Luthra wrote:
>> Add DT bindings for TI's audio reference clocks (REFCLK) present on AM62
>> SoC.
>
> This seems fine to me. Perhaps Krzysztof will differ...
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>
>>
>> Signed-off-by: Jai Luthra <j-luthra@ti.com>
>> ---
>> .../bindings/clock/ti,am62-audio-refclk.yaml | 44 ++++++++++++++++++++++
>> 1 file changed, 44 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/ti,am62-audio-refclk.yaml b/Documentation/devicetree/bindings/clock/ti,am62-audio-refclk.yaml
>> new file mode 100644
>> index 000000000000..7c4cf7abe007
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/ti,am62-audio-refclk.yaml
>> @@ -0,0 +1,44 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/clock/ti,am62-audio-refclk.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: TI Audio Reference Clock
>> +
>> +maintainers:
>> + - Jai Luthra <j-luthra@ti.com>
>> +
>> +properties:
>> + compatible:
>> + items:
>> + - const: ti,am62-audio-refclk
>> + - const: syscon
I just don't get why this is syscon? There are no references to it, no
DTS change and nothing in the driver suggesting it has to be syscon
(creating regmap for internal use does not count).
Andrew,
Is this the pattern we discussed and wanted to remove?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-18 14:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 7:34 [PATCH 0/2] clk: keystone: syscon-clk: Enable audio reference clock Jai Luthra
2023-05-17 7:34 ` [PATCH 1/2] dt-bindings: clock: Add binding documentation for TI Audio REFCLK Jai Luthra
2023-05-17 17:15 ` Conor Dooley
2023-05-18 14:09 ` Krzysztof Kozlowski [this message]
2023-05-19 10:44 ` Jai Luthra
2023-05-17 7:34 ` [PATCH 2/2] clk: keystone: syscon-clk: Add support for audio refclk Jai Luthra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd38d95f-95bd-056e-e3d0-d6c95e3fd80e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=afd@ti.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j-luthra@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=ssantosh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).