From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF4BAC001B0 for ; Tue, 8 Aug 2023 19:42:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232655AbjHHTma (ORCPT ); Tue, 8 Aug 2023 15:42:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236765AbjHHTmK (ORCPT ); Tue, 8 Aug 2023 15:42:10 -0400 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A92C32AA6; Tue, 8 Aug 2023 12:12:24 -0700 (PDT) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 378B0dhD122283; Tue, 8 Aug 2023 06:00:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1691492439; bh=npvcQIk61iVMP4E04sdL7772lgYee0B0l8JQa9TMkAg=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=MEVYmDqvMP2ZABP2XQ7v6sJfRc3cFb4cd5F0KbyRB2tKHz4nsX2kt0ZF3/Xa9NHnR k1iXT4+TyEW8Dl8fOr7Yg6+tBR1F1JWdXw8/Cc6lYqB4wNU+dE6O5CwUen/SzmruGx rNiOG0q2hvBQCBvOjO4/WQ3as+M0xbT/leXoVHAQ= Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 378B0d1v027222 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 8 Aug 2023 06:00:39 -0500 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 8 Aug 2023 06:00:38 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 8 Aug 2023 06:00:38 -0500 Received: from [172.24.227.217] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 378B0XC9005497; Tue, 8 Aug 2023 06:00:34 -0500 Message-ID: Date: Tue, 8 Aug 2023 16:30:32 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] dt-bindings: remoteproc: pru: Add Interrupt property Content-Language: en-US To: Conor Dooley CC: MD Danish Anwar , Suman Anna , Conor Dooley , Krzysztof Kozlowski , Rob Herring , Mathieu Poirier , Bjorn Andersson , , , , , , , , References: <20230807110836.2612730-1-danishanwar@ti.com> <20230807-euphemism-trailing-ef4130dc7437@spud> <910a4a98-712a-5517-5a5b-ffb962f83463@ti.com> <20230808-unwomanly-generic-67d20f0e51cd@spud> From: Md Danish Anwar Organization: Texas Instruments In-Reply-To: <20230808-unwomanly-generic-67d20f0e51cd@spud> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/08/23 4:18 pm, Conor Dooley wrote: > On Tue, Aug 08, 2023 at 03:14:31PM +0530, Md Danish Anwar wrote: >> Hi Conor, >> >> On 07/08/23 8:09 pm, Conor Dooley wrote: >>> On Mon, Aug 07, 2023 at 04:38:36PM +0530, MD Danish Anwar wrote: >>>> Add interrupts and interrupt-names protperties for PRU and RTU cores. >>>> >>>> Signed-off-by: MD Danish Anwar >>>> --- >>>> .../bindings/remoteproc/ti,pru-rproc.yaml | 22 +++++++++++++++++++ >>>> 1 file changed, 22 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml >>>> index cd55d80137f7..6970316943bb 100644 >>>> --- a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml >>>> +++ b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml >>>> @@ -66,6 +66,16 @@ properties: >>>> Should contain the name of the default firmware image >>>> file located on the firmware search path. >>>> >>>> + interrupts: >>>> + maxItems: 1 >>>> + description: >>>> + Interrupt specifiers enable the virtio/rpmsg communication between MPU >>>> + and the PRU/RTU cores. >>>> + >>>> + interrupt-names: >>>> + items: >>>> + - const: vring >>>> + >>>> if: >>>> properties: >>>> compatible: >>>> @@ -171,6 +181,9 @@ examples: >>>> <0x22400 0x100>; >>>> reg-names = "iram", "control", "debug"; >>>> firmware-name = "am65x-pru0_0-fw"; >>>> + interrupt-parent = <&icssg0_intc>; >>>> + interrupts = <16 2 2>; >>>> + interrupt-names = "vring"; >>>> }; >>> >>> These examples would probably be more helpful if they used the >>> appropriate defines, no? >>> >> >> PRUSS Interrupt controller doesn't have any appropriate defines. This doesn't >> use GIC so defines from arm-gic.h can not be used here. These are specific to >> PRUSS INTC. > > I was deliberately vague in case the gic stuff applied too, but my main > question was about the standard defines used for interrupt types. > There are no standard defines for these interrupt types. However I can create a new .h file defining all the three interrupt cells and their values for both PRU and RTU cores if you think that is required. Otherwise we can go with hardcoded values. Please let me know what you think should be done here. >> I think these example are OK. Please let me know if this is OK to you. -- Thanks and Regards, Danish.