From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jeffrey Hugo <quic_jhugo@quicinc.com>,
Taniya Das <tdas@codeaurora.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/9] clk: qcom: gcc-msm8998: Don't check halt bit on some branch clks
Date: Thu, 22 Jun 2023 13:59:09 +0200 [thread overview]
Message-ID: <cd7564a3-8cd8-4535-07ee-60c1d2b0e321@linaro.org> (raw)
In-Reply-To: <20230622-topic-8998clk-v1-6-5b7a0d6e98b1@linaro.org>
On 22.06.2023 13:57, Konrad Dybcio wrote:
> Some branch clocks are governed externally and we're only supposed to
> send a request concerning their shutdown, not actually ensure it happens.
>
> Use the BRANCH_HALT_SKIP define to skip checking the halt bit.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
Whoops. Again, right after hitting send, I noticed this one was already
sent with
https://lore.kernel.org/linux-arm-msm/20230531-topic-8998_mmssclk-v1-0-2b5a8fc90991@linaro.org/
> drivers/clk/qcom/gcc-msm8998.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clk/qcom/gcc-msm8998.c b/drivers/clk/qcom/gcc-msm8998.c
> index cccb19cae481..ef410f52f09f 100644
> --- a/drivers/clk/qcom/gcc-msm8998.c
> +++ b/drivers/clk/qcom/gcc-msm8998.c
> @@ -2112,7 +2112,7 @@ static struct clk_branch gcc_gp3_clk = {
>
> static struct clk_branch gcc_bimc_gfx_clk = {
> .halt_reg = 0x46040,
> - .halt_check = BRANCH_HALT,
> + .halt_check = BRANCH_HALT_SKIP,
> .clkr = {
> .enable_reg = 0x46040,
> .enable_mask = BIT(0),
> @@ -2125,7 +2125,7 @@ static struct clk_branch gcc_bimc_gfx_clk = {
>
> static struct clk_branch gcc_gpu_bimc_gfx_clk = {
> .halt_reg = 0x71010,
> - .halt_check = BRANCH_HALT,
> + .halt_check = BRANCH_HALT_SKIP,
> .clkr = {
> .enable_reg = 0x71010,
> .enable_mask = BIT(0),
> @@ -2151,7 +2151,7 @@ static struct clk_branch gcc_gpu_bimc_gfx_src_clk = {
>
> static struct clk_branch gcc_gpu_cfg_ahb_clk = {
> .halt_reg = 0x71004,
> - .halt_check = BRANCH_HALT,
> + .halt_check = BRANCH_HALT_SKIP,
> .clkr = {
> .enable_reg = 0x71004,
> .enable_mask = BIT(0),
>
next prev parent reply other threads:[~2023-06-22 11:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 11:57 [PATCH 0/9] MSM8998 clk cleanups and fixups Konrad Dybcio
2023-06-22 11:57 ` [PATCH 1/9] dt-bindings: clk: qcom,gcc-msm8998: Add missing GPU/MMSS GPLL0 legs Konrad Dybcio
2023-06-22 14:41 ` Jeffrey Hugo
2023-06-23 16:40 ` Krzysztof Kozlowski
2023-06-22 11:57 ` [PATCH 2/9] dt-bindings: clock: qcom,mmcc: Add GPLL0_DIV for MSM8998 Konrad Dybcio
2023-06-22 14:47 ` Jeffrey Hugo
2023-06-22 14:54 ` Rob Herring
2023-06-23 16:40 ` Krzysztof Kozlowski
2023-06-22 11:57 ` [PATCH 3/9] clk: qcom: gcc-msm8998: Control MMSS and GPUSS GPLL0 outputs properly Konrad Dybcio
2023-06-22 14:55 ` Jeffrey Hugo
2023-06-22 15:05 ` Konrad Dybcio
2023-06-22 15:19 ` Jeffrey Hugo
2023-06-26 15:46 ` Jeffrey Hugo
2023-06-22 11:57 ` [PATCH 4/9] clk: qcom: mmcc-msm8998: Properly consume GPLL0 inputs Konrad Dybcio
2023-06-22 15:03 ` Jeffrey Hugo
2023-06-22 11:57 ` [PATCH 5/9] clk: qcom: gpucc-msm8998: Use the correct GPLL0 leg with old DTs Konrad Dybcio
2023-06-22 15:03 ` Jeffrey Hugo
2023-06-22 11:57 ` [PATCH 6/9] clk: qcom: gcc-msm8998: Don't check halt bit on some branch clks Konrad Dybcio
2023-06-22 11:59 ` Konrad Dybcio [this message]
2023-06-22 15:04 ` Jeffrey Hugo
2023-06-22 11:57 ` [PATCH 7/9] clk: qcom: gcc-msm8998: Don't poke at some BIMC GPU clocks Konrad Dybcio
2023-06-23 14:25 ` Jeffrey Hugo
2023-06-22 11:57 ` [PATCH 8/9] arm64: dts: qcom: msm8998: Use the correct GPLL0 leg for GPUCC Konrad Dybcio
2023-06-23 14:26 ` Jeffrey Hugo
2023-06-22 11:57 ` [PATCH 9/9] arm64: dts: qcom: msm8998: Use the correct GPLL0_DIV leg for MMCC Konrad Dybcio
2023-06-23 14:27 ` Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd7564a3-8cd8-4535-07ee-60c1d2b0e321@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mturquette@baylibre.com \
--cc=quic_jhugo@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).