From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Abel Vesa <abel.vesa@linaro.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Avri Altman <avri.altman@wdc.com>,
	Bart Van Assche <bvanassche@acm.org>,
	Luca Weiss <luca.weiss@fairphone.com>
Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
	devicetree@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] scsi: dt-bindings: ufs: qcom: Fix warning for sdm845 by adding reg-names
Date: Fri, 23 Jun 2023 14:31:49 +0200	[thread overview]
Message-ID: <cd84b8c6-fac7-ecef-26be-792a1b04a102@linaro.org> (raw)
In-Reply-To: <20230623113009.2512206-6-abel.vesa@linaro.org>
On 23/06/2023 13:30, Abel Vesa wrote:
> There is a warning on dtbs check for sdm845, amongst other platforms,
> about the reg-names being unevaluated. Fix that by adding reg-names to
> the clocks and reg properties check for such platforms.
> 
> Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema")
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>  Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> index 0209713d1f88..894b57117314 100644
> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> @@ -166,6 +166,10 @@ allOf:
>          reg:
>            minItems: 2
>            maxItems: 2
> +        reg-names:
> +          items:
> +            - const: std
> +            - const: ice
reg-names looks like a new property, so it should be defined in
top-level and just constrained per-variant.
Also there was similar approach:
https://lore.kernel.org/all/20221209-dt-binding-ufs-v2-2-dc7a04699579@fairphone.com/
but I guess no resends and it can be superseded.
Best regards,
Krzysztof
next prev parent reply	other threads:[~2023-06-23 12:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-23 11:30 [PATCH 0/5] scsi: dt-bindings: ufs: qcom: Some fixes to clear all dtbs_check warnings Abel Vesa
2023-06-23 11:30 ` [PATCH 1/5] scsi: dt-bindings: ufs: qcom: Fix ICE phandle Abel Vesa
2023-06-23 16:45   ` Krzysztof Kozlowski
2023-06-23 11:30 ` [PATCH 2/5] scsi: dt-bindings: ufs: qcom: Add compatible for sm6115 and sm6125 Abel Vesa
2023-06-23 12:33   ` Krzysztof Kozlowski
2023-06-23 12:34     ` Krzysztof Kozlowski
2023-06-23 11:30 ` [PATCH 3/5] scsi: dt-bindings: ufs: qcom: Add compatible for sc8180x Abel Vesa
2023-06-23 12:30   ` Krzysztof Kozlowski
2023-06-23 11:30 ` [PATCH 4/5] scsi: dt-bindings: ufs: qcom: Fix sm8450 clocks Abel Vesa
2023-06-23 12:21   ` Rob Herring
2023-06-23 20:12     ` Rob Herring
2023-06-23 11:30 ` [PATCH 5/5] scsi: dt-bindings: ufs: qcom: Fix warning for sdm845 by adding reg-names Abel Vesa
2023-06-23 12:31   ` Krzysztof Kozlowski [this message]
2023-06-23 12:38     ` Luca Weiss
2023-06-23 21:17       ` Rob Herring
2023-06-24  7:49         ` Krzysztof Kozlowski
2023-06-27 15:14           ` Rob Herring
2023-06-26  6:38         ` Luca Weiss
2023-06-26  7:41           ` Krzysztof Kozlowski
2023-06-26  8:19             ` Luca Weiss
2023-06-27 15:18               ` Rob Herring
2023-06-28  6:49                 ` Luca Weiss
2023-06-24 12:30       ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=cd84b8c6-fac7-ecef-26be-792a1b04a102@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=abel.vesa@linaro.org \
    --cc=agross@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=andersson@kernel.org \
    --cc=avri.altman@wdc.com \
    --cc=bvanassche@acm.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=mani@kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).