From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f66.google.com (mail-ej1-f66.google.com [209.85.218.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF9B9173343 for ; Fri, 21 Jun 2024 11:25:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718969124; cv=none; b=uG8kIYOWy4LK7eRVzjV2CVLyTFondoBbw5bFHJXj+h6fXruE4PJFYOqE31WhAs6UL403fxIjJAszQRYZCIkazgSvwyCXqB3y4XRVqx0uPgt96YnSXQMQjPnVY6IQ0DUXbhwibTIKJELhpy1sUXW+gCwNO3C1mJBSxhIFDMWLnIA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718969124; c=relaxed/simple; bh=/78T4gIP6Vl7qO16NoY/Yc+0FArSmsilMMQukCe6F6Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=l69sXhwKKovfGaBhJbrqdASesDNPxmdq2mehE4VpIF+t6Qv6oFSUuvURwFXQyQZymVW3HdT2chZxJhH6Kbo7WVVONqTy2MIiWOYXni4pP9NNidzSUUCaTMFF1Luvgy/oxbe8rNaT5d59KRIfBQKCtQYVeTTtKqYd7/2g+zpeX3A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Un0i7p2K; arc=none smtp.client-ip=209.85.218.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Un0i7p2K" Received: by mail-ej1-f66.google.com with SMTP id a640c23a62f3a-a6f7720e6e8so226279166b.3 for ; Fri, 21 Jun 2024 04:25:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718969121; x=1719573921; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NVqer5McNqdNZnecI/834Szrx4B8E3Deyrvm1bBN9j4=; b=Un0i7p2K6bw0p+YO4Sxsmx+evq4Aq3M4dyXapGavjzfqtxmBSy4C9McKXsQCBQvS/N RDAjAkvj3lifiiej0NVA7dDSTca99Tn+/3JrAqu9sNPzuozBKaXrqa7Or83Orx9iPqAE EI3rv5if4dGHvhPR8FUifG66WhngykGyYCA9eiSSyk2lCCA/kpREjjz60XAgDLvrzwQ5 GMwXoQ109Ic7YdWuYeQu8sTp2gb9/p+vQXpH06KCoRLS2hcm8VxVNjFlCLSXB/yluWLy W3+E+8jNpZoujli8Fx4ezpKfnyO5ZknmSp0t5NuiseYQRgnHRblPflRltiItnW70P4Pu Vg+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718969121; x=1719573921; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NVqer5McNqdNZnecI/834Szrx4B8E3Deyrvm1bBN9j4=; b=hacpFO6eVaRoBJ+79Oh/AQdUm7TvfUMoxo1bs84oyu5209lP3nfpPyGeJoXlddL+qT hVuAsNuqHNIN4I/Xvop13p7I5JJFKAKelt/DPfVyJOo/ykki7JL/5BlmGnYv7DJ5jmUc WujCCNKjsjJ/P0m8fmL1aGCl8ulY3WGYAsfJOeZ49OxR6ijm8R479mHcQCBUKdULNv60 jzT0gtGTwbwfvZbH8W2I+4j0ByYTdOtSBFsD+Odq8odh5oyuPt6gcar7NRf/oJ/b56cp mUQ93Lr5CSnCkqowmeEguBghRdv3RUgvaslTvti4IG7tcwtRZEzp3nb0suuNWD5Rd3Ht Csdw== X-Forwarded-Encrypted: i=1; AJvYcCUW3RKia8LHsaY72HwKV8QosE9L5wxIzdo7TlxfqlvvuVl+bN9cV0FHwZRkw89bGXhnsSz19ZMv7np30n2w0q1Jp0WtxtsHelY9bA== X-Gm-Message-State: AOJu0YxC0sKwy8zqFqTlqGCjfTSySqR8JWvJj3e4XGGl/L+EmoTUn78M BSKl4XvNtPFlu5Inw4u0wpn1pkFu0dbg4T37/PRXSxSP7gyxIXQxxbR1XCx7gJc= X-Google-Smtp-Source: AGHT+IH126ydw90RFkIhA8Jjhs+0tNi7TXjbkKjB2FNHRMNyT4BERWZyQz9kSzzxO2pfpg2TTTUqyA== X-Received: by 2002:a17:906:b41:b0:a6f:1445:9de8 with SMTP id a640c23a62f3a-a6fab778da9mr570586766b.54.1718969120996; Fri, 21 Jun 2024 04:25:20 -0700 (PDT) Received: from [192.168.0.3] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6fcf489e1asm73538966b.47.2024.06.21.04.25.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jun 2024 04:25:20 -0700 (PDT) Message-ID: Date: Fri, 21 Jun 2024 12:25:18 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/6] media: qcom: camss: csiphy-3ph: Add Gen2 v1.2.2 two-phase MIPI CSI-2 DPHY init To: gchan9527@gmail.com, Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org, Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240621-b4-sc7180-camss-v1-0-14937929f30e@gmail.com> <20240621-b4-sc7180-camss-v1-3-14937929f30e@gmail.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240621-b4-sc7180-camss-v1-3-14937929f30e@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21/06/2024 10:40, George Chan via B4 Relay wrote: > From: George Chan > > Add a PHY configuration sequence for the sc7180 which uses a Qualcomm > Gen 2 version 1.2.2 CSI-2 PHY. > > The PHY can be configured as two phase or three phase in C-PHY or D-PHY > mode. This configuration supports two-phase D-PHY mode. > > Signed-off-by: George Chan > --- > .../platform/qcom/camss/camss-csiphy-3ph-1-0.c | 120 +++++++++++++++++++++ > 1 file changed, 120 insertions(+) > > diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c > index df7e93a5a4f6..181bb7f7c300 100644 > --- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c > +++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c > @@ -348,6 +348,121 @@ csiphy_reg_t lane_regs_sm8250[5][20] = { > }, > }; > > +/* GEN2 1.2.2 2PH */ This is the init sequence for 1_2_1 not 1_2_2 https://review.lineageos.org/c/LineageOS/android_kernel_xiaomi_sm8250/+/311931/10/techpack/camera/drivers/cam_sensor_module/cam_csiphy/include/cam_csiphy_1_2_1_hwreg.h https://review.lineageos.org/c/LineageOS/android_kernel_xiaomi_sm8250/+/311931/10/techpack/camera/drivers/cam_sensor_module/cam_csiphy/include/cam_csiphy_1_2_2_hwreg.h Please fix. --- bod