From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:MIPS" <linux-mips@vger.kernel.org>
Subject: Re: [PATCHv2 2/3] wifi: ath9k: ahb: add led pin OF support
Date: Thu, 14 Aug 2025 07:55:00 +0200 [thread overview]
Message-ID: <cdaf0a50-379c-458e-9ad3-c796979a856d@kernel.org> (raw)
In-Reply-To: <CAKxU2N91q=d_c===x=AL+pwXkz8K1B8eXj8ePfm6dK_4cAk9Gg@mail.gmail.com>
On 14/08/2025 00:59, Rosen Penev wrote:
>>
>>> + u32 led_pin;
>>> +
>>> + if (!of_property_read_u32(np, "reg", &led_pin))
>>> + ah->led_pin = led_pin;
>>> +
>>> + ah->config.led_active_high = !of_property_read_bool(np, "led-active-low");
>>> + of_node_put(np);
>>> + }
>>
>> Leaking OF node.
>
> Not following here.
You miss proper cleanup, leaking of node.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-14 5:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 19:23 [PATCHv2 0/3] wifi: ath9k: ahb: add OF LED support Rosen Penev
2025-08-12 19:23 ` [PATCHv2 1/3] dt-bindings: net: wireless: ath9k: add led bindings Rosen Penev
2025-08-13 8:16 ` Krzysztof Kozlowski
2025-08-13 23:04 ` Rosen Penev
2025-08-14 9:11 ` Krzysztof Kozlowski
2025-08-12 19:23 ` [PATCHv2 2/3] wifi: ath9k: ahb: add led pin OF support Rosen Penev
2025-08-13 8:20 ` Krzysztof Kozlowski
2025-08-13 22:59 ` Rosen Penev
2025-08-14 5:55 ` Krzysztof Kozlowski [this message]
2025-08-12 19:23 ` [PATCHv2 3/3] mips: qca: use led-sources for WMAC LED Rosen Penev
2025-08-13 8:18 ` [PATCHv2 0/3] wifi: ath9k: ahb: add OF LED support Krzysztof Kozlowski
2025-08-13 23:07 ` Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdaf0a50-379c-458e-9ad3-c796979a856d@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johannes@sipsolutions.net \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rosenp@gmail.com \
--cc=toke@toke.dk \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).