From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792476863; b=l0XaGFCXMBU5dzoepRb1tq5fPl08aHJ12EboKpKNjiqS47N30I9cDr73febjwpSvFc1K rWAX+VU9F8GK+280xpEhtXr+PFmZX56kQniMlDDLZ4mB7SzyYg9G/Hqz+ZqUiJeopVIiw Mn61styLKVry+EImA+26SF7+ux0omPHGoGBvDJvak0utKcXFY33oJTkjG8y15dFzIi64+ pe9RuDSLxHWgW2PP2MPDmbtTWq+fWfUz4y3sujFgg2vt4cN5Wb0P4a8dbqhg/9MEmICJg kFKmCCn38Iw2xqsLfrhT1PePqw4YqPMq+2aIg6nvCeydDzYdpvnZqaUFEneEiar956g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792476863; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Proofpoint-ORIG-GUID: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-Spam-Info: X-Authority-Analysis:X-Proofpoint-GUID:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=Hpn5/imhVLkyJfVtXA9ZyfLeHTm0l9wahpNmwyZ1iuY=; b=Knn7HiLbtLegpZGiLuRA5O9NRxvGg93Gp+ohOCn1wV4l2c8rV1/F3OhaO7ziw4zWoytH WKiAvBsGhSjBg3oNyFc7dhFp09IB/yS0ffNaI1qOexy+5W2tH3cMg/KRlK7kWfhActe1e 1JK8Ny4NubKVpcTgBykkJOKTLN9oM1jVMOKl3udxxfkxmEYe9Esr8svUIp9P+kBViv5z2 on05Xe5flAvW113RYTUZeJa44EagbtXOlliAFFi1C9coahCEf59Ew8FSd5jEovkxT7A74 4veyhp8yWw3WYfmM4+MhlmhJsRSXTk7LofytOi4vI3SnWlxDxVw+XW3nokXCQxsgSdg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=ZfKSDihK; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=HOiV4n2e; arc=none smtp.remote-ip=205.220.168.131 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4694A606A31F for ; Tue, 20 Oct 2026 06:14:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 4694A606A31F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=ZfKSDihK; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=HOiV4n2e Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69K0t3vq1253890 for ; Tue, 20 Oct 2026 06:14:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Hpn5/imhVLkyJfVtXA9ZyfLeHTm0l9wahpNmwyZ1iuY=; b=ZfKSDihKFacIqpqS d2+KviIIWhZ2wrHxLy5ztQw7gBdTjQXQXvMIA9yBUS/2k9EgKzGeNcRGHTOUeaAV IgJM5M84kimu5wAu2mN/VVJEyXSErm8ksu/ZNtJKioVKCaJ6CJPDFF1SnLNZtZ8b s6Re+s5FmExW6AqeoacLL19yDIMr3KBi3KTLNcH98zPJyj39tBn6YJO5am/lVAgA e4SEQYzbMmIbpYtJt6Dh/N7oZ8aclFn7mtXjjj5ll9L7PAvGPk2iD7KW62Y+fsbh /YBm8H8YObw3Z/0G0zHhYJQoIvGfKEJ0bqizP1ASXqty5ouvbBuUEreZMRm4kqqt Dlx3kA== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hdw5n93v2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 20 Oct 2026 06:14:22 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-93f2005ce21so512359685a.3 for ; Mon, 19 Oct 2026 23:14:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792476861; x=1793081661; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Hpn5/imhVLkyJfVtXA9ZyfLeHTm0l9wahpNmwyZ1iuY=; b=HOiV4n2exjuLkrjSPhWReDJKCI581JGKeqSEzq2JzamYrDDYUFRn587f+3OpvGEcYL VMVqCP9D1gRocl/qF36evYClOrtj8MBNHdR7BpTCQpuHXbpbNL72FjaoNskhSRPYSSbU vjlzDlDzYBVoz96r/gCRdhr2/maCjKBlLkCC7aldsFZVDFDfj71/AsTidDRZ/m8mTZ64 5GjQR1pYwzQxQacp8VtaIV4KZ6fc6cM37IKM/IcL4yaZdBUTLG77WubJle/ziFA0/nyO mCAYSkVBXxzl7EyGp08Ac5AhCPQ0KRZK4KZXarXjxdt8IAngUSOXjVgeweysdWQjwwNH QBCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792476861; x=1793081661; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Hpn5/imhVLkyJfVtXA9ZyfLeHTm0l9wahpNmwyZ1iuY=; b=FrWvAil+X/Uzt5sbirOw1t/AX4A7BBFFMZNUWeUSVHqSsM+asK8WYdGXJ02uYVfq9G TLWDe01kaDlnzIRDy+0rsbrQLHIu5YMO4Y6eAhWM08ZkDhEjgye/Jo7ES1BArEM7KAWy qrN1TO5Qt1w0L5NNISqy+Qp4cB6texAowfEKuMWHu/BHQn9Qk0Kz+xVcdztSA3zta5yH PjLbDsPRZmLe6rhIsB2wkxw/2N8C3hKJnymNe2VqfA6MQBA/F1NdReP0+I21slrJUSkV a/GdfyppI3oxhJ86+sEIcJlQ6PLF8Ee1H/dbSrpRJ5SIAyWQ/r2Kql7Yd2d7iFm11U5I KeHQ== X-Forwarded-Encrypted: i=1; AKwUvByd567NNXnbJoNr4rvwame0W9I7kzcUyHdBxO+d1gG4b1IwVBiOvP3+lvERFwWbh6jmhoauXrSmDC82@vger.kernel.org X-Gm-Message-State: AFq9FYLTuRVXRpWL/Ts6ol/nkUq+HlP73dXYxF0BaTWmlbIwjs+r0/+p iPPWDmBUJFzheesFMYSIy9F85bQ238HybtaM0xnEvZZ4oHyC03L20JOQosR3x9s8AhMzS9nlWWg qEghoeR3MpyxaYejYPHDyd4GWFpmNDlyvuhdTDgSjrjOmpSZpRVvqwpNenSrHBwK9 X-Gm-Gg: AYBFou3qX6lXzhUKx0BgaHYHgp13Szlne4FIZG5NuoOxyDUTJJt7MMJlDe5DaUOmxas Js76+Un7GfolgwUVSoy6MbbKeSEJfL5uTI8lwXYYzpKU11yLjrwICKXuqakZiT26xGjgQ60DnFD zPjO+aVcqb1RHqgtjCpg9yumbTa5FidoRa9vzpvh6EaBK5KMmIh51Rf6fxcHPAdAAJFHJ5YVzfx TCTjsCKICojUcRx6YJsgaPgYDzWSoAe3EzIK8ULksY3Bc14e8dr873uex7ReYRc+Ulz2eN2wicM mf9f9bG5+Mqz5rGonlzuqfzhHWVcvsW4jUzxkqfHOHtFSGPn9IX1HWdyfMPa1SGmHdbbDN2NSta m8RunmYkvH9sLyiOGqMp+h2OXcA== X-Received: by 2002:a05:620a:3715:b0:93e:c12c:9dd3 with SMTP id af79cd13be357-93f29e0afd2mr1621876485a.83.1792476861462; Mon, 19 Oct 2026 23:14:21 -0700 (PDT) X-Received: by 2002:a05:620a:3715:b0:93e:c12c:9dd3 with SMTP id af79cd13be357-93f29e0afd2mr1621873885a.83.1792476860971; Mon, 19 Oct 2026 23:14:20 -0700 (PDT) Received: from [192.168.68.120] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4a1ce33ad3fsm276350095e9.5.2026.10.19.23.14.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Oct 2026 23:14:20 -0700 (PDT) Message-ID: Date: Tue, 20 Oct 2026 07:14:17 +0100 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] leds: rgb: qcom-lpg: add qcom,pmk8850-pwm compatible To: Lee Jones Cc: Rob Herring , Bjorn Andersson , Konrad Dybcio , Pavel Machek , Krzysztof Kozlowski , Conor Dooley , Abel Vesa , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20261015194732.64428-1-srinivas.kandagatla@oss.qualcomm.com> <20261015194732.64428-3-srinivas.kandagatla@oss.qualcomm.com> <179213351749.2581328.3338477962958404050@kernel.org> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <179213351749.2581328.3338477962958404050@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: rbtBqzsC-9stpStN87zFxOM50I9wl5XA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDIwMDAyNCBTYWx0ZWRfX4V86YDWUBW87 i2BxE2euO5O5MuesHX8HjL3MtL2SY7Fr/X6ZuEJ9MhfZgQmJbKjpvrDePNr7bubL0/uuCCeg5mz 0XPavgcyFFYOZ6aq9wjqCPXlDza+Fkv8xu7Y0BadrJtCdy6KARzgAFb81k1zQsOe553odEDWG6I SAwoViscb2vgdkESkg/M0wMtdHajEJ4vL9FPFbzfYttv3anQIWNIOFPA+nEZ0U7jgjp7XZgpW9I LfGIQzd2jpWqW9NiITykuNJcNYjm9Acx/n4uvB8yDkcWXrKWitmVk0olGxlEjE8HvSUNWPydL5F HX8eIOkyzsLAMpsyZD2heWoypLCJQpdI1MeVr0RVVORRQyWXSf9bXSRtR29aNNkRyuzQ++BUL2f enW2wDciA2OtWhF7M/U5WRcf7u8BZfDRtcWM93lpHYogES8UNYwKwL8z2YDM3qurgkxfU82pC38 BvVhLKcM9tgRCt8EI3A== X-Proofpoint-Spam-Info: AW1haW4tMjYxMDIwMDAyNCBTYWx0ZWRfX30rzGS4bS1Xe vy3n053mc6PhBwybU/WL7ySaMWp+dInLrxpkJf8kzy6lzqsXA84mJSdq4EKe8OnV/eAJ0F54sxG SQjkWJgyFx5+58T2heDAXuD+xYevEgQ= X-Authority-Analysis: v=2.4 cv=VI9IDNPX c=1 sm=1 tr=0 ts=6ad706be cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=VAR32ooWsMDrCBR8X2sA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-GUID: rbtBqzsC-9stpStN87zFxOM50I9wl5XA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-20_01,2026-10-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610200024 On 10/19/26 3:34 PM, Lee Jones wrote: > --- checkpatch.pl (1 issue) --- > Line 23: WARNING: DT compatible string "qcom,pmk8850-pwm" appears un-documented -- check ./Documentation/devicetree/bindings/ this is in patch 1/4. > ---------------------------------- > > On Thu, 15 Oct 2026, Srinivas Kandagatla wrote: > >> The PMK8850 sleep-clock PMIC on Snapdragon X2 Elite (Mahua) exposes >> the same two-channel LPG/PWM block as PMK8550 at 0xe800/0xe900, so >> reuse pmk8550_pwm_data. >> >> Used on the Lenovo ThinkPad T14s Gen 7 to drive the eDP backlight >> (EDP_BL/PWMR_BV_PS). >> >> Signed-off-by: Srinivas Kandagatla >> --- >> drivers/leds/rgb/leds-qcom-lpg.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c >> index 24ffe079f221..485fa2a7a848 100644 >> --- a/drivers/leds/rgb/leds-qcom-lpg.c >> +++ b/drivers/leds/rgb/leds-qcom-lpg.c >> @@ -1837,6 +1837,7 @@ static const struct of_device_id lpg_of_table[] = { >> { .compatible = "qcom,pmi8998-lpg", .data = &pmi8998_lpg_data }, >> { .compatible = "qcom,pmc8180c-lpg", .data = &pm8150l_lpg_data }, >> { .compatible = "qcom,pmk8550-pwm", .data = &pmk8550_pwm_data }, >> + { .compatible = "qcom,pmk8850-pwm", .data = &pmk8550_pwm_data }, > If PMK8850 is completely compatible with PMK8550, why are we adding a > new match entry here instead of using 'qcom,pmk8550-pwm' as a fallback > compatible? Yep, will update dts in v2 and drop this patch. --srini >