devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 0/2] arm64: dts: Update cache properties for exynos/fsd
@ 2022-11-23  9:01 Pierre Gondois
  2022-11-23  9:01 ` [PATCH v3 1/2] arm64: dts: Update cache properties for exynos Pierre Gondois
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Pierre Gondois @ 2022-11-23  9:01 UTC (permalink / raw)
  To: linux-kernel
  Cc: Pierre Gondois, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
	Aswani Reddy, Shashank Prashar, Andi Shyti, devicetree,
	linux-arm-kernel, linux-samsung-soc

v1:
 - exynos: [1]
 - fds: [2]
v2:
  No change.
 - exynos: [3]
 - fds: [4]
v3:
 - Update commit header for fds platform.

As requested by [5], resend patches updating the cache properties for the
exynos/fsd platforms with:
1. Fixed subject.
2. Changelog.
3. Trimmed list.

[1] https://lore.kernel.org/all/20221031091945.531874-1-pierre.gondois@arm.com/
[2] https://lore.kernel.org/all/20221031092125.533621-1-pierre.gondois@arm.com/
[3] https://lore.kernel.org/all/20221107155825.1644604-8-pierre.gondois@arm.com/
[4] https://lore.kernel.org/all/20221107155825.1644604-23-pierre.gondois@arm.com/
[5] https://lore.kernel.org/all/4f4bdc95-16a2-df76-9787-df46a3b5e1eb@linaro.org/

Pierre Gondois (2):
  arm64: dts: Update cache properties for exynos
  arm64: dts: Update cache properties for fds

 arch/arm64/boot/dts/exynos/exynos5433.dtsi | 4 ++++
 arch/arm64/boot/dts/exynos/exynos7.dtsi    | 2 ++
 arch/arm64/boot/dts/tesla/fsd.dtsi         | 2 ++
 3 files changed, 8 insertions(+)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v3 1/2] arm64: dts: Update cache properties for exynos
  2022-11-23  9:01 [PATCH v3 0/2] arm64: dts: Update cache properties for exynos/fsd Pierre Gondois
@ 2022-11-23  9:01 ` Pierre Gondois
  2022-11-23  9:01 ` [PATCH v3 2/2] arm64: dts: Update cache properties for fds Pierre Gondois
  2022-11-23  9:03 ` [PATCH v3 0/2] arm64: dts: Update cache properties for exynos/fsd Krzysztof Kozlowski
  2 siblings, 0 replies; 4+ messages in thread
From: Pierre Gondois @ 2022-11-23  9:01 UTC (permalink / raw)
  To: linux-kernel
  Cc: Pierre Gondois, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
	Aswani Reddy, Shashank Prashar, Arnd Bergmann, devicetree,
	linux-arm-kernel, linux-samsung-soc

The DeviceTree Specification v0.3 specifies that the cache node
'compatible' and 'cache-level' properties are 'required'. Cf.
s3.8 Multi-level and Shared Cache Nodes
The 'cache-unified' property should be present if one of the
properties for unified cache is present ('cache-size', ...).

Update the Device Trees accordingly.

Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
 arch/arm64/boot/dts/exynos/exynos5433.dtsi | 4 ++++
 arch/arm64/boot/dts/exynos/exynos7.dtsi    | 2 ++
 2 files changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index bd6a354b9cb5..8619920da4b6 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -226,6 +226,8 @@ cpu7: cpu@3 {
 
 		cluster_a57_l2: l2-cache0 {
 			compatible = "cache";
+			cache-level = <2>;
+			cache-unified;
 			cache-size = <0x200000>;
 			cache-line-size = <64>;
 			cache-sets = <2048>;
@@ -233,6 +235,8 @@ cluster_a57_l2: l2-cache0 {
 
 		cluster_a53_l2: l2-cache1 {
 			compatible = "cache";
+			cache-level = <2>;
+			cache-unified;
 			cache-size = <0x40000>;
 			cache-line-size = <64>;
 			cache-sets = <256>;
diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi
index 1cd771c90b47..f378d8629d88 100644
--- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
@@ -107,6 +107,8 @@ cpu_atlas3: cpu@3 {
 
 		atlas_l2: l2-cache0 {
 			compatible = "cache";
+			cache-level = <2>;
+			cache-unified;
 			cache-size = <0x200000>;
 			cache-line-size = <64>;
 			cache-sets = <2048>;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v3 2/2] arm64: dts: Update cache properties for fds
  2022-11-23  9:01 [PATCH v3 0/2] arm64: dts: Update cache properties for exynos/fsd Pierre Gondois
  2022-11-23  9:01 ` [PATCH v3 1/2] arm64: dts: Update cache properties for exynos Pierre Gondois
@ 2022-11-23  9:01 ` Pierre Gondois
  2022-11-23  9:03 ` [PATCH v3 0/2] arm64: dts: Update cache properties for exynos/fsd Krzysztof Kozlowski
  2 siblings, 0 replies; 4+ messages in thread
From: Pierre Gondois @ 2022-11-23  9:01 UTC (permalink / raw)
  To: linux-kernel
  Cc: Pierre Gondois, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
	Aswani Reddy, Shashank Prashar, Arnd Bergmann, devicetree,
	linux-arm-kernel, linux-samsung-soc

The DeviceTree Specification v0.3 specifies that the cache node
'compatible' and 'cache-level' properties are 'required'. Cf.
s3.8 Multi-level and Shared Cache Nodes
The 'cache-unified' property should be present if one of the
properties for unified cache is present ('cache-size', ...).

Update the Device Trees accordingly.

Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
 arch/arm64/boot/dts/tesla/fsd.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi b/arch/arm64/boot/dts/tesla/fsd.dtsi
index f35bc5a288c2..d58d47618c95 100644
--- a/arch/arm64/boot/dts/tesla/fsd.dtsi
+++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
@@ -281,6 +281,8 @@ cpucl2_3: cpu@203 {
 
 		cpucl_l2: l2-cache0 {
 			compatible = "cache";
+			cache-level = <2>;
+			cache-unified;
 			cache-size = <0x400000>;
 			cache-line-size = <64>;
 			cache-sets = <4096>;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v3 0/2] arm64: dts: Update cache properties for exynos/fsd
  2022-11-23  9:01 [PATCH v3 0/2] arm64: dts: Update cache properties for exynos/fsd Pierre Gondois
  2022-11-23  9:01 ` [PATCH v3 1/2] arm64: dts: Update cache properties for exynos Pierre Gondois
  2022-11-23  9:01 ` [PATCH v3 2/2] arm64: dts: Update cache properties for fds Pierre Gondois
@ 2022-11-23  9:03 ` Krzysztof Kozlowski
  2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-23  9:03 UTC (permalink / raw)
  To: Pierre Gondois, linux-kernel
  Cc: Rob Herring, Krzysztof Kozlowski, Alim Akhtar, Aswani Reddy,
	Shashank Prashar, Andi Shyti, devicetree, linux-arm-kernel,
	linux-samsung-soc

On 23/11/2022 10:01, Pierre Gondois wrote:
> v1:
>  - exynos: [1]
>  - fds: [2]
> v2:
>   No change.
>  - exynos: [3]
>  - fds: [4]
> v3:
>  - Update commit header for fds platform.
> 
> As requested by [5], resend patches updating the cache properties for the
> exynos/fsd platforms with:
> 1. Fixed subject.

No improvements in the subject.

Use subject prefixes matching the subsystem (git log --oneline -- ...).


Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-11-23  9:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-23  9:01 [PATCH v3 0/2] arm64: dts: Update cache properties for exynos/fsd Pierre Gondois
2022-11-23  9:01 ` [PATCH v3 1/2] arm64: dts: Update cache properties for exynos Pierre Gondois
2022-11-23  9:01 ` [PATCH v3 2/2] arm64: dts: Update cache properties for fds Pierre Gondois
2022-11-23  9:03 ` [PATCH v3 0/2] arm64: dts: Update cache properties for exynos/fsd Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).