Devicetree
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Nihal Kumar Gupta <nihal.gupta@oss.qualcomm.com>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Vijay Kumar Tumati <vijay.tumati@oss.qualcomm.com>
Cc: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Bryan O'Donoghue <bod@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 2/2] phy: qcom-mipi-csi2: Add a CSI2 MIPI DPHY driver
Date: Wed, 1 Jul 2026 16:53:28 +0100	[thread overview]
Message-ID: <cdcea32f-0160-4501-9dfd-9103807c4d93@linaro.org> (raw)
In-Reply-To: <59331aa7-8430-4754-861c-4ba6a4810ccd@oss.qualcomm.com>

On 05/06/2026 10:31, Nihal Kumar Gupta wrote:
>> Having clock-names property doesn't mean that all values are valid.
>>
> CSI_COMMON_CTRL5 is a physical lane power-up bitmap:
> - Bits [0,2,4,6] → D-PHY data lanes(LN0, LN2, LN4, LN6)
> - Bits [1,3,5] → C-PHY trio lanes(LN1, LN3, LN5)
> - Bit [7] → D-PHY clock lane(LNCK) dedicated clock enable
> 
> In combo mode, only LN6 can be configurable as a clock lane.

This is a really excellent comment and I'm going to copy/paste the text 
entirely into the driver as a comment.

ty

---
bod

  parent reply	other threads:[~2026-07-01 15:53 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-23  2:48 [PATCH v8 0/2] phy: qcom-mipi-csi2: Add a CSI2 MIPI DPHY driver Bryan O'Donoghue
2026-05-23  2:48 ` [PATCH v8 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema Bryan O'Donoghue
2026-05-23  3:04   ` sashiko-bot
2026-05-24 10:59     ` Bryan O'Donoghue
2026-05-24 15:37     ` Bryan O'Donoghue
2026-06-02 20:55   ` Frank Li
2026-06-02 21:00     ` Bryan O'Donoghue
2026-06-02 21:59   ` Vladimir Zapolskiy
2026-06-02 22:51     ` Bryan O'Donoghue
2026-06-03 20:16       ` Vijay Kumar Tumati
2026-06-03 20:24         ` Vijay Kumar Tumati
2026-06-03 20:51           ` Vladimir Zapolskiy
2026-06-03 21:18             ` Bryan O'Donoghue
2026-06-03 21:46               ` Vijay Kumar Tumati
2026-06-05  2:59                 ` Vijay Kumar Tumati
2026-06-04  0:07               ` Vladimir Zapolskiy
2026-06-04  0:30                 ` Bryan O'Donoghue
2026-06-04  8:46                   ` Vladimir Zapolskiy
2026-06-04  9:06                     ` Bryan O'Donoghue
2026-06-04  9:20                       ` Vladimir Zapolskiy
2026-06-04 11:04                         ` Bryan O'Donoghue
2026-06-09 13:56                       ` Konrad Dybcio
2026-06-09 19:20                         ` Vijay Kumar Tumati
2026-06-09 22:30                           ` Dmitry Baryshkov
2026-06-19 12:37                             ` Konrad Dybcio
2026-06-03 20:52           ` Bryan O'Donoghue
2026-06-03 21:35             ` Vijay Kumar Tumati
2026-06-04 10:54       ` Vladimir Zapolskiy
2026-07-01 22:54     ` Bryan O'Donoghue
2026-07-01 23:37       ` Vladimir Zapolskiy
2026-07-02  0:08         ` Bryan O'Donoghue
2026-07-02  0:10           ` Bryan O'Donoghue
2026-07-02  8:31           ` Vladimir Zapolskiy
2026-07-02  8:46             ` Bryan O'Donoghue
2026-07-02  9:28               ` Vladimir Zapolskiy
2026-05-23  2:48 ` [PATCH v8 2/2] phy: qcom-mipi-csi2: Add a CSI2 MIPI DPHY driver Bryan O'Donoghue
2026-05-23  3:35   ` sashiko-bot
2026-06-02  8:18   ` Loic Poulain
2026-06-02 13:58     ` Bryan O'Donoghue
2026-06-03 10:10       ` Loic Poulain
2026-06-02 22:07   ` Vladimir Zapolskiy
2026-06-02 22:22     ` Bryan O'Donoghue
2026-06-03 12:10       ` Dmitry Baryshkov
2026-06-03 12:22         ` Bryan O'Donoghue
2026-06-03 12:40           ` Dmitry Baryshkov
2026-06-03 12:57             ` Bryan O'Donoghue
2026-06-03 20:42               ` Vladimir Zapolskiy
2026-06-03 21:12                 ` Bryan O'Donoghue
2026-06-03 23:58                   ` Vladimir Zapolskiy
2026-06-03 21:37               ` Vijay Kumar Tumati
2026-06-03 22:14                 ` Dmitry Baryshkov
2026-06-05  9:31                   ` Nihal Kumar Gupta
2026-06-05 10:30                     ` Bryan O'Donoghue
2026-07-01 15:53                     ` Bryan O'Donoghue [this message]
2026-07-01 16:05                     ` Bryan O'Donoghue
2026-06-03 21:11   ` Vijay Kumar Tumati
2026-06-03 22:39   ` Vijay Kumar Tumati

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cdcea32f-0160-4501-9dfd-9103807c4d93@linaro.org \
    --to=bryan.odonoghue@linaro.org \
    --cc=bod@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=kishon@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=neil.armstrong@linaro.org \
    --cc=nihal.gupta@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=vijay.tumati@oss.qualcomm.com \
    --cc=vkoul@kernel.org \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox