From: Marek Vasut <marex@denx.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
Yann Gautier <yann.gautier@foss.st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Rob Herring <robh+dt@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
devicetree@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH v2] dt-bindings: mmc: arm,pl18x: Document interrupt-names property
Date: Tue, 27 Sep 2022 21:18:21 +0200 [thread overview]
Message-ID: <cdda3cb1-5772-88f7-aafc-d4ecf51fd050@denx.de> (raw)
In-Reply-To: <CACRpkdaA=3QU+_HQkK6RSe4qQJ28O4BbtT6jHuKeVjKqaqLJaQ@mail.gmail.com>
On 9/27/22 14:18, Linus Walleij wrote:
> On Tue, Sep 27, 2022 at 12:41 PM Marek Vasut <marex@denx.de> wrote:
>
>> --- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
>> @@ -99,6 +99,9 @@ properties:
>> minItems: 1
>> maxItems: 2
>>
>> + interrupt-names:
>> + const: cmd_irq
>
> This hardware come in variants with one or two IRQs.
>
> Either two: "cmd_irq", "data_irq"
>
> Or one combined IRQ (logic OR between those two!)
> I don't know what that should be called, perhaps
> "cmd_data_irq".
>
> Since all DTS:es then have to be patched an alternative
> is as Arnd says to just delete the names. We should however
> at the very least patch the bindings description: for the IRQs
> to make the above situation clear.
Done, bindings updated and stm32/qcom DTs cleaned up.
prev parent reply other threads:[~2022-09-27 19:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 10:41 [PATCH v2] dt-bindings: mmc: arm,pl18x: Document interrupt-names property Marek Vasut
2022-09-27 12:04 ` Arnd Bergmann
2022-09-27 12:18 ` Linus Walleij
2022-09-27 19:18 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdda3cb1-5772-88f7-aafc-d4ecf51fd050@denx.de \
--to=marex@denx.de \
--cc=alexandre.torgue@foss.st.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=yann.gautier@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).