[PATCH v2] dt-bindings: mmc: arm,pl18x: Document interrupt-names property

[PATCH v2] dt-bindings: mmc: arm,pl18x: Document interrupt-names property

[Marek Vasut]

Document interrupt-names property with "cmd_irq" interrupt name.
This fixes dtbs_check warnings when building current Linux DTs:

"
arch/arm/boot/dts/stm32mp153c-dhcom-drc02.dtb: mmc@58007000: Unevaluated properties are not allowed ('interrupt-names' was unexpected)
"

Reviewed-by: Yann Gautier <yann.gautier@foss.st.com>
Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Yann Gautier <yann.gautier@foss.st.com>
Cc: devicetree@vger.kernel.org
Cc: linux-mmc@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
To: linux-arm-kernel@lists.infradead.org
---
V2: - Fix copy-paste error from similar patch for I2C bus bindings
    - Add RB from Yann
---
 Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
index 1e69a5a42439b..5f7eae8d57ab9 100644
--- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
+++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
@@ -99,6 +99,9 @@ properties:
     minItems: 1
     maxItems: 2
 
+  interrupt-names:
+    const: cmd_irq
+
   st,sig-dir-dat0:
     $ref: /schemas/types.yaml#/definitions/flag
     description: ST Micro-specific property, bus signal direction pins used for
-- 
2.35.1

Re: [PATCH v2] dt-bindings: mmc: arm,pl18x: Document interrupt-names property

[Arnd Bergmann]

On Tue, Sep 27, 2022, at 12:41 PM, Marek Vasut wrote:
> Document interrupt-names property with "cmd_irq" interrupt name.
> This fixes dtbs_check warnings when building current Linux DTs:
>
> "
> arch/arm/boot/dts/stm32mp153c-dhcom-drc02.dtb: mmc@58007000: 
> Unevaluated properties are not allowed ('interrupt-names' was 
> unexpected)
> "

I don't think that anything relies on the name here. Should
it just be removed from the dts files then? The name does
not follow the usual conventions with the "_irq" postfix.

     Arnd

Re: [PATCH v2] dt-bindings: mmc: arm,pl18x: Document interrupt-names property

[Linus Walleij]

On Tue, Sep 27, 2022 at 12:41 PM Marek Vasut <marex@denx.de> wrote:

> --- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> +++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> @@ -99,6 +99,9 @@ properties:
>      minItems: 1
>      maxItems: 2
>
> +  interrupt-names:
> +    const: cmd_irq

This hardware come in variants with one or two IRQs.

Either two: "cmd_irq", "data_irq"

Or one combined IRQ (logic OR between those two!)
I don't know what that should be called, perhaps
"cmd_data_irq".

Since all DTS:es then have to be patched an alternative
is as Arnd says to just delete the names. We should however
at the very least patch the bindings description: for the IRQs
to make the above situation clear.

Yours,
Linus Walleij

Re: [PATCH v2] dt-bindings: mmc: arm,pl18x: Document interrupt-names property

[Marek Vasut]

On 9/27/22 14:18, Linus Walleij wrote:
> On Tue, Sep 27, 2022 at 12:41 PM Marek Vasut <marex@denx.de> wrote:
> 
>> --- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
>> @@ -99,6 +99,9 @@ properties:
>>       minItems: 1
>>       maxItems: 2
>>
>> +  interrupt-names:
>> +    const: cmd_irq
> 
> This hardware come in variants with one or two IRQs.
> 
> Either two: "cmd_irq", "data_irq"
> 
> Or one combined IRQ (logic OR between those two!)
> I don't know what that should be called, perhaps
> "cmd_data_irq".
> 
> Since all DTS:es then have to be patched an alternative
> is as Arnd says to just delete the names. We should however
> at the very least patch the bindings description: for the IRQs
> to make the above situation clear.

Done, bindings updated and stm32/qcom DTs cleaned up.