From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, amitk@kernel.org,
thara.gopinath@gmail.com, rafael@kernel.org,
daniel.lezcano@linaro.org, rui.zhang@intel.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Praveenkumar I <quic_ipkumar@quicinc.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: thermal: tsens: Add ipq9574 compatible
Date: Mon, 8 May 2023 08:28:29 +0200 [thread overview]
Message-ID: <cdf26b5b-79d3-3818-1676-4e2be204a0ee@linaro.org> (raw)
In-Reply-To: <345a61f6cd56e504e1f82ac2328ffa6d89e2d510.1683523370.git.quic_varada@quicinc.com>
On 08/05/2023 07:32, Varadarajan Narayanan wrote:
> From: Praveenkumar I <quic_ipkumar@quicinc.com>
>
> Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens.
>
> Acked-by: Rob Herring <robh@kernel.org>
Drop the ack, it's a bigger change.
> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> ---
> [v2]:
> Thanks to Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> for the tip to make qcom,ipq8074-tsens as fallback.
> ---
> Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> index d1ec963..ea67cf9 100644
> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> @@ -64,8 +64,11 @@ properties:
> - const: qcom,tsens-v2
>
> - description: v2 of TSENS with combined interrupt
> - enum:
> - - qcom,ipq8074-tsens
> + - const: qcom,ipq8074-tsens
> + - items:
> + - enum:
Please test the patch after changes and before sending. Missing indent
which test would point out.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-08 6:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 5:32 [PATCH v2 0/3] Enable IPQ9574 TSENS support Varadarajan Narayanan
2023-05-08 5:32 ` [PATCH v2 1/3] dt-bindings: thermal: tsens: Add ipq9574 compatible Varadarajan Narayanan
2023-05-08 6:26 ` Rob Herring
2023-05-08 6:28 ` Krzysztof Kozlowski [this message]
2023-05-08 13:33 ` Krzysztof Kozlowski
2023-05-08 5:32 ` [PATCH v2 2/3] arm64: dts: qcom: ipq9574: add tsens node Varadarajan Narayanan
2023-05-08 11:47 ` Dmitry Baryshkov
2023-05-08 5:32 ` [PATCH v2 3/3] arm64: dts: qcom: ipq9574: add thermal zone nodes Varadarajan Narayanan
2023-05-08 9:00 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdf26b5b-79d3-3818-1676-4e2be204a0ee@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=amitk@kernel.org \
--cc=andersson@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_ipkumar@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).