From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7F71C54EBC for ; Wed, 11 Jan 2023 20:57:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234315AbjAKU56 (ORCPT ); Wed, 11 Jan 2023 15:57:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234213AbjAKU56 (ORCPT ); Wed, 11 Jan 2023 15:57:58 -0500 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71208C16 for ; Wed, 11 Jan 2023 12:57:55 -0800 (PST) Received: by mail-lj1-x233.google.com with SMTP id x37so17317252ljq.1 for ; Wed, 11 Jan 2023 12:57:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=O0xPaw/Uyv/k7eUrz3wz2tQnGPVLOhSDaCGzsFiBw08=; b=PHIrZLjfwQAfYFzBCB3qVyPbnK1UiAST6v9IF2VJ6YKqoAC01RRoqjljm6PRgbRZDd ypU2+ap8fjPZFZe3s8HzwEjsudpvb01z4yudhBAF4KidIwbrCefrHsHfJnYlp76AeMHE 0VKnSp4Lxa+VwFicuaHHWuQBNumLGAAtDqtRyqBeok+kxVXJX95Q/S/BWzYv5J/DjQld Rv3wZBgf4V3QdRSXsVuQ1LVHHq0jFC899VORqneigPbZtC091iHHy1BZ05rSoyVaxT2K zzpsd7gsKdnkck7tMdLoYTLZj6wVxiBlB3kS5/OuR5NYwwBpJwhHMnQNTRWjajhIrrG5 vKrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=O0xPaw/Uyv/k7eUrz3wz2tQnGPVLOhSDaCGzsFiBw08=; b=PGklWXfCoRk2qJOY5F9aQqkN6wQt1PjP0Fg27ZCfRL8NAqZvQbUgJq4RaSyfihiICi r2sohhksNRhH81QNdN4fnfxZIRvXjZn0mNd92vSLEOn5K8oIyrnfJKMBq4SHF1/17Z8X JtBSuufDwSk/PjjR6v42nZUDuJSSGGQ4KJmlE40faidD129B5k18aZc69N3JvwH/Oqda JmIwUx0Mg6a30W/4ENWCLFRuu8Qicec7ZvbsOYXRlUQO+Spw2PnR1Wtc32ijFsjn88ai Yyi3Qxr/x0ccvqKhTVLLClWaCCITAX8z2TN8D0H14/K6kT+DX839tdYFytseLOUS1jdk FLoQ== X-Gm-Message-State: AFqh2kpaiZuRM41ryYVQ7bz9oZag2spnxzMX6ZMWNmiFCDLr/HeKS0RQ Gr/vcwnHDikJO96kwtu7cBs4Ag== X-Google-Smtp-Source: AMrXdXsEzTvPWySwtT0sjwtm3wmAb+qXxyrINFUu3Oi/DvpWybE9NFSsVAgUYtI6XN9ic879EQiMrQ== X-Received: by 2002:a2e:82cd:0:b0:27a:c0f:30be with SMTP id n13-20020a2e82cd000000b0027a0c0f30bemr18932726ljh.35.1673470673802; Wed, 11 Jan 2023 12:57:53 -0800 (PST) Received: from [192.168.1.101] (abym53.neoplus.adsl.tpnet.pl. [83.9.32.53]) by smtp.gmail.com with ESMTPSA id t5-20020a05651c204500b0027ff129de9fsm1889764ljo.24.2023.01.11.12.57.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Jan 2023 12:57:51 -0800 (PST) Message-ID: Date: Wed, 11 Jan 2023 21:57:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 02/13] clk: qcom: cpu-8996: correct PLL programming Content-Language: en-US To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Stephen Boyd , Michael Turquette , Rob Herring , Krzysztof Kozlowski , Taniya Das Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org References: <20230111192004.2509750-1-dmitry.baryshkov@linaro.org> <20230111192004.2509750-3-dmitry.baryshkov@linaro.org> From: Konrad Dybcio In-Reply-To: <20230111192004.2509750-3-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11.01.2023 20:19, Dmitry Baryshkov wrote: > Change PLL programming to follow the downstream setup. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad > drivers/clk/qcom/clk-cpu-8996.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/clk/qcom/clk-cpu-8996.c b/drivers/clk/qcom/clk-cpu-8996.c > index ee76ef958d31..ed8cb558e1aa 100644 > --- a/drivers/clk/qcom/clk-cpu-8996.c > +++ b/drivers/clk/qcom/clk-cpu-8996.c > @@ -93,12 +93,9 @@ static const u8 prim_pll_regs[PLL_OFF_MAX_REGS] = { > static const u8 alt_pll_regs[PLL_OFF_MAX_REGS] = { > [PLL_OFF_L_VAL] = 0x04, > [PLL_OFF_ALPHA_VAL] = 0x08, > - [PLL_OFF_ALPHA_VAL_U] = 0x0c, > [PLL_OFF_USER_CTL] = 0x10, > - [PLL_OFF_USER_CTL_U] = 0x14, > [PLL_OFF_CONFIG_CTL] = 0x18, > [PLL_OFF_TEST_CTL] = 0x20, > - [PLL_OFF_TEST_CTL_U] = 0x24, > [PLL_OFF_STATUS] = 0x28, > }; > > @@ -106,8 +103,10 @@ static const u8 alt_pll_regs[PLL_OFF_MAX_REGS] = { > > static const struct alpha_pll_config hfpll_config = { > .l = 60, > - .config_ctl_val = 0x200d4aa8, > + .config_ctl_val = 0x200d4828, > .config_ctl_hi_val = 0x006, > + .test_ctl_val = 0x1c000000, > + .test_ctl_hi_val = 0x00004000, > .pre_div_mask = BIT(12), > .post_div_mask = 0x3 << 8, > .post_div_val = 0x1 << 8,