From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Hawa, Hanna" Subject: Re: [PATCH 2/2] edac: add support for Amazon's Annapurna Labs EDAC Date: Thu, 6 Jun 2019 10:53:42 +0300 Message-ID: References: <1559211329-13098-1-git-send-email-hhhawa@amazon.com> <1559211329-13098-3-git-send-email-hhhawa@amazon.com> <20190531051400.GA2275@cz.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190531051400.GA2275@cz.tnic> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Borislav Petkov , "Herrenschmidt, Benjamin" , "james.morse@arm.com" Cc: "robh+dt@kernel.org" , "Woodhouse, David" , "paulmck@linux.ibm.com" , "mchehab@kernel.org" , "mark.rutland@arm.com" , "gregkh@linuxfoundation.org" , "davem@davemloft.net" , "nicolas.ferre@microchip.com" , "devicetree@vger.kernel.org" , "Shenhar, Talel" , "linux-kernel@vger.kernel.org" , "Chocron, Jonathan" , "Krupnik, Ronen" , "linux-edac@vger.kernel.org" , "Hanoch, Uri" List-Id: devicetree@vger.kernel.org On 5/31/2019 8:14 AM, Borislav Petkov wrote: > On Fri, May 31, 2019 at 01:15:33AM +0000, Herrenschmidt, Benjamin wrote: >> This isn't terribly helpful, there's nothing telling anybody which of >> those files corresponds to an ARM SoC :-) > > drivers/edac/altera_edac.c is one example. > > Also, James and I have a small writeup on how an arm driver should look > like, we just need to polish it up and post it. > > James? > >> That said ... >> >> You really want a single EDAC driver that contains all the stuff for >> the caches, the memory controller, etc... ? > > Yap. Disagree. The various drivers don't depend on each other. I think we should keep the drivers separated as they are distinct and independent IP blocks. >