* [PATCH v4 01/12] dt-bindings: mtd: brcmnand: Updates for bcmbca SoCs
2024-02-03 0:28 [PATCH v4 00/12] dt-bindings: mtd: brcmnand: Updates for bcmbca SoCs William Zhang
@ 2024-02-03 0:28 ` William Zhang
2024-02-05 18:53 ` Rob Herring
2024-02-03 0:28 ` [PATCH v4 02/12] dt-bindings: mtd: brcmnand: Add WP pin connection property William Zhang
` (4 subsequent siblings)
5 siblings, 1 reply; 17+ messages in thread
From: William Zhang @ 2024-02-03 0:28 UTC (permalink / raw)
To: Linux MTD List, Linux ARM List, Broadcom Kernel List
Cc: f.fainelli, kursad.oney, joel.peshkin, anand.gore, dregan,
kamal.dasu, tomer.yacoby, dan.beygelman, William Zhang,
David Regan, devicetree, Brian Norris, linux-kernel, Conor Dooley,
Krzysztof Kozlowski, Vignesh Raghavendra, Miquel Raynal,
Richard Weinberger, Kamal Dasu, Rob Herring
Update the descriptions to reflect different families of broadband SoC and
use the general name bcmbca for ARM based SoC.
Remove the requirement of interrupts property to reflect the driver
code and only require interrupt-names when interrupts property present.
Also add myself to the list of maintainers.
Signed-off-by: William Zhang <william.zhang@broadcom.com>
Reviewed-by: David Regan <dregan@broadcom.com>
---
Changes in v4:
- Split the yaml changes into three patches. This is the first one.
Changes in v3:
- Update brcm,nand-use-wp description
- Revert the description change to BCM63168 SoC-specific NAND controller
Changes in v2:
- Revert the new compatible string nand-bcmbca
- Drop the BCM63168 compatible fix to avoid any potential ABI
incompatibility issue
- Simplify the explanation for brcm,nand-use-wp
- Keep the interrupt name requirement when interrupt number is specified
.../devicetree/bindings/mtd/brcm,brcmnand.yaml | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
index f57e96374e67..e54ca08a798a 100644
--- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
+++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
@@ -9,6 +9,7 @@ title: Broadcom STB NAND Controller
maintainers:
- Brian Norris <computersforpeace@gmail.com>
- Kamal Dasu <kdasu.kdev@gmail.com>
+ - William Zhang <william.zhang@broadcom.com>
description: |
The Broadcom Set-Top Box NAND controller supports low-level access to raw NAND
@@ -18,9 +19,10 @@ description: |
supports basic PROGRAM and READ functions, among other features.
This controller was originally designed for STB SoCs (BCM7xxx) but is now
- available on a variety of Broadcom SoCs, including some BCM3xxx, BCM63xx, and
- iProc/Cygnus. Its history includes several similar (but not fully register
- compatible) versions.
+ available on a variety of Broadcom SoCs, including some BCM3xxx, MIPS based
+ Broadband SoC (BCM63xx), ARM based Broadband SoC (BCMBCA) and iProc/Cygnus.
+ Its history includes several similar (but not fully register compatible)
+ versions.
-- Additional SoC-specific NAND controller properties --
@@ -53,7 +55,7 @@ properties:
- brcm,brcmnand-v7.2
- brcm,brcmnand-v7.3
- const: brcm,brcmnand
- - description: BCM63138 SoC-specific NAND controller
+ - description: BCMBCA SoC-specific NAND controller
items:
- const: brcm,nand-bcm63138
- enum:
@@ -177,6 +179,8 @@ allOf:
- const: iproc-idm
- const: iproc-ext
- if:
+ required:
+ - interrupts
properties:
interrupts:
minItems: 2
@@ -189,7 +193,6 @@ unevaluatedProperties: false
required:
- reg
- reg-names
- - interrupts
examples:
- |
--
2.37.3
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH v4 01/12] dt-bindings: mtd: brcmnand: Updates for bcmbca SoCs
2024-02-03 0:28 ` [PATCH v4 01/12] " William Zhang
@ 2024-02-05 18:53 ` Rob Herring
0 siblings, 0 replies; 17+ messages in thread
From: Rob Herring @ 2024-02-05 18:53 UTC (permalink / raw)
To: William Zhang
Cc: Linux MTD List, Linux ARM List, Broadcom Kernel List, f.fainelli,
kursad.oney, joel.peshkin, anand.gore, dregan, kamal.dasu,
tomer.yacoby, dan.beygelman, David Regan, devicetree,
Brian Norris, linux-kernel, Conor Dooley, Krzysztof Kozlowski,
Vignesh Raghavendra, Miquel Raynal, Richard Weinberger,
Kamal Dasu
On Fri, Feb 02, 2024 at 04:28:22PM -0800, William Zhang wrote:
> Update the descriptions to reflect different families of broadband SoC and
> use the general name bcmbca for ARM based SoC.
>
> Remove the requirement of interrupts property to reflect the driver
> code and only require interrupt-names when interrupts property present.
>
> Also add myself to the list of maintainers.
>
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
> Reviewed-by: David Regan <dregan@broadcom.com>
>
> ---
>
> Changes in v4:
> - Split the yaml changes into three patches. This is the first one.
>
> Changes in v3:
> - Update brcm,nand-use-wp description
> - Revert the description change to BCM63168 SoC-specific NAND controller
>
> Changes in v2:
> - Revert the new compatible string nand-bcmbca
> - Drop the BCM63168 compatible fix to avoid any potential ABI
> incompatibility issue
> - Simplify the explanation for brcm,nand-use-wp
> - Keep the interrupt name requirement when interrupt number is specified
>
> .../devicetree/bindings/mtd/brcm,brcmnand.yaml | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v4 02/12] dt-bindings: mtd: brcmnand: Add WP pin connection property
2024-02-03 0:28 [PATCH v4 00/12] dt-bindings: mtd: brcmnand: Updates for bcmbca SoCs William Zhang
2024-02-03 0:28 ` [PATCH v4 01/12] " William Zhang
@ 2024-02-03 0:28 ` William Zhang
2024-02-03 14:51 ` Conor Dooley
2024-02-05 13:32 ` Miquel Raynal
2024-02-03 0:28 ` [PATCH v4 03/12] dt-bindings: mtd: brcmnand: Add ecc strap property William Zhang
` (3 subsequent siblings)
5 siblings, 2 replies; 17+ messages in thread
From: William Zhang @ 2024-02-03 0:28 UTC (permalink / raw)
To: Linux MTD List, Linux ARM List, Broadcom Kernel List
Cc: f.fainelli, kursad.oney, joel.peshkin, anand.gore, dregan,
kamal.dasu, tomer.yacoby, dan.beygelman, William Zhang,
devicetree, Brian Norris, linux-kernel, Conor Dooley,
Krzysztof Kozlowski, Vignesh Raghavendra, Miquel Raynal,
Richard Weinberger, Kamal Dasu, Rob Herring
Add brcm,wp-not-connected property to have an option for disabling this
feature on broadband board design that does not connect WP pin.
Signed-off-by: William Zhang <william.zhang@broadcom.com>
---
Changes in v4:
- Move the WP pin property to this separate patch and change it to
boolean type.
Changes in v3: None
Changes in v2: None
Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
index e54ca08a798a..d0168d55c73e 100644
--- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
+++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
@@ -113,6 +113,14 @@ properties:
earlier versions of this core that include WP
type: boolean
+ brcm,wp-not-connected:
+ description:
+ Use this property when board design does not connect controller's
+ NAND_WPb pin to NAND chip's WP_L pin and disable the write
+ protection feature. By default, controller assumes the pin is
+ connected and feature is used.
+ $ref: /schemas/types.yaml#/definitions/flag
+
patternProperties:
"^nand@[a-f0-9]$":
type: object
--
2.37.3
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH v4 02/12] dt-bindings: mtd: brcmnand: Add WP pin connection property
2024-02-03 0:28 ` [PATCH v4 02/12] dt-bindings: mtd: brcmnand: Add WP pin connection property William Zhang
@ 2024-02-03 14:51 ` Conor Dooley
2024-02-05 13:32 ` Miquel Raynal
1 sibling, 0 replies; 17+ messages in thread
From: Conor Dooley @ 2024-02-03 14:51 UTC (permalink / raw)
To: William Zhang
Cc: Linux MTD List, Linux ARM List, Broadcom Kernel List, f.fainelli,
kursad.oney, joel.peshkin, anand.gore, dregan, kamal.dasu,
tomer.yacoby, dan.beygelman, devicetree, Brian Norris,
linux-kernel, Conor Dooley, Krzysztof Kozlowski,
Vignesh Raghavendra, Miquel Raynal, Richard Weinberger,
Kamal Dasu, Rob Herring
[-- Attachment #1: Type: text/plain, Size: 348 bytes --]
On Fri, Feb 02, 2024 at 04:28:23PM -0800, William Zhang wrote:
> Add brcm,wp-not-connected property to have an option for disabling this
> feature on broadband board design that does not connect WP pin.
>
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v4 02/12] dt-bindings: mtd: brcmnand: Add WP pin connection property
2024-02-03 0:28 ` [PATCH v4 02/12] dt-bindings: mtd: brcmnand: Add WP pin connection property William Zhang
2024-02-03 14:51 ` Conor Dooley
@ 2024-02-05 13:32 ` Miquel Raynal
2024-02-05 18:06 ` William Zhang
1 sibling, 1 reply; 17+ messages in thread
From: Miquel Raynal @ 2024-02-05 13:32 UTC (permalink / raw)
To: William Zhang
Cc: Linux MTD List, Linux ARM List, Broadcom Kernel List, f.fainelli,
kursad.oney, joel.peshkin, anand.gore, dregan, kamal.dasu,
tomer.yacoby, dan.beygelman, devicetree, Brian Norris,
linux-kernel, Conor Dooley, Krzysztof Kozlowski,
Vignesh Raghavendra, Richard Weinberger, Kamal Dasu, Rob Herring
Hi William,
william.zhang@broadcom.com wrote on Fri, 2 Feb 2024 16:28:23 -0800:
> Add brcm,wp-not-connected property to have an option for disabling this
> feature on broadband board design that does not connect WP pin.
>
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
>
> ---
>
> Changes in v4:
> - Move the WP pin property to this separate patch and change it to
> boolean type.
>
> Changes in v3: None
> Changes in v2: None
>
> Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
> index e54ca08a798a..d0168d55c73e 100644
> --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
> +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
> @@ -113,6 +113,14 @@ properties:
> earlier versions of this core that include WP
> type: boolean
>
> + brcm,wp-not-connected:
> + description:
> + Use this property when board design does not connect controller's
> + NAND_WPb pin to NAND chip's WP_L pin and disable the write
> + protection feature. By default, controller assumes the pin is
> + connected and feature is used.
I would rephrase slightly. What about:
WP pin is not physically wired to the NAND chip. Write
protection feature cannot be used.
> + $ref: /schemas/types.yaml#/definitions/flag
> +
> patternProperties:
> "^nand@[a-f0-9]$":
> type: object
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v4 02/12] dt-bindings: mtd: brcmnand: Add WP pin connection property
2024-02-05 13:32 ` Miquel Raynal
@ 2024-02-05 18:06 ` William Zhang
0 siblings, 0 replies; 17+ messages in thread
From: William Zhang @ 2024-02-05 18:06 UTC (permalink / raw)
To: Miquel Raynal
Cc: Linux MTD List, Linux ARM List, Broadcom Kernel List, f.fainelli,
kursad.oney, joel.peshkin, anand.gore, dregan, kamal.dasu,
tomer.yacoby, dan.beygelman, devicetree, Brian Norris,
linux-kernel, Conor Dooley, Krzysztof Kozlowski,
Vignesh Raghavendra, Richard Weinberger, Kamal Dasu, Rob Herring
[-- Attachment #1: Type: text/plain, Size: 1700 bytes --]
On 2/5/24 05:32, Miquel Raynal wrote:
> Hi William,
>
> william.zhang@broadcom.com wrote on Fri, 2 Feb 2024 16:28:23 -0800:
>
>> Add brcm,wp-not-connected property to have an option for disabling this
>> feature on broadband board design that does not connect WP pin.
>>
>> Signed-off-by: William Zhang <william.zhang@broadcom.com>
>>
>> ---
>>
>> Changes in v4:
>> - Move the WP pin property to this separate patch and change it to
>> boolean type.
>>
>> Changes in v3: None
>> Changes in v2: None
>>
>> Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
>> index e54ca08a798a..d0168d55c73e 100644
>> --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
>> +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
>> @@ -113,6 +113,14 @@ properties:
>> earlier versions of this core that include WP
>> type: boolean
>>
>> + brcm,wp-not-connected:
>> + description:
>> + Use this property when board design does not connect controller's
>> + NAND_WPb pin to NAND chip's WP_L pin and disable the write
>> + protection feature. By default, controller assumes the pin is
>> + connected and feature is used.
>
> I would rephrase slightly. What about:
>
> WP pin is not physically wired to the NAND chip. Write
> protection feature cannot be used.
>
That's fine with me. Will update.
>> + $ref: /schemas/types.yaml#/definitions/flag
>> +
>> patternProperties:
>> "^nand@[a-f0-9]$":
>> type: object
>
>
> Thanks,
> Miquèl
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v4 03/12] dt-bindings: mtd: brcmnand: Add ecc strap property
2024-02-03 0:28 [PATCH v4 00/12] dt-bindings: mtd: brcmnand: Updates for bcmbca SoCs William Zhang
2024-02-03 0:28 ` [PATCH v4 01/12] " William Zhang
2024-02-03 0:28 ` [PATCH v4 02/12] dt-bindings: mtd: brcmnand: Add WP pin connection property William Zhang
@ 2024-02-03 0:28 ` William Zhang
2024-02-03 14:49 ` Conor Dooley
2024-02-03 0:28 ` [PATCH v4 04/12] ARM: dts: broadcom: bcmbca: Add NAND controller node William Zhang
` (2 subsequent siblings)
5 siblings, 1 reply; 17+ messages in thread
From: William Zhang @ 2024-02-03 0:28 UTC (permalink / raw)
To: Linux MTD List, Linux ARM List, Broadcom Kernel List
Cc: f.fainelli, kursad.oney, joel.peshkin, anand.gore, dregan,
kamal.dasu, tomer.yacoby, dan.beygelman, William Zhang,
devicetree, Brian Norris, linux-kernel, Conor Dooley,
Krzysztof Kozlowski, Vignesh Raghavendra, Miquel Raynal,
Richard Weinberger, Kamal Dasu, Rob Herring
Add brcm,nand-ecc-use-strap to get ecc and spare area size settings from
board boot strap for broadband board designs because they do not specify
ecc setting in dts but rather using the strap setting.
Signed-off-by: William Zhang <william.zhang@broadcom.com>
---
Changes in v4:
- Move ecc strap property to this separate patch and remove some
non-binding related text from the description
Changes in v3: None
Changes in v2: None
Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
index d0168d55c73e..2599d902ec3a 100644
--- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
+++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
@@ -147,6 +147,14 @@ patternProperties:
layout.
$ref: /schemas/types.yaml#/definitions/uint32
+ brcm,nand-ecc-use-strap:
+ description:
+ This flag indicates the ecc strength and spare area size should
+ be retrieved from the SoC NAND boot strap setting instead of
+ nand-ecc-strength and brcm,nand-oob-sector-size or auto detection.
+ This is commonly used by the BCMBCA SoC board design.
+ $ref: /schemas/types.yaml#/definitions/flag
+
unevaluatedProperties: false
allOf:
--
2.37.3
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH v4 03/12] dt-bindings: mtd: brcmnand: Add ecc strap property
2024-02-03 0:28 ` [PATCH v4 03/12] dt-bindings: mtd: brcmnand: Add ecc strap property William Zhang
@ 2024-02-03 14:49 ` Conor Dooley
2024-02-04 21:56 ` William Zhang
2024-02-05 13:26 ` Miquel Raynal
0 siblings, 2 replies; 17+ messages in thread
From: Conor Dooley @ 2024-02-03 14:49 UTC (permalink / raw)
To: William Zhang
Cc: Linux MTD List, Linux ARM List, Broadcom Kernel List, f.fainelli,
kursad.oney, joel.peshkin, anand.gore, dregan, kamal.dasu,
tomer.yacoby, dan.beygelman, devicetree, Brian Norris,
linux-kernel, Conor Dooley, Krzysztof Kozlowski,
Vignesh Raghavendra, Miquel Raynal, Richard Weinberger,
Kamal Dasu, Rob Herring
[-- Attachment #1: Type: text/plain, Size: 1858 bytes --]
On Fri, Feb 02, 2024 at 04:28:24PM -0800, William Zhang wrote:
> Add brcm,nand-ecc-use-strap to get ecc and spare area size settings from
> board boot strap for broadband board designs because they do not specify
> ecc setting in dts but rather using the strap setting.
>
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
>
> ---
>
> Changes in v4:
> - Move ecc strap property to this separate patch and remove some
> non-binding related text from the description
>
> Changes in v3: None
> Changes in v2: None
>
> Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
> index d0168d55c73e..2599d902ec3a 100644
> --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
> +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
> @@ -147,6 +147,14 @@ patternProperties:
> layout.
> $ref: /schemas/types.yaml#/definitions/uint32
>
> + brcm,nand-ecc-use-strap:
> + description:
> + This flag indicates the ecc strength and spare area size should
> + be retrieved from the SoC NAND boot strap setting instead of
> + nand-ecc-strength and brcm,nand-oob-sector-size or auto detection.
I'm still on the fence about this being overly prescriptive about the
operating systems behaviour. I think it would be good to say why the
strap values are better than those explicitly provided in DT rather than
just saying "these strap values should be used".
> + This is commonly used by the BCMBCA SoC board design.
> + $ref: /schemas/types.yaml#/definitions/flag
> +
> unevaluatedProperties: false
>
> allOf:
> --
> 2.37.3
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v4 03/12] dt-bindings: mtd: brcmnand: Add ecc strap property
2024-02-03 14:49 ` Conor Dooley
@ 2024-02-04 21:56 ` William Zhang
2024-02-05 13:26 ` Miquel Raynal
1 sibling, 0 replies; 17+ messages in thread
From: William Zhang @ 2024-02-04 21:56 UTC (permalink / raw)
To: Conor Dooley
Cc: Linux MTD List, Linux ARM List, Broadcom Kernel List, f.fainelli,
kursad.oney, joel.peshkin, anand.gore, dregan, kamal.dasu,
tomer.yacoby, dan.beygelman, devicetree, Brian Norris,
linux-kernel, Conor Dooley, Krzysztof Kozlowski,
Vignesh Raghavendra, Miquel Raynal, Richard Weinberger,
Kamal Dasu, Rob Herring
[-- Attachment #1: Type: text/plain, Size: 2334 bytes --]
On 2/3/24 06:49, Conor Dooley wrote:
> On Fri, Feb 02, 2024 at 04:28:24PM -0800, William Zhang wrote:
>> Add brcm,nand-ecc-use-strap to get ecc and spare area size settings from
>> board boot strap for broadband board designs because they do not specify
>> ecc setting in dts but rather using the strap setting.
>>
>> Signed-off-by: William Zhang <william.zhang@broadcom.com>
>>
>> ---
>>
>> Changes in v4:
>> - Move ecc strap property to this separate patch and remove some
>> non-binding related text from the description
>>
>> Changes in v3: None
>> Changes in v2: None
>>
>> Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
>> index d0168d55c73e..2599d902ec3a 100644
>> --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
>> +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
>> @@ -147,6 +147,14 @@ patternProperties:
>> layout.
>> $ref: /schemas/types.yaml#/definitions/uint32
>>
>> + brcm,nand-ecc-use-strap:
>> + description:
>> + This flag indicates the ecc strength and spare area size should
>> + be retrieved from the SoC NAND boot strap setting instead of
>> + nand-ecc-strength and brcm,nand-oob-sector-size or auto detection.
>
> I'm still on the fence about this being overly prescriptive about the
> operating systems behaviour. I think it would be good to say why the
> strap values are better than those explicitly provided in DT rather than
> just saying "these strap values should be used".
>
This is a board/SoC design choice. I wouldn't advise it as better
choice as other board/SoC may not have that option. But definitively for
BCMBCA SoC board design, it is better and much easier and convenient
option than explicit dt setting. How about: This property provides a
choice for retrieving ecc strength and spare area size from the SoC NAND
boot strap setting. It is commonly used by the BCMBCA SoC board design.
>> + This is commonly used by the BCMBCA SoC board design.
>> + $ref: /schemas/types.yaml#/definitions/flag
>> +
>> unevaluatedProperties: false
>>
>> allOf:
>> --
>> 2.37.3
>>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v4 03/12] dt-bindings: mtd: brcmnand: Add ecc strap property
2024-02-03 14:49 ` Conor Dooley
2024-02-04 21:56 ` William Zhang
@ 2024-02-05 13:26 ` Miquel Raynal
2024-02-05 18:05 ` William Zhang
1 sibling, 1 reply; 17+ messages in thread
From: Miquel Raynal @ 2024-02-05 13:26 UTC (permalink / raw)
To: Conor Dooley
Cc: William Zhang, Linux MTD List, Linux ARM List,
Broadcom Kernel List, f.fainelli, kursad.oney, joel.peshkin,
anand.gore, dregan, kamal.dasu, tomer.yacoby, dan.beygelman,
devicetree, Brian Norris, linux-kernel, Conor Dooley,
Krzysztof Kozlowski, Vignesh Raghavendra, Richard Weinberger,
Kamal Dasu, Rob Herring
Hi,
conor@kernel.org wrote on Sat, 3 Feb 2024 14:49:50 +0000:
> On Fri, Feb 02, 2024 at 04:28:24PM -0800, William Zhang wrote:
> > Add brcm,nand-ecc-use-strap to get ecc and spare area size settings from
> > board boot strap for broadband board designs because they do not specify
> > ecc setting in dts but rather using the strap setting.
> >
> > Signed-off-by: William Zhang <william.zhang@broadcom.com>
> >
> > ---
> >
> > Changes in v4:
> > - Move ecc strap property to this separate patch and remove some
> > non-binding related text from the description
> >
> > Changes in v3: None
> > Changes in v2: None
> >
> > Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
> > index d0168d55c73e..2599d902ec3a 100644
> > --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
> > +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
> > @@ -147,6 +147,14 @@ patternProperties:
> > layout.
> > $ref: /schemas/types.yaml#/definitions/uint32
> >
> > + brcm,nand-ecc-use-strap:
> > + description:
> > + This flag indicates the ecc strength and spare area size should
> > + be retrieved from the SoC NAND boot strap setting instead of
> > + nand-ecc-strength and brcm,nand-oob-sector-size or auto detection.
>
> I'm still on the fence about this being overly prescriptive about the
> operating systems behaviour. I think it would be good to say why the
> strap values are better than those explicitly provided in DT rather than
> just saying "these strap values should be used".
I don't know if there is a point is saying why they would be better, as
they are not. It is a -questionable- design choice. However I would
just get rid of any mention to other properties. Just say one should
expect the strap value to be read and applied by the system when this
property is present.
> > + This is commonly used by the BCMBCA SoC board design.
> > + $ref: /schemas/types.yaml#/definitions/flag
> > +
> > unevaluatedProperties: false
> >
> > allOf:
> > --
> > 2.37.3
> >
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v4 03/12] dt-bindings: mtd: brcmnand: Add ecc strap property
2024-02-05 13:26 ` Miquel Raynal
@ 2024-02-05 18:05 ` William Zhang
2024-02-06 9:34 ` Miquel Raynal
0 siblings, 1 reply; 17+ messages in thread
From: William Zhang @ 2024-02-05 18:05 UTC (permalink / raw)
To: Miquel Raynal, Conor Dooley
Cc: Linux MTD List, Linux ARM List, Broadcom Kernel List, f.fainelli,
kursad.oney, joel.peshkin, anand.gore, dregan, kamal.dasu,
tomer.yacoby, dan.beygelman, devicetree, Brian Norris,
linux-kernel, Conor Dooley, Krzysztof Kozlowski,
Vignesh Raghavendra, Richard Weinberger, Kamal Dasu, Rob Herring
[-- Attachment #1: Type: text/plain, Size: 2919 bytes --]
Hi Miquel,
On 2/5/24 05:26, Miquel Raynal wrote:
> Hi,
>
> conor@kernel.org wrote on Sat, 3 Feb 2024 14:49:50 +0000:
>
>> On Fri, Feb 02, 2024 at 04:28:24PM -0800, William Zhang wrote:
>>> Add brcm,nand-ecc-use-strap to get ecc and spare area size settings from
>>> board boot strap for broadband board designs because they do not specify
>>> ecc setting in dts but rather using the strap setting.
>>>
>>> Signed-off-by: William Zhang <william.zhang@broadcom.com>
>>>
>>> ---
>>>
>>> Changes in v4:
>>> - Move ecc strap property to this separate patch and remove some
>>> non-binding related text from the description
>>>
>>> Changes in v3: None
>>> Changes in v2: None
>>>
>>> Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
>>> index d0168d55c73e..2599d902ec3a 100644
>>> --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
>>> +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
>>> @@ -147,6 +147,14 @@ patternProperties:
>>> layout.
>>> $ref: /schemas/types.yaml#/definitions/uint32
>>>
>>> + brcm,nand-ecc-use-strap:
>>> + description:
>>> + This flag indicates the ecc strength and spare area size should
>>> + be retrieved from the SoC NAND boot strap setting instead of
>>> + nand-ecc-strength and brcm,nand-oob-sector-size or auto detection.
>>
>> I'm still on the fence about this being overly prescriptive about the
>> operating systems behaviour. I think it would be good to say why the
>> strap values are better than those explicitly provided in DT rather than
>> just saying "these strap values should be used".
>
> I don't know if there is a point is saying why they would be better, as
> they are not. It is a -questionable- design choice. However I would
> just get rid of any mention to other properties. Just say one should
> expect the strap value to be read and applied by the system when this
> property is present.
>
Agree we don't need to say which is better as it is just a design
choice. And it is used by all BCMBCA internal ref boards and customer
designs. But if we just say strap value is read and applied, it is vague
and nobody would know what is applied. I replied this email yesterday
and suggest the followings:
This property provides a choice for retrieving ecc strength and spare
area size from the SoC NAND boot strap setting. It is commonly used by
the BCMBCA SoC board design.
Hope this make everyone happy and we can move forward.
>>> + This is commonly used by the BCMBCA SoC board design.
>>> + $ref: /schemas/types.yaml#/definitions/flag
>>> +
>>> unevaluatedProperties: false
>>>
>>> allOf:
>>> --
>>> 2.37.3
>>>
>
>
> Thanks,
> Miquèl
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v4 03/12] dt-bindings: mtd: brcmnand: Add ecc strap property
2024-02-05 18:05 ` William Zhang
@ 2024-02-06 9:34 ` Miquel Raynal
2024-02-07 2:21 ` William Zhang
0 siblings, 1 reply; 17+ messages in thread
From: Miquel Raynal @ 2024-02-06 9:34 UTC (permalink / raw)
To: William Zhang
Cc: Conor Dooley, Linux MTD List, Linux ARM List,
Broadcom Kernel List, f.fainelli, kursad.oney, joel.peshkin,
anand.gore, dregan, kamal.dasu, tomer.yacoby, dan.beygelman,
devicetree, Brian Norris, linux-kernel, Conor Dooley,
Krzysztof Kozlowski, Vignesh Raghavendra, Richard Weinberger,
Kamal Dasu, Rob Herring
Hi William,
william.zhang@broadcom.com wrote on Mon, 5 Feb 2024 10:05:14 -0800:
> Hi Miquel,
>
> On 2/5/24 05:26, Miquel Raynal wrote:
> > Hi,
> >
> > conor@kernel.org wrote on Sat, 3 Feb 2024 14:49:50 +0000:
> >
> >> On Fri, Feb 02, 2024 at 04:28:24PM -0800, William Zhang wrote:
> >>> Add brcm,nand-ecc-use-strap to get ecc and spare area size settings from
> >>> board boot strap for broadband board designs because they do not specify
> >>> ecc setting in dts but rather using the strap setting.
> >>>
> >>> Signed-off-by: William Zhang <william.zhang@broadcom.com>
> >>>
> >>> ---
> >>>
> >>> Changes in v4:
> >>> - Move ecc strap property to this separate patch and remove some
> >>> non-binding related text from the description
> >>>
> >>> Changes in v3: None
> >>> Changes in v2: None
> >>>
> >>> Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml | 8 ++++++++
> >>> 1 file changed, 8 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
> >>> index d0168d55c73e..2599d902ec3a 100644
> >>> --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
> >>> +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
> >>> @@ -147,6 +147,14 @@ patternProperties:
> >>> layout.
> >>> $ref: /schemas/types.yaml#/definitions/uint32
> >>> >>> + brcm,nand-ecc-use-strap:
> >>> + description:
> >>> + This flag indicates the ecc strength and spare area size should
> >>> + be retrieved from the SoC NAND boot strap setting instead of
> >>> + nand-ecc-strength and brcm,nand-oob-sector-size or auto detection.
> >>
> >> I'm still on the fence about this being overly prescriptive about the
> >> operating systems behaviour. I think it would be good to say why the
> >> strap values are better than those explicitly provided in DT rather than
> >> just saying "these strap values should be used".
> >
> > I don't know if there is a point is saying why they would be better, as
> > they are not. It is a -questionable- design choice. However I would
> > just get rid of any mention to other properties. Just say one should
> > expect the strap value to be read and applied by the system when this
> > property is present.
> >
> Agree we don't need to say which is better as it is just a design choice. And it is used by all BCMBCA internal ref boards and customer designs. But if we just say strap value is read and applied, it is vague and nobody would know what is applied. I replied this email yesterday and suggest the followings:
>
> This property provides a choice for retrieving ecc strength and spare area size from
the SoC NAND boot strap setting. It is commonly used by the BCMBCA SoC board design.
What about:
This property requires the host system to get the ECC strength and step
size from the SoC NAND boot strap setting. This is a common hardware
design on BCMBCA based boards.
I would also like to constrain this more by adding an exclusive use wrt
the nand-ecc-* properties. So either you put this property, or you put
the generic nand-ecc-* properties, or you put nothing (which, again, is
by far the best solution), but in no case you can have a mix.
>
> Hope this make everyone happy and we can move forward.
I was advising to avoid mentioning too specific DT properties, but
mentioning the kind of impact it has (on the choice for the ECC
strength and size) is fine.
>
>
> >>> + This is commonly used by the BCMBCA SoC board design.
> >>> + $ref: /schemas/types.yaml#/definitions/flag
> >>> +
> >>> unevaluatedProperties: false
> >>> >>> allOf:
> >>> -- >>> 2.37.3
> >>> > >
> > Thanks,
> > Miquèl
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v4 03/12] dt-bindings: mtd: brcmnand: Add ecc strap property
2024-02-06 9:34 ` Miquel Raynal
@ 2024-02-07 2:21 ` William Zhang
0 siblings, 0 replies; 17+ messages in thread
From: William Zhang @ 2024-02-07 2:21 UTC (permalink / raw)
To: Miquel Raynal
Cc: Conor Dooley, Linux MTD List, Linux ARM List,
Broadcom Kernel List, f.fainelli, kursad.oney, joel.peshkin,
anand.gore, dregan, kamal.dasu, tomer.yacoby, dan.beygelman,
devicetree, Brian Norris, linux-kernel, Conor Dooley,
Krzysztof Kozlowski, Vignesh Raghavendra, Richard Weinberger,
Kamal Dasu, Rob Herring
[-- Attachment #1: Type: text/plain, Size: 4159 bytes --]
On 2/6/24 01:34, Miquel Raynal wrote:
> Hi William,
>
> william.zhang@broadcom.com wrote on Mon, 5 Feb 2024 10:05:14 -0800:
>
>> Hi Miquel,
>>
>> On 2/5/24 05:26, Miquel Raynal wrote:
>>> Hi,
>>>
>>> conor@kernel.org wrote on Sat, 3 Feb 2024 14:49:50 +0000:
>>>
>>>> On Fri, Feb 02, 2024 at 04:28:24PM -0800, William Zhang wrote:
>>>>> Add brcm,nand-ecc-use-strap to get ecc and spare area size settings from
>>>>> board boot strap for broadband board designs because they do not specify
>>>>> ecc setting in dts but rather using the strap setting.
>>>>>
>>>>> Signed-off-by: William Zhang <william.zhang@broadcom.com>
>>>>>
>>>>> ---
>>>>>
>>>>> Changes in v4:
>>>>> - Move ecc strap property to this separate patch and remove some
>>>>> non-binding related text from the description
>>>>>
>>>>> Changes in v3: None
>>>>> Changes in v2: None
>>>>>
>>>>> Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml | 8 ++++++++
>>>>> 1 file changed, 8 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
>>>>> index d0168d55c73e..2599d902ec3a 100644
>>>>> --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
>>>>> +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
>>>>> @@ -147,6 +147,14 @@ patternProperties:
>>>>> layout.
>>>>> $ref: /schemas/types.yaml#/definitions/uint32
>>>>> >>> + brcm,nand-ecc-use-strap:
>>>>> + description:
>>>>> + This flag indicates the ecc strength and spare area size should
>>>>> + be retrieved from the SoC NAND boot strap setting instead of
>>>>> + nand-ecc-strength and brcm,nand-oob-sector-size or auto detection.
>>>>
>>>> I'm still on the fence about this being overly prescriptive about the
>>>> operating systems behaviour. I think it would be good to say why the
>>>> strap values are better than those explicitly provided in DT rather than
>>>> just saying "these strap values should be used".
>>>
>>> I don't know if there is a point is saying why they would be better, as
>>> they are not. It is a -questionable- design choice. However I would
>>> just get rid of any mention to other properties. Just say one should
>>> expect the strap value to be read and applied by the system when this
>>> property is present.
>>>
>> Agree we don't need to say which is better as it is just a design choice. And it is used by all BCMBCA internal ref boards and customer designs. But if we just say strap value is read and applied, it is vague and nobody would know what is applied. I replied this email yesterday and suggest the followings:
>>
>> This property provides a choice for retrieving ecc strength and spare area size from
> the SoC NAND boot strap setting. It is commonly used by the BCMBCA SoC board design.
>
> What about:
>
> This property requires the host system to get the ECC strength and step
> size from the SoC NAND boot strap setting. This is a common hardware
> design on BCMBCA based boards.
>
Sounds good. Will update.
> I would also like to constrain this more by adding an exclusive use wrt
> the nand-ecc-* properties. So either you put this property, or you put
> the generic nand-ecc-* properties, or you put nothing (which, again, is
> by far the best solution), but in no case you can have a mix.
>
Right, nobody should have a mix but in case it happens, the driver code
handles that well by taking nand-ecc-* property. So not sure if the
exclusion check is really important. Anyway I will add a condition check
in the yaml on them as you requested.
>>
>> Hope this make everyone happy and we can move forward.
>
> I was advising to avoid mentioning too specific DT properties, but
> mentioning the kind of impact it has (on the choice for the ECC
> strength and size) is fine.
>
>>
>>
>>>>> + This is commonly used by the BCMBCA SoC board design.
>>>>> + $ref: /schemas/types.yaml#/definitions/flag
>>>>> +
>>>>> unevaluatedProperties: false
>>>>> >>> allOf:
>>>>> -- >>> 2.37.3
>>>>> > >
>>> Thanks,
>>> Miquèl
>
>
> Thanks,
> Miquèl
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v4 04/12] ARM: dts: broadcom: bcmbca: Add NAND controller node
2024-02-03 0:28 [PATCH v4 00/12] dt-bindings: mtd: brcmnand: Updates for bcmbca SoCs William Zhang
` (2 preceding siblings ...)
2024-02-03 0:28 ` [PATCH v4 03/12] dt-bindings: mtd: brcmnand: Add ecc strap property William Zhang
@ 2024-02-03 0:28 ` William Zhang
2024-02-03 0:28 ` [PATCH v4 05/12] arm64: " William Zhang
2024-02-03 0:28 ` [PATCH v4 06/12] arm64: dts: broadcom: bcmbca: Update router boards William Zhang
5 siblings, 0 replies; 17+ messages in thread
From: William Zhang @ 2024-02-03 0:28 UTC (permalink / raw)
To: Linux MTD List, Linux ARM List, Broadcom Kernel List
Cc: f.fainelli, kursad.oney, joel.peshkin, anand.gore, dregan,
kamal.dasu, tomer.yacoby, dan.beygelman, William Zhang,
David Regan, devicetree, Conor Dooley, Andre Przywara,
linux-kernel, Krzysztof Kozlowski, Rob Herring,
Rafał Miłecki, Florian Fainelli, Alexandre TORGUE,
Shawn Guo
Add support for Broadcom STB NAND controller in BCMBCA ARMv7 chip dts
files.
Signed-off-by: William Zhang <william.zhang@broadcom.com>
Reviewed-by: David Regan <dregan@broadcom.com>
---
Changes in v4:
- Move the board related dts setting from SoC dtsi to board dts
Changes in v3: None
Changes in v2: None
arch/arm/boot/dts/broadcom/bcm47622.dtsi | 14 ++++++++++++++
arch/arm/boot/dts/broadcom/bcm63138.dtsi | 7 ++++++-
arch/arm/boot/dts/broadcom/bcm63148.dtsi | 14 ++++++++++++++
arch/arm/boot/dts/broadcom/bcm63178.dtsi | 14 ++++++++++++++
arch/arm/boot/dts/broadcom/bcm6756.dtsi | 14 ++++++++++++++
arch/arm/boot/dts/broadcom/bcm6846.dtsi | 14 ++++++++++++++
arch/arm/boot/dts/broadcom/bcm6855.dtsi | 14 ++++++++++++++
arch/arm/boot/dts/broadcom/bcm6878.dtsi | 14 ++++++++++++++
arch/arm/boot/dts/broadcom/bcm947622.dts | 10 ++++++++++
arch/arm/boot/dts/broadcom/bcm963138.dts | 10 ++++++++++
arch/arm/boot/dts/broadcom/bcm963138dvt.dts | 14 +++++++-------
arch/arm/boot/dts/broadcom/bcm963148.dts | 10 ++++++++++
arch/arm/boot/dts/broadcom/bcm963178.dts | 10 ++++++++++
arch/arm/boot/dts/broadcom/bcm96756.dts | 10 ++++++++++
arch/arm/boot/dts/broadcom/bcm96846.dts | 10 ++++++++++
arch/arm/boot/dts/broadcom/bcm96855.dts | 10 ++++++++++
arch/arm/boot/dts/broadcom/bcm96878.dts | 10 ++++++++++
17 files changed, 191 insertions(+), 8 deletions(-)
diff --git a/arch/arm/boot/dts/broadcom/bcm47622.dtsi b/arch/arm/boot/dts/broadcom/bcm47622.dtsi
index 7cd38de118c3..485863f9c420 100644
--- a/arch/arm/boot/dts/broadcom/bcm47622.dtsi
+++ b/arch/arm/boot/dts/broadcom/bcm47622.dtsi
@@ -138,6 +138,20 @@ hsspi: spi@1000 {
status = "disabled";
};
+ nand_controller: nand-controller@1800 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "brcm,nand-bcm63138", "brcm,brcmnand-v7.1", "brcm,brcmnand";
+ reg = <0x1800 0x600>, <0x2000 0x10>;
+ reg-names = "nand", "nand-int-base";
+ status = "disabled";
+
+ nandcs: nand@0 {
+ compatible = "brcm,nandcs";
+ reg = <0>;
+ };
+ };
+
uart0: serial@12000 {
compatible = "arm,pl011", "arm,primecell";
reg = <0x12000 0x1000>;
diff --git a/arch/arm/boot/dts/broadcom/bcm63138.dtsi b/arch/arm/boot/dts/broadcom/bcm63138.dtsi
index 4ef02283612b..e74ba6bf370d 100644
--- a/arch/arm/boot/dts/broadcom/bcm63138.dtsi
+++ b/arch/arm/boot/dts/broadcom/bcm63138.dtsi
@@ -229,7 +229,12 @@ nand_controller: nand-controller@2000 {
reg-names = "nand", "nand-int-base";
status = "disabled";
interrupts = <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-names = "nand";
+ interrupt-names = "nand_ctlrdy";
+
+ nandcs: nand@0 {
+ compatible = "brcm,nandcs";
+ reg = <0>;
+ };
};
serial@4400 {
diff --git a/arch/arm/boot/dts/broadcom/bcm63148.dtsi b/arch/arm/boot/dts/broadcom/bcm63148.dtsi
index 24431de1810e..53703827ee3f 100644
--- a/arch/arm/boot/dts/broadcom/bcm63148.dtsi
+++ b/arch/arm/boot/dts/broadcom/bcm63148.dtsi
@@ -119,5 +119,19 @@ hsspi: spi@1000 {
num-cs = <8>;
status = "disabled";
};
+
+ nand_controller: nand-controller@2000 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "brcm,nand-bcm63138", "brcm,brcmnand-v7.1", "brcm,brcmnand";
+ reg = <0x2000 0x600>, <0xf0 0x10>;
+ reg-names = "nand", "nand-int-base";
+ status = "disabled";
+
+ nandcs: nand@0 {
+ compatible = "brcm,nandcs";
+ reg = <0>;
+ };
+ };
};
};
diff --git a/arch/arm/boot/dts/broadcom/bcm63178.dtsi b/arch/arm/boot/dts/broadcom/bcm63178.dtsi
index 3f9aed96babf..6d8d33498983 100644
--- a/arch/arm/boot/dts/broadcom/bcm63178.dtsi
+++ b/arch/arm/boot/dts/broadcom/bcm63178.dtsi
@@ -129,6 +129,20 @@ hsspi: spi@1000 {
status = "disabled";
};
+ nand_controller: nand-controller@1800 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "brcm,nand-bcm63138", "brcm,brcmnand-v7.1", "brcm,brcmnand";
+ reg = <0x1800 0x600>, <0x2000 0x10>;
+ reg-names = "nand", "nand-int-base";
+ status = "disabled";
+
+ nandcs: nand@0 {
+ compatible = "brcm,nandcs";
+ reg = <0>;
+ };
+ };
+
uart0: serial@12000 {
compatible = "arm,pl011", "arm,primecell";
reg = <0x12000 0x1000>;
diff --git a/arch/arm/boot/dts/broadcom/bcm6756.dtsi b/arch/arm/boot/dts/broadcom/bcm6756.dtsi
index 1d8d957d65dd..6433f8fa5eff 100644
--- a/arch/arm/boot/dts/broadcom/bcm6756.dtsi
+++ b/arch/arm/boot/dts/broadcom/bcm6756.dtsi
@@ -139,6 +139,20 @@ hsspi: spi@1000 {
status = "disabled";
};
+ nand_controller: nand-controller@1800 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "brcm,nand-bcm63138", "brcm,brcmnand-v7.1", "brcm,brcmnand";
+ reg = <0x1800 0x600>, <0x2000 0x10>;
+ reg-names = "nand", "nand-int-base";
+ status = "disabled";
+
+ nandcs: nand@0 {
+ compatible = "brcm,nandcs";
+ reg = <0>;
+ };
+ };
+
uart0: serial@12000 {
compatible = "arm,pl011", "arm,primecell";
reg = <0x12000 0x1000>;
diff --git a/arch/arm/boot/dts/broadcom/bcm6846.dtsi b/arch/arm/boot/dts/broadcom/bcm6846.dtsi
index cf92cf8c4693..ee361cb00b7c 100644
--- a/arch/arm/boot/dts/broadcom/bcm6846.dtsi
+++ b/arch/arm/boot/dts/broadcom/bcm6846.dtsi
@@ -119,5 +119,19 @@ hsspi: spi@1000 {
num-cs = <8>;
status = "disabled";
};
+
+ nand_controller: nand-controller@1800 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "brcm,nand-bcm63138", "brcm,brcmnand-v7.1", "brcm,brcmnand";
+ reg = <0x1800 0x600>, <0x2000 0x10>;
+ reg-names = "nand", "nand-int-base";
+ status = "disabled";
+
+ nandcs: nand@0 {
+ compatible = "brcm,nandcs";
+ reg = <0>;
+ };
+ };
};
};
diff --git a/arch/arm/boot/dts/broadcom/bcm6855.dtsi b/arch/arm/boot/dts/broadcom/bcm6855.dtsi
index 52d6bc89f9f8..52915ec6f339 100644
--- a/arch/arm/boot/dts/broadcom/bcm6855.dtsi
+++ b/arch/arm/boot/dts/broadcom/bcm6855.dtsi
@@ -129,6 +129,20 @@ hsspi: spi@1000 {
status = "disabled";
};
+ nand_controller: nand-controller@1800 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "brcm,nand-bcm63138", "brcm,brcmnand-v7.1", "brcm,brcmnand";
+ reg = <0x1800 0x600>, <0x2000 0x10>;
+ reg-names = "nand", "nand-int-base";
+ status = "disabled";
+
+ nandcs: nand@0 {
+ compatible = "brcm,nandcs";
+ reg = <0>;
+ };
+ };
+
uart0: serial@12000 {
compatible = "arm,pl011", "arm,primecell";
reg = <0x12000 0x1000>;
diff --git a/arch/arm/boot/dts/broadcom/bcm6878.dtsi b/arch/arm/boot/dts/broadcom/bcm6878.dtsi
index 2c5d706bac7e..70cf23a65fdb 100644
--- a/arch/arm/boot/dts/broadcom/bcm6878.dtsi
+++ b/arch/arm/boot/dts/broadcom/bcm6878.dtsi
@@ -120,6 +120,20 @@ hsspi: spi@1000 {
status = "disabled";
};
+ nand_controller: nand-controller@1800 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "brcm,nand-bcm63138", "brcm,brcmnand-v7.1", "brcm,brcmnand";
+ reg = <0x1800 0x600>, <0x2000 0x10>;
+ reg-names = "nand", "nand-int-base";
+ status = "disabled";
+
+ nandcs: nand@0 {
+ compatible = "brcm,nandcs";
+ reg = <0>;
+ };
+ };
+
uart0: serial@12000 {
compatible = "arm,pl011", "arm,primecell";
reg = <0x12000 0x1000>;
diff --git a/arch/arm/boot/dts/broadcom/bcm947622.dts b/arch/arm/boot/dts/broadcom/bcm947622.dts
index 93b8ce22678d..6241485408d3 100644
--- a/arch/arm/boot/dts/broadcom/bcm947622.dts
+++ b/arch/arm/boot/dts/broadcom/bcm947622.dts
@@ -32,3 +32,13 @@ &uart0 {
&hsspi {
status = "okay";
};
+
+&nand_controller {
+ brcm,wp-not-connected;
+ status = "okay";
+};
+
+&nandcs {
+ nand-on-flash-bbt;
+ brcm,nand-ecc-use-strap;
+};
diff --git a/arch/arm/boot/dts/broadcom/bcm963138.dts b/arch/arm/boot/dts/broadcom/bcm963138.dts
index 1b405c249213..7fd87e05ec20 100644
--- a/arch/arm/boot/dts/broadcom/bcm963138.dts
+++ b/arch/arm/boot/dts/broadcom/bcm963138.dts
@@ -29,3 +29,13 @@ &serial0 {
&hsspi {
status = "okay";
};
+
+&nand_controller {
+ brcm,wp-not-connected;
+ status = "okay";
+};
+
+&nandcs {
+ nand-on-flash-bbt;
+ brcm,nand-ecc-use-strap;
+};
diff --git a/arch/arm/boot/dts/broadcom/bcm963138dvt.dts b/arch/arm/boot/dts/broadcom/bcm963138dvt.dts
index b5af61853a07..f60d09908ab9 100644
--- a/arch/arm/boot/dts/broadcom/bcm963138dvt.dts
+++ b/arch/arm/boot/dts/broadcom/bcm963138dvt.dts
@@ -32,15 +32,15 @@ &serial1 {
};
&nand_controller {
+ brcm,wp-not-connected;
status = "okay";
+};
- nand@0 {
- compatible = "brcm,nandcs";
- reg = <0>;
- nand-ecc-strength = <4>;
- nand-ecc-step-size = <512>;
- brcm,nand-oob-sectors-size = <16>;
- };
+&nandcs {
+ nand-ecc-strength = <4>;
+ nand-ecc-step-size = <512>;
+ brcm,nand-oob-sector-size = <16>;
+ nand-on-flash-bbt;
};
&ahci {
diff --git a/arch/arm/boot/dts/broadcom/bcm963148.dts b/arch/arm/boot/dts/broadcom/bcm963148.dts
index 1f5d6d783f09..44bca063a327 100644
--- a/arch/arm/boot/dts/broadcom/bcm963148.dts
+++ b/arch/arm/boot/dts/broadcom/bcm963148.dts
@@ -32,3 +32,13 @@ &uart0 {
&hsspi {
status = "okay";
};
+
+&nand_controller {
+ brcm,wp-not-connected;
+ status = "okay";
+};
+
+&nandcs {
+ nand-on-flash-bbt;
+ brcm,nand-ecc-use-strap;
+};
diff --git a/arch/arm/boot/dts/broadcom/bcm963178.dts b/arch/arm/boot/dts/broadcom/bcm963178.dts
index d036e99dd8d1..098a222cd71a 100644
--- a/arch/arm/boot/dts/broadcom/bcm963178.dts
+++ b/arch/arm/boot/dts/broadcom/bcm963178.dts
@@ -32,3 +32,13 @@ &uart0 {
&hsspi {
status = "okay";
};
+
+&nand_controller {
+ brcm,wp-not-connected;
+ status = "okay";
+};
+
+&nandcs {
+ nand-on-flash-bbt;
+ brcm,nand-ecc-use-strap;
+};
diff --git a/arch/arm/boot/dts/broadcom/bcm96756.dts b/arch/arm/boot/dts/broadcom/bcm96756.dts
index 8b104f3fb14a..402038d3cd0c 100644
--- a/arch/arm/boot/dts/broadcom/bcm96756.dts
+++ b/arch/arm/boot/dts/broadcom/bcm96756.dts
@@ -32,3 +32,13 @@ &uart0 {
&hsspi {
status = "okay";
};
+
+&nand_controller {
+ brcm,wp-not-connected;
+ status = "okay";
+};
+
+&nandcs {
+ nand-on-flash-bbt;
+ brcm,nand-ecc-use-strap;
+};
diff --git a/arch/arm/boot/dts/broadcom/bcm96846.dts b/arch/arm/boot/dts/broadcom/bcm96846.dts
index 55852c229608..943896afb7cc 100644
--- a/arch/arm/boot/dts/broadcom/bcm96846.dts
+++ b/arch/arm/boot/dts/broadcom/bcm96846.dts
@@ -32,3 +32,13 @@ &uart0 {
&hsspi {
status = "okay";
};
+
+&nand_controller {
+ brcm,wp-not-connected;
+ status = "okay";
+};
+
+&nandcs {
+ nand-on-flash-bbt;
+ brcm,nand-ecc-use-strap;
+};
diff --git a/arch/arm/boot/dts/broadcom/bcm96855.dts b/arch/arm/boot/dts/broadcom/bcm96855.dts
index 2ad880af2104..571663d9a1ea 100644
--- a/arch/arm/boot/dts/broadcom/bcm96855.dts
+++ b/arch/arm/boot/dts/broadcom/bcm96855.dts
@@ -32,3 +32,13 @@ &uart0 {
&hsspi {
status = "okay";
};
+
+&nand_controller {
+ brcm,wp-not-connected;
+ status = "okay";
+};
+
+&nandcs {
+ nand-on-flash-bbt;
+ brcm,nand-ecc-use-strap;
+};
diff --git a/arch/arm/boot/dts/broadcom/bcm96878.dts b/arch/arm/boot/dts/broadcom/bcm96878.dts
index b7af8ade7a9d..8d6eddd54c6e 100644
--- a/arch/arm/boot/dts/broadcom/bcm96878.dts
+++ b/arch/arm/boot/dts/broadcom/bcm96878.dts
@@ -32,3 +32,13 @@ &uart0 {
&hsspi {
status = "okay";
};
+
+&nand_controller {
+ brcm,wp-not-connected;
+ status = "okay";
+};
+
+&nandcs {
+ nand-on-flash-bbt;
+ brcm,nand-ecc-use-strap;
+};
--
2.37.3
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v4 05/12] arm64: dts: broadcom: bcmbca: Add NAND controller node
2024-02-03 0:28 [PATCH v4 00/12] dt-bindings: mtd: brcmnand: Updates for bcmbca SoCs William Zhang
` (3 preceding siblings ...)
2024-02-03 0:28 ` [PATCH v4 04/12] ARM: dts: broadcom: bcmbca: Add NAND controller node William Zhang
@ 2024-02-03 0:28 ` William Zhang
2024-02-03 0:28 ` [PATCH v4 06/12] arm64: dts: broadcom: bcmbca: Update router boards William Zhang
5 siblings, 0 replies; 17+ messages in thread
From: William Zhang @ 2024-02-03 0:28 UTC (permalink / raw)
To: Linux MTD List, Linux ARM List, Broadcom Kernel List
Cc: f.fainelli, kursad.oney, joel.peshkin, anand.gore, dregan,
kamal.dasu, tomer.yacoby, dan.beygelman, William Zhang,
David Regan, devicetree, Conor Dooley, linux-kernel,
Krzysztof Kozlowski, Rob Herring, Rafał Miłecki,
Florian Fainelli
Add support for Broadcom STB NAND controller in BCMBCA ARMv8 chip dts
files.
Signed-off-by: William Zhang <william.zhang@broadcom.com>
Reviewed-by: David Regan <dregan@broadcom.com>
---
Changes in v4:
- Move the board related dts setting from SoC dtsi to board dts
Changes in v3: None
Changes in v2:
- Add nand controller node label for 4908 so it is consistent with other
SoCs and can be referenced by board dts file
arch/arm64/boot/dts/broadcom/bcmbca/bcm4908.dtsi | 4 ++--
arch/arm64/boot/dts/broadcom/bcmbca/bcm4912.dtsi | 14 ++++++++++++++
arch/arm64/boot/dts/broadcom/bcmbca/bcm63146.dtsi | 14 ++++++++++++++
arch/arm64/boot/dts/broadcom/bcmbca/bcm63158.dtsi | 14 ++++++++++++++
arch/arm64/boot/dts/broadcom/bcmbca/bcm6813.dtsi | 14 ++++++++++++++
arch/arm64/boot/dts/broadcom/bcmbca/bcm6856.dtsi | 14 ++++++++++++++
arch/arm64/boot/dts/broadcom/bcmbca/bcm6858.dtsi | 14 ++++++++++++++
arch/arm64/boot/dts/broadcom/bcmbca/bcm94908.dts | 10 ++++++++++
arch/arm64/boot/dts/broadcom/bcmbca/bcm94912.dts | 10 ++++++++++
arch/arm64/boot/dts/broadcom/bcmbca/bcm963146.dts | 10 ++++++++++
arch/arm64/boot/dts/broadcom/bcmbca/bcm963158.dts | 10 ++++++++++
arch/arm64/boot/dts/broadcom/bcmbca/bcm96813.dts | 10 ++++++++++
arch/arm64/boot/dts/broadcom/bcmbca/bcm96856.dts | 10 ++++++++++
arch/arm64/boot/dts/broadcom/bcmbca/bcm96858.dts | 10 ++++++++++
14 files changed, 156 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/bcm4908.dtsi b/arch/arm64/boot/dts/broadcom/bcmbca/bcm4908.dtsi
index 2f124b027bbf..336016e334d9 100644
--- a/arch/arm64/boot/dts/broadcom/bcmbca/bcm4908.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcmbca/bcm4908.dtsi
@@ -589,7 +589,7 @@ hsspi: spi@1000 {
status = "disabled";
};
- nand-controller@1800 {
+ nand_controller: nand-controller@1800 {
#address-cells = <1>;
#size-cells = <0>;
compatible = "brcm,nand-bcm63138", "brcm,brcmnand-v7.1", "brcm,brcmnand";
@@ -597,7 +597,7 @@ nand-controller@1800 {
reg-names = "nand", "nand-int-base";
interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "nand_ctlrdy";
- status = "okay";
+ status = "disabled";
nandcs: nand@0 {
compatible = "brcm,nandcs";
diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/bcm4912.dtsi b/arch/arm64/boot/dts/broadcom/bcmbca/bcm4912.dtsi
index d658c81f7285..14b2adfb817c 100644
--- a/arch/arm64/boot/dts/broadcom/bcmbca/bcm4912.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcmbca/bcm4912.dtsi
@@ -138,6 +138,20 @@ hsspi: spi@1000 {
status = "disabled";
};
+ nand_controller: nand-controller@1800 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "brcm,nand-bcm63138", "brcm,brcmnand-v7.1", "brcm,brcmnand";
+ reg = <0x1800 0x600>, <0x2000 0x10>;
+ reg-names = "nand", "nand-int-base";
+ status = "disabled";
+
+ nandcs: nand@0 {
+ compatible = "brcm,nandcs";
+ reg = <0>;
+ };
+ };
+
uart0: serial@12000 {
compatible = "arm,pl011", "arm,primecell";
reg = <0x12000 0x1000>;
diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/bcm63146.dtsi b/arch/arm64/boot/dts/broadcom/bcmbca/bcm63146.dtsi
index 4f474d47022e..589b8a1efc72 100644
--- a/arch/arm64/boot/dts/broadcom/bcmbca/bcm63146.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcmbca/bcm63146.dtsi
@@ -119,6 +119,20 @@ hsspi: spi@1000 {
status = "disabled";
};
+ nand_controller: nand-controller@1800 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "brcm,nand-bcm63138", "brcm,brcmnand-v7.1", "brcm,brcmnand";
+ reg = <0x1800 0x600>, <0x2000 0x10>;
+ reg-names = "nand", "nand-int-base";
+ status = "disabled";
+
+ nandcs: nand@0 {
+ compatible = "brcm,nandcs";
+ reg = <0>;
+ };
+ };
+
uart0: serial@12000 {
compatible = "arm,pl011", "arm,primecell";
reg = <0x12000 0x1000>;
diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/bcm63158.dtsi b/arch/arm64/boot/dts/broadcom/bcmbca/bcm63158.dtsi
index 909f254dc47d..48d618e75866 100644
--- a/arch/arm64/boot/dts/broadcom/bcmbca/bcm63158.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcmbca/bcm63158.dtsi
@@ -137,6 +137,20 @@ hsspi: spi@1000 {
status = "disabled";
};
+ nand_controller: nand-controller@1800 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "brcm,nand-bcm63138", "brcm,brcmnand-v7.1", "brcm,brcmnand";
+ reg = <0x1800 0x600>, <0x2000 0x10>;
+ reg-names = "nand", "nand-int-base";
+ status = "disabled";
+
+ nandcs: nand@0 {
+ compatible = "brcm,nandcs";
+ reg = <0>;
+ };
+ };
+
uart0: serial@12000 {
compatible = "arm,pl011", "arm,primecell";
reg = <0x12000 0x1000>;
diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/bcm6813.dtsi b/arch/arm64/boot/dts/broadcom/bcmbca/bcm6813.dtsi
index 685ae32951c9..1d1303cf90f3 100644
--- a/arch/arm64/boot/dts/broadcom/bcmbca/bcm6813.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcmbca/bcm6813.dtsi
@@ -138,6 +138,20 @@ hsspi: spi@1000 {
status = "disabled";
};
+ nand_controller: nand-controller@1800 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "brcm,nand-bcm63138", "brcm,brcmnand-v7.1", "brcm,brcmnand";
+ reg = <0x1800 0x600>, <0x2000 0x10>;
+ reg-names = "nand", "nand-int-base";
+ status = "disabled";
+
+ nandcs: nand@0 {
+ compatible = "brcm,nandcs";
+ reg = <0>;
+ };
+ };
+
uart0: serial@12000 {
compatible = "arm,pl011", "arm,primecell";
reg = <0x12000 0x1000>;
diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/bcm6856.dtsi b/arch/arm64/boot/dts/broadcom/bcmbca/bcm6856.dtsi
index 820553ce541b..00c62c1e5df0 100644
--- a/arch/arm64/boot/dts/broadcom/bcmbca/bcm6856.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcmbca/bcm6856.dtsi
@@ -119,5 +119,19 @@ hsspi: spi@1000 {
num-cs = <8>;
status = "disabled";
};
+
+ nand_controller: nand-controller@1800 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "brcm,nand-bcm63138", "brcm,brcmnand-v7.1", "brcm,brcmnand";
+ reg = <0x1800 0x600>, <0x2000 0x10>;
+ reg-names = "nand", "nand-int-base";
+ status = "disabled";
+
+ nandcs: nand@0 {
+ compatible = "brcm,nandcs";
+ reg = <0>;
+ };
+ };
};
};
diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/bcm6858.dtsi b/arch/arm64/boot/dts/broadcom/bcmbca/bcm6858.dtsi
index 0eb93c298297..caeaf428dc15 100644
--- a/arch/arm64/boot/dts/broadcom/bcmbca/bcm6858.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcmbca/bcm6858.dtsi
@@ -156,5 +156,19 @@ hsspi: spi@1000 {
num-cs = <8>;
status = "disabled";
};
+
+ nand_controller: nand-controller@1800 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "brcm,nand-bcm63138", "brcm,brcmnand-v7.1", "brcm,brcmnand";
+ reg = <0x1800 0x600>, <0x2000 0x10>;
+ reg-names = "nand", "nand-int-base";
+ status = "disabled";
+
+ nandcs: nand@0 {
+ compatible = "brcm,nandcs";
+ reg = <0>;
+ };
+ };
};
};
diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/bcm94908.dts b/arch/arm64/boot/dts/broadcom/bcmbca/bcm94908.dts
index c4e6e71f6310..030ffa5364fb 100644
--- a/arch/arm64/boot/dts/broadcom/bcmbca/bcm94908.dts
+++ b/arch/arm64/boot/dts/broadcom/bcmbca/bcm94908.dts
@@ -32,3 +32,13 @@ &uart0 {
&hsspi {
status = "okay";
};
+
+&nand_controller {
+ brcm,wp-not-connected;
+ status = "okay";
+};
+
+&nandcs {
+ nand-on-flash-bbt;
+ brcm,nand-ecc-use-strap;
+};
diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/bcm94912.dts b/arch/arm64/boot/dts/broadcom/bcmbca/bcm94912.dts
index e69cd683211a..4b779e6c22e1 100644
--- a/arch/arm64/boot/dts/broadcom/bcmbca/bcm94912.dts
+++ b/arch/arm64/boot/dts/broadcom/bcmbca/bcm94912.dts
@@ -32,3 +32,13 @@ &uart0 {
&hsspi {
status = "okay";
};
+
+&nand_controller {
+ brcm,wp-not-connected;
+ status = "okay";
+};
+
+&nandcs {
+ nand-on-flash-bbt;
+ brcm,nand-ecc-use-strap;
+};
diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/bcm963146.dts b/arch/arm64/boot/dts/broadcom/bcmbca/bcm963146.dts
index db2c82d6dfd8..2851e8e41bf4 100644
--- a/arch/arm64/boot/dts/broadcom/bcmbca/bcm963146.dts
+++ b/arch/arm64/boot/dts/broadcom/bcmbca/bcm963146.dts
@@ -32,3 +32,13 @@ &uart0 {
&hsspi {
status = "okay";
};
+
+&nand_controller {
+ brcm,wp-not-connected;
+ status = "okay";
+};
+
+&nandcs {
+ nand-on-flash-bbt;
+ brcm,nand-ecc-use-strap;
+};
diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/bcm963158.dts b/arch/arm64/boot/dts/broadcom/bcmbca/bcm963158.dts
index 25c12bc63545..17dc594fe83f 100644
--- a/arch/arm64/boot/dts/broadcom/bcmbca/bcm963158.dts
+++ b/arch/arm64/boot/dts/broadcom/bcmbca/bcm963158.dts
@@ -32,3 +32,13 @@ &uart0 {
&hsspi {
status = "okay";
};
+
+&nand_controller {
+ brcm,wp-not-connected;
+ status = "okay";
+};
+
+&nandcs {
+ nand-on-flash-bbt;
+ brcm,nand-ecc-use-strap;
+};
diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/bcm96813.dts b/arch/arm64/boot/dts/broadcom/bcmbca/bcm96813.dts
index faba21f03120..34832a734734 100644
--- a/arch/arm64/boot/dts/broadcom/bcmbca/bcm96813.dts
+++ b/arch/arm64/boot/dts/broadcom/bcmbca/bcm96813.dts
@@ -32,3 +32,13 @@ &uart0 {
&hsspi {
status = "okay";
};
+
+&nand_controller {
+ brcm,wp-not-connected;
+ status = "okay";
+};
+
+&nandcs {
+ nand-on-flash-bbt;
+ brcm,nand-ecc-use-strap;
+};
diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/bcm96856.dts b/arch/arm64/boot/dts/broadcom/bcmbca/bcm96856.dts
index 9808331eede2..e1396b5544b7 100644
--- a/arch/arm64/boot/dts/broadcom/bcmbca/bcm96856.dts
+++ b/arch/arm64/boot/dts/broadcom/bcmbca/bcm96856.dts
@@ -32,3 +32,13 @@ &uart0 {
&hsspi {
status = "okay";
};
+
+&nand_controller {
+ brcm,wp-not-connected;
+ status = "okay";
+};
+
+&nandcs {
+ nand-on-flash-bbt;
+ brcm,nand-ecc-use-strap;
+};
diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/bcm96858.dts b/arch/arm64/boot/dts/broadcom/bcmbca/bcm96858.dts
index 1f561c8e13b0..30bbf6f2917e 100644
--- a/arch/arm64/boot/dts/broadcom/bcmbca/bcm96858.dts
+++ b/arch/arm64/boot/dts/broadcom/bcmbca/bcm96858.dts
@@ -32,3 +32,13 @@ &uart0 {
&hsspi {
status = "okay";
};
+
+&nand_controller {
+ brcm,wp-not-connected;
+ status = "okay";
+};
+
+&nandcs {
+ nand-on-flash-bbt;
+ brcm,nand-ecc-use-strap;
+};
--
2.37.3
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v4 06/12] arm64: dts: broadcom: bcmbca: Update router boards
2024-02-03 0:28 [PATCH v4 00/12] dt-bindings: mtd: brcmnand: Updates for bcmbca SoCs William Zhang
` (4 preceding siblings ...)
2024-02-03 0:28 ` [PATCH v4 05/12] arm64: " William Zhang
@ 2024-02-03 0:28 ` William Zhang
5 siblings, 0 replies; 17+ messages in thread
From: William Zhang @ 2024-02-03 0:28 UTC (permalink / raw)
To: Linux MTD List, Linux ARM List, Broadcom Kernel List
Cc: f.fainelli, kursad.oney, joel.peshkin, anand.gore, dregan,
kamal.dasu, tomer.yacoby, dan.beygelman, William Zhang,
devicetree, Conor Dooley, linux-kernel, Krzysztof Kozlowski,
Rob Herring, Rafał Miłecki, Florian Fainelli
Enable the nand controller and add WP pin connection property in actual
board dts as they are board level properties now that they are disabled
and moved out from SoC dtsi.
Also remove the unnecessary brcm,nand-has-wp property from AC5300 board.
This property is only needed for some old controller that this board
does not apply.
Signed-off-by: William Zhang <william.zhang@broadcom.com>
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
.../boot/dts/broadcom/bcmbca/bcm4906-netgear-r8000p.dts | 5 +++++
.../dts/broadcom/bcmbca/bcm4906-tplink-archer-c2300-v1.dts | 5 +++++
.../boot/dts/broadcom/bcmbca/bcm4908-asus-gt-ac5300.dts | 6 +++++-
3 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-netgear-r8000p.dts b/arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-netgear-r8000p.dts
index 78204d71ecd2..999d93730240 100644
--- a/arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-netgear-r8000p.dts
+++ b/arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-netgear-r8000p.dts
@@ -125,6 +125,11 @@ port@7 {
};
};
+&nand_controller {
+ brcm,wp-not-connected;
+ status = "okay";
+};
+
&nandcs {
nand-ecc-strength = <4>;
nand-ecc-step-size = <512>;
diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-tplink-archer-c2300-v1.dts b/arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-tplink-archer-c2300-v1.dts
index fcf092c81b59..19fc03ef47a0 100644
--- a/arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-tplink-archer-c2300-v1.dts
+++ b/arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-tplink-archer-c2300-v1.dts
@@ -155,6 +155,11 @@ port@7 {
};
};
+&nand_controller {
+ brcm,wp-not-connected;
+ status = "okay";
+};
+
&nandcs {
nand-ecc-strength = <4>;
nand-ecc-step-size = <512>;
diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/bcm4908-asus-gt-ac5300.dts b/arch/arm64/boot/dts/broadcom/bcmbca/bcm4908-asus-gt-ac5300.dts
index d94a53d68320..52f928dbfa3c 100644
--- a/arch/arm64/boot/dts/broadcom/bcmbca/bcm4908-asus-gt-ac5300.dts
+++ b/arch/arm64/boot/dts/broadcom/bcmbca/bcm4908-asus-gt-ac5300.dts
@@ -166,11 +166,15 @@ led@19 {
};
};
+&nand_controller {
+ brcm,wp-not-connected;
+ status = "okay";
+};
+
&nandcs {
nand-ecc-strength = <4>;
nand-ecc-step-size = <512>;
nand-on-flash-bbt;
- brcm,nand-has-wp;
#address-cells = <1>;
#size-cells = <0>;
--
2.37.3
^ permalink raw reply related [flat|nested] 17+ messages in thread