From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?U8O2cmVu?= Brinkmann Subject: Re: [PATCH v2 3/9] clocksource/cadence_ttc: Store timer frequency in driver data Date: Wed, 18 Dec 2013 08:47:52 -0800 Message-ID: References: <1385514296-26702-1-git-send-email-soren.brinkmann@xilinx.com> <1385514296-26702-4-git-send-email-soren.brinkmann@xilinx.com> <5cff3201-db97-4061-a686-bf79ac17d4fe@CO1EHSMHS006.ehs.local> <52B1B6FF.7000400@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <52B1B6FF.7000400-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Daniel Lezcano Cc: Michal Simek , Thomas Gleixner , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ingo Molnar List-Id: devicetree@vger.kernel.org Hi Daniel, On Wed, Dec 18, 2013 at 03:53:51PM +0100, Daniel Lezcano wrote: > On 12/17/2013 08:21 PM, S=C3=B6ren Brinkmann wrote: > >Hi Daniel, > > > >On Tue, Nov 26, 2013 at 05:04:50PM -0800, Soren Brinkmann wrote: > >>It is not allowed to call clk_get_rate() from interrupt context. To > >>avoid such calls the timer input frequency is stored in the driver'= s > >>data struct which makes it accessible to the driver in any context. > >> > >>Signed-off-by: Soren Brinkmann > >>Acked-by: Daniel Lezcano > > > >I doubt that we'll resolve all issues with this series before the > >holidays or even the next merge window. Could you take this patch in= to > >your tree for 3.14? It is not directly related to the cpufreq work a= nd > >fixes an actual issue that triggers a kernel WARN under some conditi= on > >(I missed preserving the details and the trace). That would take the > >easy stuff out of the way and we can focus on the more controversial > >changes. >=20 > You are asking to take it for 3.14 but shouldn't it go as a 3.13 fix = ? That's also an option. As I remember, the patch fixes a kernel WARN. Th= e system still seemed operational though. Up to you whether this is considered severe enough for the 3.13 series. I'm happy either way. S=C3=B6ren -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html