From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Jian Yang" <jian.yang@mediatek.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Rob Herring" <robh@kernel.org>,
"Jianjun Wang" <jianjun.wang@mediatek.com>
Cc: linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
Chuanjia.Liu@mediatek.com, Jieyy.Yang@mediatek.com,
Qizhong.Cheng@mediatek.com, Jianguo.Zhang@mediatek.com,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Abel Vesa <abel.vesa@linaro.org>
Subject: Re: [PATCH v4 2/2] PCI: mediatek-gen3: Add power and reset control feature for downstream component
Date: Mon, 6 Nov 2023 08:53:44 +0100 [thread overview]
Message-ID: <ce2c96f9-7895-41fc-a5f9-617b79f64f96@kernel.org> (raw)
In-Reply-To: <20231106061220.21485-3-jian.yang@mediatek.com>
On 06/11/2023 07:12, Jian Yang wrote:
> From: "jian.yang" <jian.yang@mediatek.com>
>
> Make MediaTek's controller driver capable of controlling power
> supplies and reset pin of a downstream component in power-on and
> power-off process.
>
> Some downstream components (e.g., a WIFI chip) may need an extra
> reset other than PERST# and their power supplies, depending on
> the requirements of platform, may need to controlled by their
> parent's driver. To meet the requirements described above, I add this
> feature to MediaTek's PCIe controller driver as an optional feature.
NAK, strong NAK. This should be done in a generic way because nothing
here is specific to Mediatek.
You just implement power sequencing of devices through quirks specific
to one controller.
Work with others to provide common solution.
https://lpc.events/event/17/contributions/1507/
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-06 7:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 6:12 [PATCH v4 0/2] PCI: mediatek-gen3: Support controlling power supplies Jian Yang
2023-11-06 6:12 ` [PATCH v4 1/2] dt-bindings: PCI: mediatek-gen3: Add support for controlling power and reset Jian Yang
2023-11-06 7:50 ` Krzysztof Kozlowski
2023-11-06 8:25 ` AngeloGioacchino Del Regno
2023-11-06 8:48 ` Krzysztof Kozlowski
2023-11-06 6:12 ` [PATCH v4 2/2] PCI: mediatek-gen3: Add power and reset control feature for downstream component Jian Yang
2023-11-06 7:53 ` Krzysztof Kozlowski [this message]
2023-11-06 8:36 ` AngeloGioacchino Del Regno
2023-11-06 8:46 ` Krzysztof Kozlowski
2023-11-06 8:56 ` AngeloGioacchino Del Regno
2023-11-06 8:23 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce2c96f9-7895-41fc-a5f9-617b79f64f96@kernel.org \
--to=krzk@kernel.org \
--cc=Chuanjia.Liu@mediatek.com \
--cc=Jianguo.Zhang@mediatek.com \
--cc=Jieyy.Yang@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=Qizhong.Cheng@mediatek.com \
--cc=abel.vesa@linaro.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=jian.yang@mediatek.com \
--cc=jianjun.wang@mediatek.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox