From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26F08C4332F for ; Sun, 20 Mar 2022 12:09:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233767AbiCTMLK (ORCPT ); Sun, 20 Mar 2022 08:11:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232356AbiCTMLK (ORCPT ); Sun, 20 Mar 2022 08:11:10 -0400 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AECC53DDD1; Sun, 20 Mar 2022 05:09:47 -0700 (PDT) Received: by mail-ed1-f48.google.com with SMTP id w25so15021197edi.11; Sun, 20 Mar 2022 05:09:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=09MJ3F+SKFH/o6mzuUI5CFbfCkCq8QY9FgJU9k73OZc=; b=fiRC911N6/W6iGbV1JRrSUO87WXp9WRuMNaCtvHy0RX3SanCyN0mfgEK6tpDa/FHUJ ZdLVla7ZBETDHCBIO+bgeQUjbZzqj1FtmHE/8AbH2jucxn1IGHc08jMsGG+FHZuE9gjR wtDhbteeJ1e1W1ATm0NN8byiIxMGH5Kbxx4pIa9TZKhTZiKYHE43nA5cTpUHQm9nTRqv b3dNSHava7sqq2AY3fkZ4lKuwUTSCgQlSlRh9ApsyTKGljisLjnqrZ6DV7WTykYfeuP0 LIrn1WE16GO4mMqxqKYS8Tb+HaPmkHv9o+0fplHQEhR288hRub76cKdqxqTL4gSoyyaQ Ry9w== X-Gm-Message-State: AOAM531q1bKi9Qupk9ZjLxtSv8zM6f7b8TntDCG/jYK17yDfQfyxKCUQ jTogCwt5AT2IyVetP2nT4vY= X-Google-Smtp-Source: ABdhPJxJw0uAM+k7E1tqS8+6bFI30rkfWXjj31C1g20y/9V+mDiczOByjIKW0euKEIwV3OiVfosgQA== X-Received: by 2002:aa7:d156:0:b0:419:bc7:acd6 with SMTP id r22-20020aa7d156000000b004190bc7acd6mr11821446edo.239.1647778186114; Sun, 20 Mar 2022 05:09:46 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.googlemail.com with ESMTPSA id z21-20020a1709063a1500b006da6436819dsm5790038eje.173.2022.03.20.05.09.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Mar 2022 05:09:45 -0700 (PDT) Message-ID: Date: Sun, 20 Mar 2022 13:09:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 14/16] dt-bindings: clock: Convert qcom,krait-cc to yaml Content-Language: en-US To: Ansuel Smith , Rob Herring , Bjorn Andersson , Andy Gross , Michael Turquette , Stephen Boyd , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org References: <20220318160827.8860-1-ansuelsmth@gmail.com> <20220318160827.8860-15-ansuelsmth@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220318160827.8860-15-ansuelsmth@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/03/2022 17:08, Ansuel Smith wrote: > Convert qcom,krait-cc to yaml and add missing l2 clocks and names > definiton. lang typo. > > Signed-off-by: Ansuel Smith > --- > .../bindings/clock/qcom,krait-cc.txt | 34 ---------- > .../bindings/clock/qcom,krait-cc.yaml | 63 +++++++++++++++++++ > 2 files changed, 63 insertions(+), 34 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/clock/qcom,krait-cc.txt > create mode 100644 Documentation/devicetree/bindings/clock/qcom,krait-cc.yaml > > diff --git a/Documentation/devicetree/bindings/clock/qcom,krait-cc.txt b/Documentation/devicetree/bindings/clock/qcom,krait-cc.txt > deleted file mode 100644 > index 030ba60dab08..000000000000 > --- a/Documentation/devicetree/bindings/clock/qcom,krait-cc.txt > +++ /dev/null > @@ -1,34 +0,0 @@ > -Krait Clock Controller > - > -PROPERTIES > - > -- compatible: > - Usage: required > - Value type: > - Definition: must be one of: > - "qcom,krait-cc-v1" > - "qcom,krait-cc-v2" > - > -- #clock-cells: > - Usage: required > - Value type: > - Definition: must be 1 > - > -- clocks: > - Usage: required > - Value type: > - Definition: reference to the clock parents of hfpll, secondary muxes. > - > -- clock-names: > - Usage: required > - Value type: > - Definition: must be "hfpll0", "hfpll1", "acpu0_aux", "acpu1_aux", "qsb". > - > -Example: > - > - kraitcc: clock-controller { > - compatible = "qcom,krait-cc-v1"; > - clocks = <&hfpll0>, <&hfpll1>, <&acpu0_aux>, <&acpu1_aux>, ; > - clock-names = "hfpll0", "hfpll1", "acpu0_aux", "acpu1_aux", "qsb"; > - #clock-cells = <1>; > - }; > diff --git a/Documentation/devicetree/bindings/clock/qcom,krait-cc.yaml b/Documentation/devicetree/bindings/clock/qcom,krait-cc.yaml > new file mode 100644 > index 000000000000..f89b70ab01ae > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/qcom,krait-cc.yaml > @@ -0,0 +1,63 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/qcom,krait-cc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Krait Clock Controller > + > +maintainers: > + - Ansuel Smith > + > +description: | > + Qualcomm Krait Clock Controller used to correctly scale the CPU and the L2 > + rates. > + > +properties: > + compatible: > + enum: > + - qcom,krait-cc-v1 > + - qcom,krait-cc-v2 > + > + clocks: > + items: > + - description: phandle to hfpll for CPU0 mux > + - description: phandle to hfpll for CPU1 mux > + - description: phandle to hfpll for L2 mux > + - description: phandle to CPU0 aux clock > + - description: phandle to CPU1 aux clock > + - description: phandle to L2 aux clock > + - description: phandle to QSB fixed clk None of these were in original bindings, original DTS (because it does not exist), original driver. Therefore you do not need to change bindings during conversion. I propose to add them in second commit with explanation why do you add them. Best regards, Krzysztof