Re: [PATCH v2 3/4] dt-bindings: iio: adc: ad7192: Add AD7194 support

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 14/11/2023 21:05, Alisa-Dariana Roman wrote:
> Unlike the other AD719Xs, AD7194 has configurable differential
> channels. The default configuration for these channels can be changed
> from the devicetree.
> 
> Also add an example for AD7194 devicetree.
> 
> Signed-off-by: Alisa-Dariana Roman <alisa.roman@analog.com>
> ---

Where is the changelog?

>  .../bindings/iio/adc/adi,ad7192.yaml          | 74 +++++++++++++++++++
>  1 file changed, 74 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
> index 9b59d6eea368..800b396f5993 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
> @@ -21,6 +21,7 @@ properties:
>        - adi,ad7190
>        - adi,ad7192
>        - adi,ad7193
> +      - adi,ad7194
>        - adi,ad7195
>  
>    reg:
> @@ -108,6 +109,42 @@ required:
>  
>  allOf:
>    - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          const: adi,ad7194
> +    then:
> +      properties:
> +        '#address-cells':

Use consistent quotes through the file, either ' or ".

> +          const: 1
> +
> +        '#size-cells':
> +          const: 0
> +
> +      patternProperties:
> +        "^channel@([0-7a-f])$":

Properties always go to top-level. In allOf you only constrain them or
disallow (: false).

Best regards,
Krzysztof