From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EECC41EB37 for ; Thu, 18 Jan 2024 23:31:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705620674; cv=none; b=XAehflqax9vRDF+qRhZEpXYQL/kpRdMa8Imy6DqBlBV7d9uK62IPrx95yPdGEWw80CpJlGzNi/CJNjQi4n9fCmV/8jFBVSXwg/ZYSKt4nWTsvGUg6nIccSW55Wb/kVbELdjO0waxmhmMtiNhRbLyqDYNlkTBDMoCz0pMA1Erinw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705620674; c=relaxed/simple; bh=IdpU2iFg7IVH1ufjSNd28yuQIldlBMrrkAL0tUwiR3M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MxjwGy+RZTbrjlKSUlkJMfG+98nlzRAzX301J8IggJec3nje3Hacfo2rd6SlOfLHUFuO2xhL9X3Q86rVzqT/E4O691Mwb5IHWYxxPNRRr14oSmIKX3LOxz10alWVOTNL76Dsa8zMEl1cDvDDREWSxrH4Q/bf02EEAKLYVth+cBY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Hlgh7OZN; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Hlgh7OZN" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-337cf4eabc9so119210f8f.3 for ; Thu, 18 Jan 2024 15:31:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705620669; x=1706225469; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6v0lpyy987F1ypK0yHFg7YzbqvtCeBq1Ni/3BxFVaP8=; b=Hlgh7OZN+oceDjCX71S1+jjzVWubCpdutpcdapYvU7naFeHNvB8in8IJ+ZP6PcF5GO vSwBK095CeX6m24vzIFg45Jcu+XydbVyCM1pXKttWBRtrL/BjjBd+ft37CBclgAemw4P rTcmU0hlwWQtVxeuZwY9XOJOzVQeEfqh4WcLSN7QY0KLkSPZO80kGLIbsFf8crcMq4xs zTkVa8O1OS0IKUyr0BHBMWSYwcQBflsxRmJ5F8oVD5D5hl09ER8DRzam1lL15Tvppj+J T1zEYKtHAG+xHFX3eAo5MuDrLspS5TfGhDrCJrtU08hbVi9rNglnvVImLr0ybP8ine5+ iOFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705620669; x=1706225469; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6v0lpyy987F1ypK0yHFg7YzbqvtCeBq1Ni/3BxFVaP8=; b=D8qGrusbui/c5TLj56ikYIbULXgTGJhsLrDrGyXuldvl9hdaiuZHHw8HH8yyRISIip rviAjqLaWuLFDRVYyR5fxH0zMJc8/aOXNuqdfTvCJbLHauOPaglRfRLbncE1Vj8JmsiC ldp/Giik34khQ/hu6FQyKMuxxURxTpMbsMpEeMjg+lfQYvKKvVuYoUGyM/MeHgaY8uI4 O/0yhuC4Kxnl9iiFyNgsfXjmiVHbnFbgJAta5hXodjl1EUgp1NTnithKYjh2QfPkRT9o qgkW5frdg/vROElBzPrQWDoC+b/iaHvdpsPWdU++DGCOfDrTBjoWexcztGyuvSEI6qWg EjEA== X-Gm-Message-State: AOJu0YzGquOh7XRBMm8z/tgWITJcPSH6KydW+OJT3Y37AfjRpLnfh3FJ SU2vlL5vlxJnQ7T1gZZj0fKdLC37LWNPsxrlZHkitZuw4VaKiUwvhy4qRIqtT0KTFUglee5pqDl ThQU= X-Google-Smtp-Source: AGHT+IHK8WMSnQ/xm+10s5i+APAOImX+NZ0MsBozts6V6weL9GokHwH2muJibNCsJCflNlRFjDFetQ== X-Received: by 2002:adf:cd85:0:b0:337:9b5d:4c68 with SMTP id q5-20020adfcd85000000b003379b5d4c68mr1119632wrj.127.1705620669094; Thu, 18 Jan 2024 15:31:09 -0800 (PST) Received: from [10.66.66.2] (9.ip-51-91-159.eu. [51.91.159.9]) by smtp.gmail.com with ESMTPSA id q12-20020adfab0c000000b00337d8c40ff7sm973011wrc.3.2024.01.18.15.31.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jan 2024 15:31:08 -0800 (PST) Message-ID: Date: Fri, 19 Jan 2024 00:31:06 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp: Introduce additional tsens instances Content-Language: en-US To: Bjorn Andersson , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240118-sc8280xp-tsens2_3-v1-1-e86bce14f6bf@quicinc.com> From: Konrad Dybcio In-Reply-To: <20240118-sc8280xp-tsens2_3-v1-1-e86bce14f6bf@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/19/24 00:00, Bjorn Andersson wrote: > The SC8280XP contains two additional tsens instances, providing among > other things thermal measurements for the GPU. > > Add these and a GPU thermal-zone. > > Signed-off-by: Bjorn Andersson > --- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 37 ++++++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index febf28356ff8..68b5ac0339a0 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -4033,6 +4033,28 @@ tsens1: thermal-sensor@c265000 { > #thermal-sensor-cells = <1>; > }; > > + tsens2: thermal-sensor@c251000 { > + compatible = "qcom,sc8280xp-tsens", "qcom,tsens-v2"; > + reg = <0 0x0c251000 0 0x1ff>, /* TM */ > + <0 0x0c224000 0 0x8>; /* SROT */ I've previously called for removing these comments that we've been copypasting around for years and years, and I'm gonna stand by that :P [...] > > + gpu-thermal { > + polling-delay-passive = <250>; > + polling-delay = <1000>; Hm, did tsens only gain support of non-polled reporting with 8450? If not, we should definitely update all the relevant SoCs. Konrad