From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9866B29414; Wed, 26 Jun 2024 07:30:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719387052; cv=none; b=oORtMUyPTwmAjAA3HqaZAuNI3VSbtTwuDX+m4p2YDOyZZHJej7eJKdf7XtgkUxTYi+TYmdbsVezFRX0CfbioT62fXkeiLFO5gp0hAkrMLaL2f0nM+eqM+jg+ebRn5QTJxbFMgfgNDQUM76eXgn2zNeb+qlHs5N6eK2xop6ebA1A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719387052; c=relaxed/simple; bh=zOVMpDTFFB1iUIaRHdgZB/DQUUlyw1zqiK79M86MG3c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MZ3eANdJh2bU7eB2o+Zv6NfjMdo2lG6V5iAzO+5hbCrRMwiJVRFU2nomG5+j3jzRFe6nyaMFdSSmkfZKbACFLyESt8wREFQvVc5xpuHyeoQRz7kNMgJwK/5zmY5URNcE4NQoUciC74mtKNA7eySSL4qtOcifFk4Ra87Rj5w9jTQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nKkfUCB+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nKkfUCB+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93957C2BD10; Wed, 26 Jun 2024 07:30:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719387052; bh=zOVMpDTFFB1iUIaRHdgZB/DQUUlyw1zqiK79M86MG3c=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=nKkfUCB+lmo2sYtEUkKIgRw5h3aVUIBLHAOV/LHuzU9nlNwAOETQtroF13gfeHwmP wxmHbDAOzTBPPO3SMYnwUbMnNgvZ9Yew0uWVW5RWs4H61MKCs1is5pMxvweiBCvKSE hyqCSzWmGQZmN64vnxmVN16syltOXJ7i7HKjTQrnooCCvPA/nr4Mk6dGmCDUEz5v4F MWRJ0boKr07jDQ2iWOd+NenoiDlhOFgEH744qflgFwWEbKu4fXOsiEKF4qi9VfJ3Pf SSHAOR0eEDWLdAq8DzZltzLi6hkdIKJo8uB3k/KJZSXLCRXA0pET24E7K1nsf8vx3c YUdKeM2Rnek6Q== Message-ID: Date: Wed, 26 Jun 2024 09:30:44 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/3] dt-bindings: rng: Add Rockchip RNG bindings To: Daniel Golle Cc: Aurelien Jarno , Olivia Mackall , Herbert Xu , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Philipp Zabel , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Sebastian Reichel , Sascha Hauer , Dragan Simic , Martin Kaiser , Ard Biesheuvel , linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 23/06/2024 15:08, Daniel Golle wrote: > Hi Krzysztof, > > thank you for your patiente and repeated review of this series. > > On Sun, Jun 23, 2024 at 09:03:15AM +0200, Krzysztof Kozlowski wrote: >> On 23/06/2024 05:32, Daniel Golle wrote: >>> From: Aurelien Jarno >>> >>> Add the True Random Number Generator on the Rockchip RK3568 SoC. >>> >>> Signed-off-by: Aurelien Jarno >>> Signed-off-by: Daniel Golle >> >> My comments from v2, which I reminded at v3, were not addressed. >> >> Respond to each of them and acknowledge that you are going to implement >> the change. > > Your comments to v1which I'm aware of are: > https://patchwork.kernel.org/comment/25087874/ We talk about comments from v2, not v1. > >>> +++ b/Documentation/devicetree/bindings/rng/rockchip-rng.yaml >> Filename matching compatible, so "rockchip,rk3568-rng.yaml" > > I've changed the filename. > >>> +title: Rockchip TRNG bindings > >> Drop "bindings" > > I've changed the title accordingly (now: "Rockchip TRNG" in v4). > >>> +description: >>> + This driver interface with the True Random Number Generator present in some >> >> Drop "This driver interface" and make it a proper sentence. Bindings are >> not about drivers. > > This has been addressed by Aurelien and further improved by me in v3. > >>> + clocks: >>> + minItems: 2 > >> Drop minItems. > > Aurelien did that in v2. > >>> + clock-names: >>> + items: >>> + - const: clk >>> + - const: hclk >> >> You need to explain what are these in clocks. Also you need better >> names. A clock name "clk" is useless. > > Clocks now have meaningful names and descriptions. > >>> + reset-names: >>> + items: >>> + - const: reset >> >> Drop reset-names entirely, not useful. > > Aurelien did so in v2. > > Your comments to v2 which I'm aware of are: > https://patchwork.kernel.org/comment/25111597/ > >>> Add the RNG bindings for the RK3568 SoC from Rockchip > >> Use subject prefixes matching the subsystem (git log --oneline -- ...), >> so it is rng, not RNG. Also, you are not adding all-Rockhip RNG but a >> specific device. >> >> Subject: drop second, redundant "bindings". > > I've changed 'RNG' into 'rng' in the subject and spelled it out in the > commit message. And where did you drop the redundant bindings? You just quoted the sentence and ignored it. Best regards, Krzysztof