Re: [PATCH 6/6] arm64: dts: qcom: sm8550-hdk-rear-camera-card: move camss status property

[Krzysztof Kozlowski <krzk@kernel.org>]

On 03/12/2025 13:02, Neil Armstrong wrote:
> On 12/3/25 09:32, Krzysztof Kozlowski wrote:
>> On 03/12/2025 05:05, Vladimir Zapolskiy wrote:
>>> Conventionally status property of device tree nodes is the last one in
>>> the list, move it there.
>>>
>>> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
>>> ---
>>>   arch/arm64/boot/dts/qcom/sm8550-hdk-rear-camera-card.dtso | 3 +--
>>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sm8550-hdk-rear-camera-card.dtso b/arch/arm64/boot/dts/qcom/sm8550-hdk-rear-camera-card.dtso
>>> index 21bfba6a1182..544cec93353a 100644
>>> --- a/arch/arm64/boot/dts/qcom/sm8550-hdk-rear-camera-card.dtso
>>> +++ b/arch/arm64/boot/dts/qcom/sm8550-hdk-rear-camera-card.dtso
>>> @@ -13,10 +13,9 @@
>>>   /plugin/;
>>>   
>>>   &camss {
>>> -	status = "okay";
>>> -
>>>   	vdda-phy-supply = <&vreg_l1e_0p88>;
>>>   	vdda-pll-supply = <&vreg_l3e_1p2>;
>>> +	status = "okay";
>>
>>
>> NAK, making such changes in multiple patches is absolute churn.
> 
> While it may be a "churn" for you, the patch is perfectly valid
> and a NAK is not appropriate since Konrad asked this to be changed
> on the already merged original patchset.
> 
> While you're right we should group such changes, it happens that
> he sm8650 files already have an unified and clean style, and it's
> not a churn to keep the style unified.

We exactly had this discussion and the judgement expressed by Bjorn,
which I general support, was don't change existing source code till we
have the linter for that. And patch one-node-by-one is not valid. Such
patch is still NAK.

Best regards,
Krzysztof