From: Krzysztof Kozlowski <krzk@kernel.org>
To: 曹珊珊 <sandie.cao@deepcomputing.io>
Cc: Conor Dooley <conor@kernel.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Heiko Stuebner <heiko.stuebner@cherry.de>,
Neil Armstrong <neil.armstrong@linaro.org>,
rafal@milecki.pl, Linus Walleij <linus.walleij@linaro.org>,
Michael Zhu <michael.zhu@starfivetech.com>,
Drew Fustini <drew@beagleboard.org>,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dhs@frame.work, ams@frame.work,
gregkh@linuxfoundation.org, yuning.liang@deepcomputing.io,
huiming.qiu@deepcomputing.io
Subject: Re: [patch v2 3/3] riscv: dts: starfive: add framework dts
Date: Tue, 24 Sep 2024 20:40:32 +0200 [thread overview]
Message-ID: <ce90574a-6be8-4415-9943-b559d274cf04@kernel.org> (raw)
In-Reply-To: <407ce3d77416bb2522b7906b0df3d5adf02c27ee.5065befe.6789.4275.a840.52c113c23eb9@feishu.cn>
On 24/09/2024 10:52, 曹珊珊 wrote:
> Hi Krzysztof,
>
> Thanks for your time.
>
> A: jh7110-common.dtsi is also used by other boards. Likes: milkv-mars,
> pine64-star64. So I can only disable them in jh7110-framework.dts.
> Or I need to create a new common.dtsi.
>
> Q: Why PCIE0 is enabled in the DTSI in the first place? The same questions
> about MACs.
>
> Regards,
> Sandie
>
> On 24/09/2024 10:06, Sandie Cao wrote:
>> Add framework dts to support RISC-V Framework Laptop 13 Mainboard.
>>
>> Signed-off-by: Sandie Cao <sandie.cao@deepcomputing.io>
>> ---
>> arch/riscv/boot/dts/starfive/Makefile | 1 +
>> .../boot/dts/starfive/jh7110-framework.dts | 34 +++++++++++++++++++
>> 2 files changed, 35 insertions(+)
>> create mode 100644 arch/riscv/boot/dts/starfive/jh7110-framework.dts
>
> Your threading is entirely broken making applying process more difficult.
So I am talking with myself?
...
>> + status = "disabled";
>> +};
>> +
>> +&pcie0 {
>> + status = "disabled";
>
> Why PCIE0 is enabled in the DTSI in the first place? The same questions
> about MACs.
>
> Best regards,
> Krzysztof
And sending myself regards?
Sorry, no clue what's going on here.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-24 18:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 8:06 [patch v2 3/3] riscv: dts: starfive: add framework dts Sandie Cao
2024-09-24 8:24 ` Krzysztof Kozlowski
[not found] ` <407ce3d77416bb2522b7906b0df3d5adf02c27ee.5065befe.6789.4275.a840.52c113c23eb9@feishu.cn>
2024-09-24 18:40 ` Krzysztof Kozlowski [this message]
2024-09-24 9:55 ` Rafał Miłecki
2024-09-24 16:26 ` Conor Dooley
2024-09-25 1:56 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce90574a-6be8-4415-9943-b559d274cf04@kernel.org \
--to=krzk@kernel.org \
--cc=ams@frame.work \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dhs@frame.work \
--cc=drew@beagleboard.org \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.stuebner@cherry.de \
--cc=huiming.qiu@deepcomputing.io \
--cc=kernel@esmil.dk \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=michael.zhu@starfivetech.com \
--cc=neil.armstrong@linaro.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rafal@milecki.pl \
--cc=robh@kernel.org \
--cc=sandie.cao@deepcomputing.io \
--cc=yuning.liang@deepcomputing.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox