From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0548A35A393; Mon, 29 Jun 2026 10:44:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782729860; cv=none; b=anc+sSKhepdZQKXa/JHrHvqkpovTBYZzhQYNvb/RX+0L+JGiFkYCprtyhLqBhkNU7pFWceOqgyMSqzda188NVxYZZ4vnOLM/7s6uzM1Y83yyYAOOWoEMuaCQZZDiRMhMiXHrRxTqKKRgTQsp3sAEvKWsdl/Ke4sFCrtHHTWpR+4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782729860; c=relaxed/simple; bh=UrkKKcK7pnTq/Fb/9UsUrAYXCMMsm0da+M9gKv9FKR8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sItR6FJJRjtQ4JVT4uCZvYdeTzlNWkMXhF5v2EkoZl7RqmSgDWnIUMQCgPnARG3lc2IxiDQw7tcVf4lK1tbSDQVBtatwCnKQpzkVrKVMHtybQo2pyBrubDYq3ZoZH+KM8/7d+9g8s67+2NlA1YxRA2FAVa8g6BVF0Kle179bFAQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=JKpSgQhg; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="JKpSgQhg" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E6EC3176C; Mon, 29 Jun 2026 03:44:13 -0700 (PDT) Received: from [10.1.37.47] (Suzukis-MBP.cambridge.arm.com [10.1.37.47]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6A29F3F836; Mon, 29 Jun 2026 03:44:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1782729858; bh=UrkKKcK7pnTq/Fb/9UsUrAYXCMMsm0da+M9gKv9FKR8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JKpSgQhgh4ePCnA2/5BaQm4UuepM7qZpdL6L59co1VlGySQGcwtqbiR6eamAS1Caa nJz5RT8Te5qAKaE6MweNw1jjqJldcxWOEXrrZ8b22H5DwYNtaO7i+KPl/rVuhkyOgW IlSPL/bZJHpFP6qr96Kte3VmZkW3WPME1GY7/dAY= Message-ID: Date: Mon, 29 Jun 2026 11:44:14 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 0/7] Provide support for Trigger Generation Unit Content-Language: en-GB To: "Songwei.Chai" , Greg KH Cc: andersson@kernel.org, alexander.shishkin@linux.intel.com, mike.leach@linaro.org, konrad.dybcio@oss.qualcomm.com, james.clark@arm.com, krzk+dt@kernel.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, devicetree@vger.kernel.org References: <20260417073336.2712426-1-songwei.chai@oss.qualcomm.com> <48c6abce-c492-46a6-84ef-3074983e817c@oss.qualcomm.com> <2026062959-distaste-launder-e253@gregkh> From: Suzuki K Poulose In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hello, On 29/06/2026 11:17, Songwei.Chai wrote: > > On 6/29/2026 12:22 PM, Greg KH wrote: >> On Mon, Jun 29, 2026 at 11:03:33AM +0800, Songwei.Chai wrote: >>> Hi Greg & Alexander, >>> >>> Apologies for interrupting again. >>> >>> As the TGU hardware plays an important role in Qualcomm tracing >>> design, I >>> would greatly appreciate it if you could kindly take some time to review >>> this at your earliest convenience. >> The merge window _just_ closed, please give us a chance to catch up. >> >> Also, why us?  Surely you have other reviewers for this code, right? > > Hi Greg, > > Understood, thanks for letting us know. > > Regarding your question: since this introduces a new drivers/hwtracing/ > qcom directory, there is no existing maintainer for it. > Given your scope (and Alexander's), we believe you are the most relevant > reviewers. > > The reason for creating the qcom directory is as follows: > > /We previously tried to upstream this driver under drivers/hwtracing/ > coresight,/ > /but it was not accepted as it is considered Qualcomm-specific and not > tightly/ > /coupled with the CoreSight subsystem. Based on this feedback, we are Some clarification here: This device is not CoreSight so we denied keeping this under drivers/hwtracing/coresight/ - Not because it is Qualcomm specific. We have TPDM, TPDA, TnoC devices under the coresight subsystem, which are all Qualcomm specific for e.g. That said, there are other drivers in drivers/hwtracing/ which I usually merge and push to Greg, after some reviews/acks from the respective people (e.g., PTT HiSilicon PCIe Tune and Trace). But, your proposal was that there were other maintainers for your new subtree and you were going to push this via ,linux-arm-msm ? to which I didn't have any objections. That said, I am fine with pushing this to Greg via the CoreSight pull requests (similar to Hisilicon PTT driver), but would need someone to Maintain/Review the driver (with entries in MAINTAINERS, similar to PTT). Thoughts ? Kind regards Suzuki > exploring/ > /a dedicated drivers/hwtracing/qcom directory, similar to intel_th, to > better/ > /support this and future Qualcomm hwtracing drivers./ > > More details can be found in “[PATCH v14 0/7] -- Why we are proposing > this”. > > Thanks, > Songwei > >> >> thanks, >> >> greg k-h