From: <Claudiu.Beznea@microchip.com>
To: <robh@kernel.org>
Cc: <ulf.hansson@linaro.org>, <Nicolas.Ferre@microchip.com>,
<alexandre.belloni@bootlin.com>,
<Ludovic.Desroches@microchip.com>, <linux-mmc@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 0/4] mmc: pwrseq: sd8787: add support for selectable
Date: Mon, 16 Aug 2021 06:46:39 +0000 [thread overview]
Message-ID: <ce9e6c0c-6ed8-b039-f5b4-67766ecb595a@microchip.com> (raw)
In-Reply-To: <YRbU3NtbYamh7UGH@robh.at.kernel.org>
On 13.08.2021 23:23, Rob Herring wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Fri, Aug 06, 2021 at 02:29:57PM +0300, Claudiu Beznea wrote:
>> Hi,
>>
>> This series adds support for selecting the delay b/w reset and power
>> lines on pwrseq-sd8787. With this the driver could also be used by
>> other devices (e.g. WILC1000/WILC3000 which needs a delay of 5ms). Along
>> with this added the DT bindings for WILC3000 device present on
>> SAMA5D27 WLSOM1 board.
>
> A 300ms delay doesn't work?
It should work as the datasheet specifies a minimum of 5ms is necessary.
> Is powering on the device so timing
> critical?
>
> Add a new compatible for your device and imply the timing from that.
> That way we're not extending the binding a property at a time in a
> poorly designed way for each new timing quirk.
OK, will do it in v2.
Thank you for your review,
Claudiu Beznea
>
> Rob
>
prev parent reply other threads:[~2021-08-16 6:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 11:29 [PATCH 0/4] mmc: pwrseq: sd8787: add support for selectable Claudiu Beznea
2021-08-06 11:29 ` [PATCH 1/4] dt-bindings: mmc: pwrseq-sd8787: add binding for delay b/w reset and power Claudiu Beznea
2021-08-06 11:29 ` [PATCH 2/4] mmc: pwrseq: sd8787: add support for specifying the delay b/w power and reset Claudiu Beznea
2021-08-06 11:30 ` [PATCH 3/4] mmc: pwrseq: add wilc1000_sdio dependency for pwrseq_sd8787 Claudiu Beznea
2021-08-06 11:30 ` [PATCH 4/4] ARM: dts: at91: sama5d27_wlsom1: add wifi device Claudiu Beznea
2021-08-13 20:23 ` [PATCH 0/4] mmc: pwrseq: sd8787: add support for selectable Rob Herring
2021-08-16 6:46 ` Claudiu.Beznea [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce9e6c0c-6ed8-b039-f5b4-67766ecb595a@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).