From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C8B4C4167B for ; Fri, 2 Dec 2022 10:39:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231637AbiLBKj6 (ORCPT ); Fri, 2 Dec 2022 05:39:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229719AbiLBKj2 (ORCPT ); Fri, 2 Dec 2022 05:39:28 -0500 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2DD56F0E4 for ; Fri, 2 Dec 2022 02:39:26 -0800 (PST) Received: by mail-lf1-x135.google.com with SMTP id d6so6754510lfs.10 for ; Fri, 02 Dec 2022 02:39:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ef557i72aMQlngP0CR0TyvH/ZX7gYwQJNFizHVtrS8s=; b=ek+L0K7Nla/F75a0wpr2UxYvBlS35TOSE8Y4aOZSPRGN+orKx3eaQmegEynNl4VcZc rQ8hj2UGt2g+Nd2cUGE5/A9iur4qvaD58k9HH0c85RQ38SpLWG190z/TfK+OB5CB28XE 6Ob8d3L7p+39h8slyCLdErS2iDCLPk0DvJBMvVO8sj5XfZtOcrQ0eaUueB0S2HErbJsh greR/NkPNQEjF5eTng5Na28Rn765Kz0qPJPk0BDWr3DpXxThA8iClKOsotMR5x6WXPf2 EJE8QX0vt5BCeAScVGIzjA9cuOsmysGD8Vd/Jsjnf8MoU3Jq1UtS8FMrQzF7oPvvZ8Yx EQSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ef557i72aMQlngP0CR0TyvH/ZX7gYwQJNFizHVtrS8s=; b=cFbMXH2fBb/tMKRIeuFByCbIYfEHc1fcVQQ6u2aCBO4a05/EddyJiuM+bY9jcF+8Wq 1dWY86f1JXFn/4+TwPAygvqNlI3wtbr1JWzsXgWGEiQr6sLuWoNWA5fQvbcM5psoZ6VC jHdKERe57evr5QMuio/TjOYzqGtROeCdZR2KnZ6j+PQJYu61HrBJinbV04OEQvB1GHGp LIMRjZDePLgYmV08VEuRnlwfukC43QKiW6ehNt3rhLmxROVN04jb6FiCB/A+2jZige2M bmr8hfoOiCOvJ21hLjzGgZTz467T2mSPQrllmmr9qk5jL4mKedZvsA/gMsRTVcpclzT0 hNkQ== X-Gm-Message-State: ANoB5pkSB6oGgICTbTyhJ+BQU6FPHoj/7YTBzleL1VOTHOwnbdKXDlQn PyomxsdQQCuFATBti2GzYgpm3w== X-Google-Smtp-Source: AA0mqf5CiqJzkOnZgB2HygNfmbp7IoLeH7ChCoKN+8ZqGkL7yeYNWcM7WmVgmTfPsS+E7EtfU93Idg== X-Received: by 2002:a19:dc08:0:b0:4b4:6460:24d with SMTP id t8-20020a19dc08000000b004b46460024dmr22964505lfg.386.1669977564984; Fri, 02 Dec 2022 02:39:24 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id v5-20020ac258e5000000b00492ea54beeasm972470lfo.306.2022.12.02.02.39.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Dec 2022 02:39:23 -0800 (PST) Message-ID: Date: Fri, 2 Dec 2022 11:39:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v8 01/11] dt-bindings: clock: meson: add A1 PLL clock controller bindings Content-Language: en-US To: Dmitry Rokosov , Rob Herring Cc: devicetree@vger.kernel.org, sboyd@kernel.org, khilman@baylibre.com, kernel@sberdevices.ru, robh+dt@kernel.org, martin.blumenstingl@googlemail.com, linux-arm-kernel@lists.infradead.org, jian.hu@amlogic.com, linux-kernel@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-amlogic@lists.infradead.org, jbrunet@baylibre.com, rockosov@gmail.com, mturquette@baylibre.com, linux-clk@vger.kernel.org, neil.armstrong@linaro.org References: <20221201225703.6507-1-ddrokosov@sberdevices.ru> <20221201225703.6507-2-ddrokosov@sberdevices.ru> <166995398251.2089685.16059995540663317860.robh@kernel.org> <20221202095124.4ecpfqhtzf34lwbf@CAB-WSD-L081021> From: Krzysztof Kozlowski In-Reply-To: <20221202095124.4ecpfqhtzf34lwbf@CAB-WSD-L081021> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 02/12/2022 10:51, Dmitry Rokosov wrote: > On Thu, Dec 01, 2022 at 10:10:04PM -0600, Rob Herring wrote: >> >> On Fri, 02 Dec 2022 01:56:53 +0300, Dmitry Rokosov wrote: >>> From: Jian Hu >>> >>> Add the documentation to support Amlogic A1 PLL clock driver, >>> and add A1 PLL clock controller bindings. >>> >>> Signed-off-by: Jian Hu >>> Signed-off-by: Dmitry Rokosov >>> --- >>> .../bindings/clock/amlogic,a1-pll-clkc.yaml | 52 +++++++++++++++++++ >>> include/dt-bindings/clock/a1-pll-clkc.h | 16 ++++++ >>> 2 files changed, 68 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml >>> create mode 100644 include/dt-bindings/clock/a1-pll-clkc.h >>> >> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> yamllint warnings/errors: >> ./Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml:26:6: [warning] wrong indentation: expected 6 but found 5 (indentation) >> >> dtschema/dtc warnings/errors: >> ./Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml: $id: relative path/filename doesn't match actual path or filename >> expected: http://devicetree.org/schemas/clock/amlogic,a1-pll-clkc.yaml# >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.example.dtb: pll-clock-controller@7c80: reg: [[0, 31872], [0, 396]] is too long >> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml >> >> doc reference errors (make refcheckdocs): >> >> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221201225703.6507-2-ddrokosov@sberdevices.ru >> >> The base for the series is generally the latest rc1. A different dependency >> should be noted in *this* patch. >> >> If you already ran 'make dt_binding_check' and didn't see the above >> error(s), then make sure 'yamllint' is installed and dt-schema is up to >> date: >> >> pip3 install dtschema --upgrade >> >> Please check and re-submit after running the above command yourself. Note >> that DT_SCHEMA_FILES can be set to your schema file to speed up checking >> your schema. However, it must be unset to test all examples with your schema. >> > > Please find all fixes of above warnings and errors in the my patch > located at the link: > > https://lore.kernel.org/linux-amlogic/20221201225703.6507-9-ddrokosov@sberdevices.ru/ Why? This patch here is broken and it should be fixed. Don't apply broken patches... Best regards, Krzysztof