From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 793A73E9F61 for ; Tue, 31 Mar 2026 08:49:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774946969; cv=none; b=aEZlVpbv8HAIHl3CXn9xCOnhdHLNEjXVi8d1icTuhwdiDzaVPsimcNMYeiG+rw/by1Ci31fATMvRE5N2TlzFY/Hxv+F2/gJHKmaUGdqV0j8jYqHkJKTISDd6oWJzarb2x+6ZtpmaMKye7yM1la5zheeTzQqSF3HdmPSOB1YYw5A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774946969; c=relaxed/simple; bh=4X4aBEfpdQbm3c1odjqr9GWQmAZFTeQXJk9rSc9v2p8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=O+wh0u2jrdWEZ8/yMUzBBby5gwKUu1fHoSCrZ2LolCKfHggJmjnw2ImTb7r66a4G5GV7gw65iwT7i5E/n6TvEGQtUo5M6a7+HEDLDawWUqQpZqG3vMJWZzvzRghMjR1K4tVqVzAA2BoEm8qqsPP9nVeF0O1oZCySvekM4+Ne4wk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IxiWadQU; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IxiWadQU" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-c76af79f029so271655a12.3 for ; Tue, 31 Mar 2026 01:49:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774946968; x=1775551768; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7Z189t+doKS0SdPI8It61kpi9R3t4BM5IY1DGGtz47k=; b=IxiWadQUrvBkZHqXt6TQo8bF6lsj1b+rL34nnhBvWvNG9MJ94X+EXEDKyulLv91TiG SvDSr/dc05kHuoWim5el4XyxQ5WPDYUW1i19CDloJKwXbHFPXBAFyq2A4lri/MgCmJwS 7L4ONQIWbPOb3kXg3qURaIy/RrbjMWUStsygFVfGgbmhyz6EgU4mJbv1fl7GZ6PUg3Hm Cq8mhXLJ0zaOO9Fe1o2cHhmzm7f4V5XCyZ1ADcfC8c2+6ugSUrwjCnUkWn02G4NsCDH5 L3e7a+lAjfu6NGq38kYfy86dLmFmPtuZCyzPWmmcDk3FyNn1bDQIs8q0Z4jUQfioA1LL pXTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774946968; x=1775551768; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7Z189t+doKS0SdPI8It61kpi9R3t4BM5IY1DGGtz47k=; b=GUzPOYy2LE924A2CnvvgTIa19ReR8mxEkICtfRyXdd3MERgbT5ZjWqCdUEoltKE9bn 53z3Qgm6KE7ihBdfCKpB+Qbqoqbib5tpMlpx9OXnOkTV0VhO2dkR/xW0JGk86D168F2a HVuv47RTFGNpOtMR81O6ee0wJRe9MNrcknwqG8sprYo8NGI2G9EtUrpxdUJ4JPEcxN6E 19hA5mMOc7qh81MuB6Sb0lha8DjcqOawmIHmE0dd/GY5MO01o1QSTBq8rmBabPxQOHtf TRcVeeSJnute7Yw6tTALwQtbvr+ao1PxVWwH5epanqUey462QxnA6BGUPbYR8MESB4s4 kW7w== X-Forwarded-Encrypted: i=1; AJvYcCWIMZ/6moH1bAbYC5RUu6HqxGnGkmYSX7nMGsI1TxJQwR0c1stuiX6Mux0rXX8fxdp1lViWdsMSrsVO@vger.kernel.org X-Gm-Message-State: AOJu0YwxzMAku5oxvBkx0JSYrt4mvpvc4eqJwZhRbYXPpgjGGute/Of1 bb3Evf+NFsHHw2Z+q+0XkEh8o3cH6+T/RENpsEFYqBQchLeNomrX358J X-Gm-Gg: ATEYQzwwrIIpMA7c6Ix3+d3ukFsaSrN84Hjy4tbWpNlvD9TFk7my/u0/JzhuISizQdU NbI/Mb/qEUbCfYAaI/Jg+o7N/kzyjOGmyqIe2BVOkU6zie8wU9MUX6PZR6Eax6oTv3Tjk3AZdIs noYGyHuyUslz5yBTcAZBdQpit/eradU2IV+cE0PaONGK2OpNSS/wGoUx8mk6ewZMyxzLStumlOK 9x6n+FDkX/hBLHWJKBZB/wXE7+ZmzvHyQZh+AAVzyI8ndiDH4j+39eJy+dEGvhzK5lAApV98Nwz dpc+JFkh2dK2BKCwvpYIN+9pef3D5EcnNwssUPNaN9l1S2D006M4UfChHYmHO+a6F8WRz3logL0 AbNNmGhO8/OUgig8URazhqgPeS9lPH9CNbdnJKgKkhv38U7RerIgNTA9dz2IElWyUmm4P0SKMwh 8JKoXxVj0cmHWQnHYsJSKhK/2jx1bFUJGfNWOOfOen+68EB/Y= X-Received: by 2002:a17:903:98f:b0:2b0:6cb5:c6c5 with SMTP id d9443c01a7336-2b0cdd44b5fmr160933055ad.49.1774946967705; Tue, 31 Mar 2026 01:49:27 -0700 (PDT) Received: from [172.16.20.13] ([136.226.252.245]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b24265aa9fsm101511695ad.20.2026.03.31.01.49.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Mar 2026 01:49:26 -0700 (PDT) Message-ID: Date: Tue, 31 Mar 2026 14:19:16 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v15 3/3] arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board To: Dmitry Baryshkov Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio References: <20260302121159.1938694-1-tessolveupstream@gmail.com> <20260302121159.1938694-4-tessolveupstream@gmail.com> Content-Language: en-US From: tessolveupstream@gmail.com In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 02-03-2026 18:43, Dmitry Baryshkov wrote: > On Mon, Mar 02, 2026 at 05:41:59PM +0530, Sudarshan Shetty wrote: >> Add the device tree for the QCS615-based Talos EVK platform. The >> platform is composed of a System-on-Module following the SMARC >> standard, and a Carrier Board. >> >> The Carrier Board supports several display configurations, HDMI and >> LVDS. Both configurations use the same base hardware, with the display >> selection controlled by a DIP switch. >> >> Use a DTBO file, talos-evk-lvds-auo,g133han01.dtso, which defines an >> overlay that disables HDMI and adds LVDS. The DTs file talos-evk >> can describe the HDMI display configurations. >> >> According to the hardware design and vendor guidance, the WiFi PA >> supplies VDD_PA_A and VDD_PA_B only need to be enabled at the same time >> as asserting WLAN_EN. >> >> On this platform, WiFi enablement is controlled via the WLAN_EN GPIO >> (GPIO84), which also drives the VDD_PA_A and VDD_PA_B power enables. >> Remove the VDD_PA_A and VDD_PA_B regulator nodes from the device tree >> and rely on WLAN_EN to enable WiFi functionality. >> >> Add talos-evk-usb1-peripheral.dtso overlay to enable USB0 peripheral >> (EDL) mode. The base DTS will keep USB0 host-only due to hardware >> routing through the EDL DIP switch, and the overlay switches the >> configuration for device-mode operation. >> >> The LVDS backlight hardware has been updated to use a simplified >> design. The backlight enable signal is now permanently pulled up >> to 3.3V and is no longer controlled via GPIO59. >> >> Remove the GPIO59 based backlight configuration from the device >> tree, as it is no longer routed to the LVDS interface. >> >> The initial device tree includes support for: >> - CPU and memory >> - UART >> - GPIOs >> - Regulators >> - PMIC >> - Early console >> - AT24MAC602 EEPROM >> - MCP2515 SPI to CAN >> - ADV7535 DSI-to-HDMI bridge >> - DisplayPort interface >> - SN65DSI84ZXHR DSI-to-LVDS bridge >> - Wi-Fi/BT >> >> Reviewed-by: Dmitry Baryshkov >> Reviewed-by: Konrad Dybcio >> Signed-off-by: Sudarshan Shetty >> --- >> arch/arm64/boot/dts/qcom/Makefile | 6 + >> .../qcom/talos-evk-lvds-auo,g133han01.dtso | 127 ++++ >> arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 614 ++++++++++++++++++ >> .../dts/qcom/talos-evk-usb1-peripheral.dtso | 10 + >> arch/arm64/boot/dts/qcom/talos-evk.dts | 139 ++++ >> 5 files changed, 896 insertions(+) >> create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-lvds-auo,g133han01.dtso >> create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-som.dtsi >> create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-usb1-peripheral.dtso >> create mode 100644 arch/arm64/boot/dts/qcom/talos-evk.dts > >> + >> + regulator-usb2-vbus { >> + compatible = "regulator-fixed"; >> + regulator-name = "USB2_VBUS"; >> + gpio = <&pm8150_gpios 10 GPIO_ACTIVE_HIGH>; >> + pinctrl-0 = <&usb2_en>; >> + pinctrl-names = "default"; >> + enable-active-high; >> + regulator-always-on; >> + }; > > Hmm. I hoped that we are past this stage. Please order the nodes. > Okay, will take care in the next patch series. >> + >> + vreg_conn_1p8: regulator-conn-1p8 { >> + compatible = "regulator-fixed"; >> + regulator-name = "vreg_conn_1p8"; >> + startup-delay-us = <4000>; >> + enable-active-high; >> + gpio = <&pm8150_gpios 1 GPIO_ACTIVE_HIGH>; >> + }; >> + >> + vreg_conn_pa: regulator-conn-pa { >> + compatible = "regulator-fixed"; >> + regulator-name = "vreg_conn_pa"; >> + startup-delay-us = <4000>; >> + enable-active-high; >> + gpio = <&pm8150_gpios 6 GPIO_ACTIVE_HIGH>; >> + }; >> + >> + vreg_v3p3_can: regulator-v3p3-can { >> + compatible = "regulator-fixed"; >> + regulator-name = "vreg-v3p3-can"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + regulator-boot-on; >> + regulator-always-on; >> + }; >> + >> + vreg_v5p0_can: regulator-v5p0-can { >> + compatible = "regulator-fixed"; >> + regulator-name = "vreg-v5p0-can"; >> + regulator-min-microvolt = <5000000>; >> + regulator-max-microvolt = <5000000>; >> + regulator-boot-on; >> + regulator-always-on; >> + }; >> + > > [...] > >> + >> +/* >> + * USB0 routing and EDL mode: >> + * >> + * The USB0 controller’s HS differential pair is switched (manually) >> + * between the Micro-USB port for EDL/ADB and the on-board USB 3.0 hub. >> + * >> + * During EDL (Emergency Download) mode, the HS lines are explicitly >> + * routed to the Micro-USB port to allow the SoC to enter device mode >> + * for flashing. >> + * >> + * After EDL the switch is normally toggled so the HS lines stay >> + * connected to the hub’s Type-A downstream ports, leaving no electrical >> + * path to the Micro-USB connector — therefore USB0 runs host-only in >> + * normal runtime and device mode must not be advertised. >> + * >> + * USB0 is configured host-only in the base device tree; a separate >> + * device-tree overlay enables the Micro-USB peripheral configuration for >> + * ADB. For ADB to work during normal runtime the DIP switch SW1 must be >> + * manually toggled to the off position (reconnecting the HS pair to the >> + * Micro-USB port). >> + */ >> + >> +&usb_1 { >> + status = "okay"; >> +}; >> + > > >> diff --git a/arch/arm64/boot/dts/qcom/talos-evk-usb1-peripheral.dtso b/arch/arm64/boot/dts/qcom/talos-evk-usb1-peripheral.dtso >> new file mode 100644 >> index 000000000000..2f4630a6ba66 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/talos-evk-usb1-peripheral.dtso >> @@ -0,0 +1,10 @@ >> +// SPDX-License-Identifier: BSD-3-Clause >> +/* >> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> + */ >> +/dts-v1/; >> +/plugin/; > > Comment, what should be changed to make use of it. > Sure, will add it in the next patch series. >> + >> +&usb_1_dwc3 { >> + dr_mode = "peripheral"; >> +}; >