From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3D8FEB64D7 for ; Fri, 23 Jun 2023 16:36:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232158AbjFWQgn (ORCPT ); Fri, 23 Jun 2023 12:36:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbjFWQgm (ORCPT ); Fri, 23 Jun 2023 12:36:42 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B4802710 for ; Fri, 23 Jun 2023 09:36:38 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-989d03eae11so100591566b.2 for ; Fri, 23 Jun 2023 09:36:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687538197; x=1690130197; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=82HY4/N7H6ucguobBtwBPDTijk8Xv1cE56l9sSPsxZk=; b=gXumuoABzaqNQrTAPADk7TpH996PxPqGimC1fk5TwHSX1NxCP+vPpm87M0RBn0g5g5 uQf0LItR4JYmJvq7kLg7RSngoZ5yebX7B/riec3E5Jup9770bo1bJleknLvmNcTPiwJQ oIgPz0QPnPZ8IdIzsq+8YNyS2bbEq+WaGGu5wkVGRLVc+Ww59kE5mdCnMzNrR4pdePLX M2V3g2rrsuU2TlhCW8PQWgaK2VxUB34/kkgrg8+qizDiPppCyyNx556iOO+x7JzLvj62 n0YPT8PfBKfF7qBDllOv0gAR4fW09Tya1z55nAunUkxTkn1ORUJzT2wN6KHsdQrzrUrj MJtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687538197; x=1690130197; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=82HY4/N7H6ucguobBtwBPDTijk8Xv1cE56l9sSPsxZk=; b=PBcEQbqJKfjjL3VvpKx2M9NsWABZ9pDzAzpFCbsYnVxWsY75KKrmSVG0703mof8TeZ qTLNi4z4aDAJKJPbfiIyOjM3K8dCVmE73FGB58n+o3ImKzbR6mOPuGvPsRq2MpK0H6cU G59+NW6d+gc/j6b14eTeKyHQQbDXXfcQydWh+uKoECU3ebIFthxVrscbDm0NGDr6ns6u v/lZu8zOXiiMoiZtP5MMsuaMwVSMBlohFn7LaFqQkSFtGoAeDuL8RVcthE6IxMV/yApr jwcm7haCrJAFyoQ5Hc33SBcWlobiy33bxyQjTsGEmCaBq/vV5vBZSVnTlPYRtyK8dnCz txSw== X-Gm-Message-State: AC+VfDyJwi/5lGBOrHAHH2UP4YL+5CIKfXxUizBp3sSwl7dmgqeqDnRX +8dEbYB5HCDR9R+0nMLcqsdqdg== X-Google-Smtp-Source: ACHHUZ6M6Rf3wT3cyji8AXUD2VmxjBtLQA6pE2h/h8k7r53MMuLZmgKmdzpknKGLRiTihchDqPMk2w== X-Received: by 2002:a17:907:7e8b:b0:988:fafd:d93a with SMTP id qb11-20020a1709077e8b00b00988fafdd93amr12564350ejc.70.1687538196987; Fri, 23 Jun 2023 09:36:36 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id f3-20020a1709062c4300b009887bb956e0sm6175075ejh.103.2023.06.23.09.36.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jun 2023 09:36:36 -0700 (PDT) Message-ID: Date: Fri, 23 Jun 2023 18:36:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v4 1/6] dt-bindings: nvmem: sec-qfprom: Add bindings for secure qfprom Content-Language: en-US To: Komal Bajaj , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Srinivas Kandagatla , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20230623141806.13388-1-quic_kbajaj@quicinc.com> <20230623141806.13388-2-quic_kbajaj@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20230623141806.13388-2-quic_kbajaj@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23/06/2023 16:18, Komal Bajaj wrote: > This patch adds bindings for secure qfprom found in QCOM SOCs. > SECURE QFPROM driver is based on simple nvmem framework. > > Signed-off-by: Komal Bajaj > --- > .../bindings/nvmem/qcom,sec-qfprom.yaml | 58 +++++++++++++++++++ > 1 file changed, 58 insertions(+) > create mode 100644 Documentation/devicetree/bindings/nvmem/qcom,sec-qfprom.yaml > > diff --git a/Documentation/devicetree/bindings/nvmem/qcom,sec-qfprom.yaml b/Documentation/devicetree/bindings/nvmem/qcom,sec-qfprom.yaml > new file mode 100644 > index 000000000000..675e27918c7b > --- /dev/null > +++ b/Documentation/devicetree/bindings/nvmem/qcom,sec-qfprom.yaml > @@ -0,0 +1,58 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/nvmem/qcom,sec-qfprom.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies Inc, SECURE QFPROM Efuse SECURE is not acronym, so "Secure". > + > +maintainers: > + - Komal Bajaj Add description: with explanation what is this. Specifically it should be quite clear what is here different than regular QFPROM > + > +allOf: > + - $ref: nvmem.yaml# > + > +properties: > + compatible: > + items: > + - enum: > + - qcom,qdu1000-sec-qfprom > + - const: qcom,sec-qfprom > + > + reg: > + items: > + - description: The secure qfprom corrected region. > + > + # Needed if any child nodes are present. > + "#address-cells": > + const: 1 > + "#size-cells": > + const: 1 Drop both, they are not needed. > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + efuse@221c8000 { > + compatible = "qcom,qdu1000-sec-qfprom", "qcom,sec-qfprom"; > + reg = <0 0x221c8000 0 0x1000>; > + #address-cells = <1>; > + #size-cells = <1>; > + > + multi_chan_ddr: multi_chan_ddr@12b { No underscores in node names. Best regards, Krzysztof