From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Abel Vesa <abel.vesa@linaro.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v5 10/10] arm64: dts: qcom: Add base SM8550 MTP dts
Date: Tue, 6 Dec 2022 12:44:54 +0100 [thread overview]
Message-ID: <cebb1182-ca05-b339-8990-e85fff43bcb7@linaro.org> (raw)
In-Reply-To: <20221205230342.494923-11-abel.vesa@linaro.org>
On 06/12/2022 00:03, Abel Vesa wrote:
> Add dts file for Qualcomm MTP platform which uses SM8550 SoC.
>
> Co-developed-by: Neil Armstrong <neil.armstrong@linaro.org>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 404 ++++++++++++++++++++++++
> 2 files changed, 405 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/sm8550-mtp.dts
>
Thank you for your patch. There is something to discuss/improve.
> +
> +&qupv3_id_0 {
> + status = "okay";
> +};
> +
> +&sdhc_2 {
> + cd-gpios = <&pm8550_gpios 12 GPIO_ACTIVE_LOW>;
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&sdc2_default &sdc2_card_det_n>;
> + pinctrl-1 = <&sdc2_sleep &sdc2_card_det_n>;
> + vmmc-supply = <&vreg_l9b_2p9>;
> + vqmmc-supply = <&vreg_l8b_1p8>;
> + bus-width = <4>;
> + no-sdio;
> + no-emmc;
no-mmc
https://lore.kernel.org/linux-devicetree/20221204094438.73288-2-krzysztof.kozlowski@linaro.org/
Best regards,
Krzysztof
prev parent reply other threads:[~2022-12-06 11:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 23:03 [PATCH v5 00/10] arm64: dts: Add base device tree files for SM8550 Abel Vesa
2022-12-05 23:03 ` [PATCH v5 01/10] dt-bindings: arm: qcom: Document SM8550 SoC and boards Abel Vesa
2022-12-05 23:03 ` [PATCH v5 02/10] arm64: dts: qcom: Add base SM8550 dtsi Abel Vesa
2022-12-05 23:03 ` [PATCH v5 03/10] arm64: dts: qcom: Add pm8010 pmic dtsi Abel Vesa
2022-12-05 23:03 ` [PATCH v5 04/10] arm64: dts: qcom: Add PM8550 " Abel Vesa
2022-12-05 23:03 ` [PATCH v5 05/10] arm64: dts: qcom: Add PM8550b " Abel Vesa
2022-12-05 23:03 ` [PATCH v5 06/10] arm64: dts: qcom: Add PM8550ve " Abel Vesa
2022-12-05 23:03 ` [PATCH v5 07/10] arm64: dts: qcom: Add PM8550vs " Abel Vesa
2022-12-05 23:03 ` [PATCH v5 08/10] arm64: dts: qcom: Add PMK8550 " Abel Vesa
2022-12-05 23:03 ` [PATCH v5 09/10] arm64: dts: qcom: Add PMR735d " Abel Vesa
2022-12-05 23:03 ` [PATCH v5 10/10] arm64: dts: qcom: Add base SM8550 MTP dts Abel Vesa
2022-12-06 11:44 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cebb1182-ca05-b339-8990-e85fff43bcb7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).