From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2EC5C352A1 for ; Tue, 6 Dec 2022 11:45:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234194AbiLFLpK (ORCPT ); Tue, 6 Dec 2022 06:45:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233396AbiLFLo7 (ORCPT ); Tue, 6 Dec 2022 06:44:59 -0500 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E2AE27DF9 for ; Tue, 6 Dec 2022 03:44:57 -0800 (PST) Received: by mail-lf1-x12c.google.com with SMTP id b13so12293637lfo.3 for ; Tue, 06 Dec 2022 03:44:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Zs/glU61iMmBEYzfjQPXxEkfHrnwIczjCeiehS51xyg=; b=ZowRqI21xHzHjcUsGCIreEkHoDNuEcDh/y4chsUa54F27NggrLlvBnCDYQ6qIF2ZDh MDGOF3EeoPGe7gRaA24mEtqr3F5NNjk34cwjTRnUm1My5khxRdA5FGGY9RH4cOWNjdAv lSLaVA9HdJA0Q7yKQMeCEU2bmSCDMxnsG3qttL0fjORoCuVvww4AgTwubuwvZBNpMxZQ dm/GqmvZRF38t5UbgJ0LYv+B3SqhdnDVqpW1ewLwVr5jqVBg9YWXqjgRaAffzExOp7hu GrxYK/tFsPJEypaRxEwq00CjoVKdGZ45O9A2T8SwO4N1KyUqlnQ1XkODroJzz/gOaxX1 6/Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Zs/glU61iMmBEYzfjQPXxEkfHrnwIczjCeiehS51xyg=; b=O0/VzXet3heQzEvsAfOma/n/jRXWzdmPCNniY9fY6tnX+iZQSEiTtUBSpUPi4JZvMr aX8923CKMaQ7mF51RKJByIl1Y/sMIyKS9r+cKskbum+yRc9WQTDd7TSD0CrNh0TCWrhj uVmw3rkeoe3i1C8NROisUmeh6Z20VLFeQ7v0GWPywDpnNJMLxwn4hWQm48IDFisA7nVE tSUprVc/G8puwzl1HkbWMhgoBze2Ru6XPWeF8MS0nrwIWYqZCvQF7VF9K9KKCE9jc1ZB Yw9C+NOZmvx4XyxS23ycGZig4MQf7Xv5eYGiknXa25h+IqokSAB98jXwVka9OXX8SEst ZsSA== X-Gm-Message-State: ANoB5pkouMXXbBw7PsoL7e2xq1qgRr4XtefuEnCiz9QJi2Aho+REn66x eKlbUP9kNDK32T6OZz1vBp3kvoRFKjqp5ocYrg0= X-Google-Smtp-Source: AA0mqf6h22DC0KAQue5KYSYozblSb2wE8jNlr6J8sY+ZRFEnDjvn3P/MsgXcd3eJtC3umMD+KbGwsA== X-Received: by 2002:ac2:488e:0:b0:4b4:cf32:e105 with SMTP id x14-20020ac2488e000000b004b4cf32e105mr27927160lfc.110.1670327095941; Tue, 06 Dec 2022 03:44:55 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id j12-20020a056512344c00b004a05402c5c3sm2468044lfr.93.2022.12.06.03.44.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Dec 2022 03:44:55 -0800 (PST) Message-ID: Date: Tue, 6 Dec 2022 12:44:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v5 10/10] arm64: dts: qcom: Add base SM8550 MTP dts Content-Language: en-US To: Abel Vesa , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Neil Armstrong Cc: Linux Kernel Mailing List , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20221205230342.494923-1-abel.vesa@linaro.org> <20221205230342.494923-11-abel.vesa@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20221205230342.494923-11-abel.vesa@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 06/12/2022 00:03, Abel Vesa wrote: > Add dts file for Qualcomm MTP platform which uses SM8550 SoC. > > Co-developed-by: Neil Armstrong > Signed-off-by: Neil Armstrong > Signed-off-by: Abel Vesa > Reviewed-by: Konrad Dybcio > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 404 ++++++++++++++++++++++++ > 2 files changed, 405 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/sm8550-mtp.dts > Thank you for your patch. There is something to discuss/improve. > + > +&qupv3_id_0 { > + status = "okay"; > +}; > + > +&sdhc_2 { > + cd-gpios = <&pm8550_gpios 12 GPIO_ACTIVE_LOW>; > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sdc2_default &sdc2_card_det_n>; > + pinctrl-1 = <&sdc2_sleep &sdc2_card_det_n>; > + vmmc-supply = <&vreg_l9b_2p9>; > + vqmmc-supply = <&vreg_l8b_1p8>; > + bus-width = <4>; > + no-sdio; > + no-emmc; no-mmc https://lore.kernel.org/linux-devicetree/20221204094438.73288-2-krzysztof.kozlowski@linaro.org/ Best regards, Krzysztof