From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FE6AC71134 for ; Fri, 25 Aug 2023 18:37:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229646AbjHYSgo (ORCPT ); Fri, 25 Aug 2023 14:36:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229557AbjHYSgN (ORCPT ); Fri, 25 Aug 2023 14:36:13 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EFA2210B for ; Fri, 25 Aug 2023 11:36:11 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2bcc187e0b5so18511431fa.1 for ; Fri, 25 Aug 2023 11:36:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692988570; x=1693593370; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oLEWMSPoyDheV9aTWoheYwMz3Vo4cd285Ih/pF7lT2I=; b=pJQyhkVl8YcIipcJ9Pzn13f/51SIzHseZSrVHyxc/scyKp7w5fsxK3cIEPlHjeZrHt 7ZHxrE1tArirkg5nPVfBjrKajoBefPz9yQoQU7YmcMTMdctl+jxM9qQG1qE3w7JUzqpd 9C9oRpX6KCuD5AHYQOp1EkdHw28eBKFRSPcNNu/W4XikXdqZjC3Bucov4M9YlV7Jw6TS gCMhOKiV8lYDps6chtAYxjD63Ef33wB6O93grYOZxwsEdgFcc/X6vLbxn56egIBLPoi+ fQfc2u4GWN8fSQieypYlVtMGYZwbmWbMEkdWfOkMOi1cg4fKsAa5t+VQIiPPuRE6AmlL Zkjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692988570; x=1693593370; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oLEWMSPoyDheV9aTWoheYwMz3Vo4cd285Ih/pF7lT2I=; b=BHMsuWu00QCvhxMLo9ZMF+Uem2zWHvXabQDyprlpsGXUSsK/Wf+ZLOhGLiIETaZh2t 7DJZXPDqX/o6ZVrVlaY9m5MN6Q5eKKAT0FYq6RLEMB3Fu+HX8eeKkjKm64ZXTiyIRaoN 9j+aKaJcGyoDAFWuO6B3CZiAyJlGp6l+Kw2QbuKSRtTUHxJrRlOMwYbdVi/RXQa/7Nql HRqVtcoCUkq6UlY8sNGl1JT9RKgdfXYV8cWavay34BIunMoHMnAHaqJGRTBNwSKX6JIq Y8N7ier2NiD10JNo36n0qMfIkOMjgbEXAW2Y0IIhF6bbdSL/oJcJAYmyyccpPnuxP4Hn mb8A== X-Gm-Message-State: AOJu0Yzhn5x/h8xerJ99iNGJOC5Vg+9ARHXSoSWBWRqm8WfZgb4T9Ts+ YLeNZjugpF3JnrZey0tFIS5eaQ== X-Google-Smtp-Source: AGHT+IHR8jriiddvsNutBDC/1xD3vmu1DzeYiRUzYUGOZrKMh2tFjAv8dxJQY+RNx+WKq9/5jF2DQw== X-Received: by 2002:a2e:3610:0:b0:2bc:dea8:ba75 with SMTP id d16-20020a2e3610000000b002bcdea8ba75mr6346933lja.26.1692988569683; Fri, 25 Aug 2023 11:36:09 -0700 (PDT) Received: from [192.168.1.101] (abxh59.neoplus.adsl.tpnet.pl. [83.9.1.59]) by smtp.gmail.com with ESMTPSA id n12-20020a2e878c000000b002b787442f03sm438279lji.88.2023.08.25.11.36.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Aug 2023 11:36:09 -0700 (PDT) Message-ID: Date: Fri, 25 Aug 2023 20:36:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: qcom: sdm845: cheza doesn't support LMh node Content-Language: en-US To: Doug Anderson , David Heidelberg Cc: cros-qcom-dts-watchers@chromium.org, Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thara Gopinath , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230823222741.89584-1-david@ixit.cz> <20230823222741.89584-2-david@ixit.cz> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 24.08.2023 20:24, Doug Anderson wrote: > Hi, > > On Wed, Aug 23, 2023 at 3:28 PM David Heidelberg wrote: >> >> Cheza firmware doesn't allow controlling LMh from the operating system. >> >> Fixes: 36c6581214c4 ("arm64: dts: qcom: sdm845: Add support for LMh node") >> Suggested-by: Dmitry Baryshkov >> Signed-off-by: David Heidelberg >> --- >> arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi >> index d86b0d112110..8cc8fc290fd3 100644 >> --- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi >> @@ -143,6 +143,10 @@ panel_in_edp: endpoint { >> }; >> }; >> >> +&cpufreq_hw { >> + /delete-property/ interrupts-extended; /* reference to lmh_cluster[01] */ >> +}; >> + >> &psci { >> /delete-node/ power-domain-cpu0; >> /delete-node/ power-domain-cpu1; >> @@ -275,6 +279,14 @@ &BIG_CPU_SLEEP_1 >> &CLUSTER_SLEEP_0>; >> }; >> >> +&lmh_cluster0 { >> + status = "disabled"; >> +}; >> + >> +&lmh_cluster1 { >> + status = "disabled"; >> +}; > > It's not a huge deal to me, but as I understand it usually you'd put > the "disabled" in sdm845.dtsi and then it would be up to all the other > sdm845 boards to mark this as "okay". it's more of a status = "nonstandardfirmware" :/ > > >> /* >> * Reserved memory changes >> * >> @@ -338,6 +350,8 @@ flash@0 { >> >> >> &apps_rsc { >> + /delete-property/ power-domains; >> + > > Is the deletion of the "power-domains" here related to LMh? That seems > like it was added to sdm845.dtsi in a separate commit that doesn't > talk about LMh at all... psci